[jira] [Comment Edited] (CASSANDRA-15234) Standardise config and JVM parameters

["Ekaterina Dimitrova (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-15234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17075947#comment-17075947 ] 

Ekaterina Dimitrova edited comment on CASSANDRA-15234 at 4/5/20, 10:09 PM:
---------------------------------------------------------------------------

Part 1 was fixed and CI run showed no issues, forgot to update the ticket. Part II(capability for the users to pickup units) and Part III(the system properties accessors) will have to pass CI run tonight. 
I am currently using the ByteUnit approach (referring to the DatabaseDescriptor) for the part II conversion of space and rate units. Please let me know if I am missing some other utility that could be used better for this goal.


was (Author: e.dimitrova):
Part 1 was fixed and CI run showed no issues, forgot to update the ticket. Part II(capability for the users to pickup units) and Part III(the system properties accessors) will have to pass CI run tonight. 

> Standardise config and JVM parameters
> -------------------------------------
>
>                 Key: CASSANDRA-15234
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15234
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local/Config
>            Reporter: Benedict Elliott Smith
>            Assignee: Ekaterina Dimitrova
>            Priority: Normal
>             Fix For: 4.0, 4.0-beta
>
>
> We have a bunch of inconsistent names and config patterns in the codebase, both from the yams and JVM properties.  It would be nice to standardise the naming (such as otc_ vs internode_) as well as the provision of values with units - while maintaining perpetual backwards compatibility with the old parameter names, of course.
> For temporal units, I would propose parsing strings with suffixes of:
> {{code}}
> u|micros(econds?)?
> ms|millis(econds?)?
> s(econds?)?
> m(inutes?)?
> h(ours?)?
> d(ays?)?
> mo(nths?)?
> {{code}}
> For rate units, I would propose parsing any of the standard {{B/s, KiB/s, MiB/s, GiB/s, TiB/s}}.
> Perhaps for avoiding ambiguity we could not accept bauds {{bs, Mbps}} or powers of 1000 such as {{KB/s}}, given these are regularly used for either their old or new definition e.g. {{KiB/s}}, or we could support them and simply log the value in bytes/s.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org