You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/16 23:16:58 UTC

[GitHub] [arrow] lidavidm commented on a change in pull request #7994: ARROW-9804: [FlightRPC] Flight auth redesign

lidavidm commented on a change in pull request #7994:
URL: https://github.com/apache/arrow/pull/7994#discussion_r506759118



##########
File path: java/flight/flight-core/src/main/java/org/apache/arrow/flight/CallOptions.java
##########
@@ -56,7 +56,7 @@ public static CallOption timeout(long duration, TimeUnit unit) {
   /**
    * CallOptions specific to GRPC stubs.
    */
-  interface GrpcCallOption extends CallOption {
+  public interface GrpcCallOption extends CallOption {

Review comment:
       Hmm, that is a problem. We also don't want to expose gRPC details from the core package, though...leaving this as-is is probably simplest, though, seeing as a non-gRPC flight implementation is still a ways off.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org