You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "George Harley (JIRA)" <ji...@apache.org> on 2006/07/04 16:24:30 UTC

[jira] Resolved: (HARMONY-738) [classlib][nio] Refine two unstable tests in o.a.h.tests.java.nio.channels.SourceChannelTest

     [ http://issues.apache.org/jira/browse/HARMONY-738?page=all ]
     
George Harley resolved HARMONY-738:
-----------------------------------

    Resolution: Fixed

Hi Andrew, 

Changes committed in revision 419017. Please could you verify that they have been applied as expected. 

Many thanks for this enhancement to the nio test suite. 

Best regards, 
George


> [classlib][nio] Refine two unstable tests in o.a.h.tests.java.nio.channels.SourceChannelTest
> --------------------------------------------------------------------------------------------
>
>          Key: HARMONY-738
>          URL: http://issues.apache.org/jira/browse/HARMONY-738
>      Project: Harmony
>         Type: Test

>   Components: Classlib
>     Reporter: Andrew Zhang
>     Assignee: George Harley
>  Attachments: nio.diff
>
> Refine two unstable tests in o.a.h.tests.java.nio.channels.SourceChannelTest. 
> They are test_read_$LByteBuffer(), test_read_$LByteBufferII(). 
> Following code doesn't ensure all data are read in blocking mode:
> 	do {
> 	    long count = source.read(readBufArray, 0, 2);
> 	    if (count < 0) {
> 	         break;
> 	    }
> 	    totalCount += count;
> 	} while (totalCount != 10 && !isBlocking);
> Also, sink.close() should be invoked to ensure that all data are sent.
> I'll upload a patch soon.
> Thanks!
> Best regards,
> Andrew

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira