You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/10/31 11:59:15 UTC
[GitHub] [inlong] fuweng11 opened a new pull request, #6344: [INLONG-6343][Manager] Fix the problem that the cluster tag is empty when saving cluster information
fuweng11 opened a new pull request, #6344:
URL: https://github.com/apache/inlong/pull/6344
### Prepare a Pull Request
- Fixes #6343
### Motivation
Ensure that the key information is not empty when saving the cluster information
### Modifications
When saving cluster information, determine whether the cluster tag, type, name is empty
When saving cluster information, determine whether the cluster tag, type, name is empty
### Verifying this change
- [X] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #6344: [INLONG-6343][Manager] Fix the problem that the cluster tag is empty when saving cluster information
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #6344:
URL: https://github.com/apache/inlong/pull/6344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #6344: [INLONG-6343][Manager] Fix the problem that the cluster tag is empty when saving cluster information
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #6344:
URL: https://github.com/apache/inlong/pull/6344#discussion_r1009378088
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/heartbeat/HeartbeatManager.java:
##########
@@ -215,6 +216,9 @@ private ClusterInfo fetchCluster(ComponentHeartbeat componentHeartbeat) {
final String clusterName = componentHeartbeat.getClusterName();
final String type = componentHeartbeat.getComponentType();
final String clusterTag = componentHeartbeat.getClusterTag();
+ Preconditions.checkNotNull(clusterTag, "cluster tag cannot be null");
+ Preconditions.checkNotNull(type, "cluster type cannot be null");
+ Preconditions.checkNotNull(clusterTag, "cluster name cannot be null");
Review Comment:
`clasterName`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org