You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by "lppedd (via GitHub)" <gi...@apache.org> on 2023/03/11 10:50:24 UTC

[GitHub] [maven-scm-publish-plugin] lppedd commented on pull request #18: Support using an SSH private key as auth mechanism

lppedd commented on PR #18:
URL: https://github.com/apache/maven-scm-publish-plugin/pull/18#issuecomment-1464884121

   Hey there @bmarwell!
   I've noticed all the currently present integration tests revolve around SVN.
   
   Not sure how to mock a git server with SSH support. Probably JGit offers something useful.
   
   Found this by googling quickly.
   https://archive.eclipse.org/jgit/site/5.6.0.201912101111-r/apidocs/org/eclipse/jgit/transport/ssh/SshTestHarness.html
   
   My concern here is: we covered pretty much all the `server` element auth fields, and we're handling them through the platform, which is tested for us already. Should we really add a test case?
   
   Up to you. I can try out the JGit test harness in the meantime.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org