You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by mo...@apache.org on 2019/03/02 04:11:41 UTC
[incubator-weex] branch master updated: Update
WXRecyclerUpdateController.m
This is an automated email from the ASF dual-hosted git repository.
moshen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-weex.git
The following commit(s) were added to refs/heads/master by this push:
new 320979e Update WXRecyclerUpdateController.m
new ff7b42b Merge pull request #1190 from AntiMoron/master
320979e is described below
commit 320979ece56e10c76ff6b7239c0fb360f76437ff
Author: AntiMoron <an...@gmail.com>
AuthorDate: Tue May 22 12:13:19 2018 +0800
Update WXRecyclerUpdateController.m
Fix one crash.
```
*** -[__NSDictionaryM setObject:forKey:]: key cannot be nil
```
This exception will be yelled at line 167.
---
ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerUpdateController.m | 1 +
1 file changed, 1 insertion(+)
diff --git a/ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerUpdateController.m b/ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerUpdateController.m
index 7435c8d..5f92f29 100644
--- a/ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerUpdateController.m
+++ b/ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerUpdateController.m
@@ -146,6 +146,7 @@
[self.delegate updateController:self willPerformUpdateWithNewData:newData];
[UIView setAnimationsEnabled:NO];
WXLogDebug(@"UICollectionView update:%@", diffResult);
+ if(!diffResult.hasChanges) { return ; }
[self applyUpdate:diffResult toCollectionView:self.collectionView];
} copy];