You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/12 17:30:16 UTC
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request
#172: apps: Fix the nightly build warning
xiaoxiang781216 opened a new pull request #172: apps: Fix the nightly build warning
URL: https://github.com/apache/incubator-nuttx-apps/pull/172
src/cwindowfactory.cxx: In member function 'void Twm4Nx::CWindowFactory::redrawIcons(const nxgl_rect_s*)':
src/cwindowfactory.cxx:461:38: warning: 'iconPos.nxgl_point_s::y' may be used uninitialized in this function [-Wmaybe-uninitialized]
461 | iconBounds.pt2.y = iconPos.y + iconSize.h - 1;
| ~~~~~~~~^
src/cwindowfactory.cxx:460:38: warning: 'iconPos.nxgl_point_s::x' may be used uninitialized in this function [-Wmaybe-uninitialized]
460 | iconBounds.pt2.x = iconPos.x + iconSize.w - 1;
| ~~~~~~~~^
nsh_netcmds.c:424:20: warning: 'nsh_addrconv' defined but not used [-Wunused-function]
static inline bool nsh_addrconv(FAR const char *hwstr,
^
nsh_netcmds.c:446:20: warning: 'nsh_sethwaddr' defined but not used [-Wunused-function]
static inline void nsh_sethwaddr(FAR const char *ifname,
^
nsh_envcmds.c:94:21: warning: 'nsh_getdirpath' defined but not used [-Wunused-function]
static inline char *nsh_getdirpath(FAR struct nsh_vtbl_s *vtbl,
^
In file included from bas.c:84:0:
bas.c: In function 'bas_interpreter':
bas_error.h:110:37: warning: left-hand operand of comma expression has no effect [-Wunused-value]
#define NOSUCHLINE STATIC+40, _("No such line")
^
bas.c:2425:52: note: in expansion of macro 'NOSUCHLINE'
FS_putChars(STDCHANNEL, (NOSUCHLINE));
^~~~~~~~~~
bas_fs.c:107:22: warning: 'g_vt100_colormap' defined but not used [-Wunused-const-variable=]
static const uint8_t g_vt100_colormap[8] =
^~~~~~~~~~~~~~~~
<stdout>:4048:16: warning: 'input' defined but not used [-Wunused-function]
Signed-off-by: Xiang Xiao <xi...@xiaomi.com>
Change-Id: I62610b4c90e67637250cbd0107c2935c8abc542f
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on issue #172:
apps: Fix the nightly build warning
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #172: apps: Fix the nightly build warning
URL: https://github.com/apache/incubator-nuttx-apps/pull/172#issuecomment-612739498
@patacongo I fix all nxstyle warning except:
1.Warning for "Mixed case identifier"
2.Warning come from bas_token.c
since bas_token.c is generated from flex, it better to keep as before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] patacongo edited a comment on issue #172:
apps: Fix the nightly build warning
Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on issue #172: apps: Fix the nightly build warning
URL: https://github.com/apache/incubator-nuttx-apps/pull/172#issuecomment-612650968
@xiaoxiang781216 In bas.c, I assumed you wanted to ignore the Mixed case identifier errors in the PR check, but shouldb't the others be fixed (not so many).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] patacongo commented on issue #172: apps: Fix
the nightly build warning
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #172: apps: Fix the nightly build warning
URL: https://github.com/apache/incubator-nuttx-apps/pull/172#issuecomment-612650968
In bas.c, I assumed you wanted to ignore the Mixed case identifier check, but should the others be fixed (not so many).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on issue #172:
apps: Fix the nightly build warning
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #172: apps: Fix the nightly build warning
URL: https://github.com/apache/incubator-nuttx-apps/pull/172#issuecomment-612654784
> @xiaoxiang781216 In bas.c, I assumed you wanted to ignore the Mixed case identifier errors in the PR check, but shouldb't the others be fixed (not so many).
Yes, I will fix the remaining warning soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] patacongo merged pull request #172: apps:
Fix the nightly build warning
Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #172: apps: Fix the nightly build warning
URL: https://github.com/apache/incubator-nuttx-apps/pull/172
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services