You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/04/14 13:16:54 UTC
[GitHub] [hbase] thangTang opened a new pull request #1510: HBASE-24184
listSnapshots returns empty when just use simple acl but not use
authentication
thangTang opened a new pull request #1510: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication
URL: https://github.com/apache/hbase/pull/1510
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] thangTang removed a comment on issue #1510: HBASE-24184
listSnapshots returns empty when just use simple acl but not use
authentication
Posted by GitBox <gi...@apache.org>.
thangTang removed a comment on issue #1510: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication
URL: https://github.com/apache/hbase/pull/1510#issuecomment-613776774
The code in AccessController.preListSnapshot:
> if (SnapshotDescriptionUtils.isSnapshotOwner(snapshot, user)) {
// list it, if user is the owner of snapshot
AuthResult result = AuthResult.allow("listSnapshot " + snapshot.getName(),
"Snapshot owner check allowed", user, null, null, null);
accessChecker.logResult(result);
}
So i think the logic of setOwner is used for **authorization**, not **authentication**, SnapshotManager should not only setOwner when `hbase.security.authentication = kerberos`, which cause listSnapshots returns empty when i just use simple acls.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] thangTang commented on issue #1510: HBASE-24184
listSnapshots returns empty when just use simple acl but not use
authentication
Posted by GitBox <gi...@apache.org>.
thangTang commented on issue #1510: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication
URL: https://github.com/apache/hbase/pull/1510#issuecomment-614545281
@infraio hi, could you help me to review this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] thangTang commented on issue #1510: HBASE-24184
listSnapshots returns empty when just use simple acl but not use
authentication
Posted by GitBox <gi...@apache.org>.
thangTang commented on issue #1510: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication
URL: https://github.com/apache/hbase/pull/1510#issuecomment-613768194
@enis Hi, could you help me to review this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] thangTang commented on issue #1510: HBASE-24184
listSnapshots returns empty when just use simple acl but not use
authentication
Posted by GitBox <gi...@apache.org>.
thangTang commented on issue #1510: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication
URL: https://github.com/apache/hbase/pull/1510#issuecomment-613768352
The findbugs warning seems unrelated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] thangTang removed a comment on issue #1510: HBASE-24184
listSnapshots returns empty when just use simple acl but not use
authentication
Posted by GitBox <gi...@apache.org>.
thangTang removed a comment on issue #1510: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication
URL: https://github.com/apache/hbase/pull/1510#issuecomment-613768194
@enis Hi, could you help me to review this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] thangTang edited a comment on issue #1510: HBASE-24184
listSnapshots returns empty when just use simple acl but not use
authentication
Posted by GitBox <gi...@apache.org>.
thangTang edited a comment on issue #1510: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication
URL: https://github.com/apache/hbase/pull/1510#issuecomment-613776774
The code in AccessController.preListSnapshot:
> if (SnapshotDescriptionUtils.isSnapshotOwner(snapshot, user)) {
// list it, if user is the owner of snapshot
AuthResult result = AuthResult.allow("listSnapshot " + snapshot.getName(),
"Snapshot owner check allowed", user, null, null, null);
accessChecker.logResult(result);
}
So i think the logic of setOwner is used for **authorization**, not **authentication**, SnapshotManager should not only setOwner when `hbase.security.authentication = kerberos`, which cause listSnapshots returns empty when i just use simple acls.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1510: HBASE-24184
listSnapshots returns empty when just use simple acl but not use
authentication
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1510: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication
URL: https://github.com/apache/hbase/pull/1510#issuecomment-613459613
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 7m 6s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +1 :green_heart: | mvninstall | 8m 42s | branch-1 passed |
| +1 :green_heart: | compile | 0m 39s | branch-1 passed with JDK v1.8.0_242 |
| +1 :green_heart: | compile | 0m 45s | branch-1 passed with JDK v1.7.0_252 |
| +1 :green_heart: | checkstyle | 1m 37s | branch-1 passed |
| +1 :green_heart: | shadedjars | 2m 51s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 45s | branch-1 passed with JDK v1.8.0_242 |
| +1 :green_heart: | javadoc | 0m 41s | branch-1 passed with JDK v1.7.0_252 |
| +0 :ok: | spotbugs | 2m 49s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| -1 :x: | findbugs | 2m 46s | hbase-server in branch-1 has 1 extant findbugs warnings. |
||| _ Patch Compile Tests _ |
| -1 :x: | mvninstall | 1m 8s | root in the patch failed. |
| -1 :x: | compile | 0m 30s | hbase-server in the patch failed with JDK v1.8.0_242. |
| -1 :x: | javac | 0m 30s | hbase-server in the patch failed with JDK v1.8.0_242. |
| -1 :x: | compile | 0m 36s | hbase-server in the patch failed with JDK v1.7.0_252. |
| -1 :x: | javac | 0m 36s | hbase-server in the patch failed with JDK v1.7.0_252. |
| -1 :x: | checkstyle | 1m 29s | hbase-server: The patch generated 3 new + 21 unchanged - 0 fixed = 24 total (was 21) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | shadedjars | 1m 47s | patch has 14 errors when building our shaded downstream artifacts. |
| -1 :x: | hadoopcheck | 1m 4s | The patch causes 14 errors with Hadoop v2.8.5. |
| -1 :x: | hadoopcheck | 3m 4s | The patch causes 14 errors with Hadoop v2.9.2. |
| +1 :green_heart: | javadoc | 0m 29s | the patch passed with JDK v1.8.0_242 |
| +1 :green_heart: | javadoc | 0m 39s | the patch passed with JDK v1.7.0_252 |
| -1 :x: | findbugs | 0m 34s | hbase-server in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 39s | hbase-server in the patch failed. |
| +1 :green_heart: | asflicense | 0m 17s | The patch does not generate ASF License warnings. |
| | | 38m 35s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1510/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1510 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 8b31d40044b4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1510/out/precommit/personality/provided.sh |
| git revision | branch-1 / 7b12709 |
| Default Java | 1.7.0_252 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252 |
| findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1510/1/artifact/out/branch-findbugs-hbase-server-warnings.html |
| mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1510/1/artifact/out/patch-mvninstall-root.txt |
| compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1510/1/artifact/out/patch-compile-hbase-server-jdk1.8.0_242.txt |
| javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1510/1/artifact/out/patch-compile-hbase-server-jdk1.8.0_242.txt |
| compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1510/1/artifact/out/patch-compile-hbase-server-jdk1.7.0_252.txt |
| javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1510/1/artifact/out/patch-compile-hbase-server-jdk1.7.0_252.txt |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1510/1/artifact/out/diff-checkstyle-hbase-server.txt |
| shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1510/1/artifact/out/patch-shadedjars.txt |
| hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1510/1/artifact/out/patch-javac-2.8.5.txt |
| hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1510/1/artifact/out/patch-javac-2.9.2.txt |
| findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1510/1/artifact/out/patch-findbugs-hbase-server.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1510/1/artifact/out/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1510/1/testReport/ |
| Max. process+thread count | 87 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1510/1/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] thangTang commented on issue #1510: HBASE-24184
listSnapshots returns empty when just use simple acl but not use
authentication
Posted by GitBox <gi...@apache.org>.
thangTang commented on issue #1510: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication
URL: https://github.com/apache/hbase/pull/1510#issuecomment-613776774
The code in AccessController.preListSnapshot:
`if (SnapshotDescriptionUtils.isSnapshotOwner(snapshot, user)) {
// list it, if user is the owner of snapshot
AuthResult result = AuthResult.allow("listSnapshot " + snapshot.getName(),
"Snapshot owner check allowed", user, null, null, null);
accessChecker.logResult(result);
}`
So i think the logic of setOwner is used for **authorization**, not **authentication**, SnapshotManager should not only setOwner when `hbase.security.authentication = kerberos`, which cause listSnapshots returns empty when i just use simple acls.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] thangTang commented on issue #1510: HBASE-24184
listSnapshots returns empty when just use simple acl but not use
authentication
Posted by GitBox <gi...@apache.org>.
thangTang commented on issue #1510: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication
URL: https://github.com/apache/hbase/pull/1510#issuecomment-614543028
@saintstack hi, could you help me to review this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1510: HBASE-24184
listSnapshots returns empty when just use simple acl but not use
authentication
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1510: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication
URL: https://github.com/apache/hbase/pull/1510#issuecomment-613608546
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 44s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +1 :green_heart: | mvninstall | 8m 43s | branch-1 passed |
| +1 :green_heart: | compile | 0m 40s | branch-1 passed with JDK v1.8.0_242 |
| +1 :green_heart: | compile | 0m 45s | branch-1 passed with JDK v1.7.0_252 |
| +1 :green_heart: | checkstyle | 1m 39s | branch-1 passed |
| +1 :green_heart: | shadedjars | 3m 10s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 42s | branch-1 passed with JDK v1.8.0_242 |
| +1 :green_heart: | javadoc | 0m 40s | branch-1 passed with JDK v1.7.0_252 |
| +0 :ok: | spotbugs | 3m 13s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| -1 :x: | findbugs | 3m 8s | hbase-server in branch-1 has 1 extant findbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 53s | the patch passed |
| +1 :green_heart: | compile | 0m 40s | the patch passed with JDK v1.8.0_242 |
| +1 :green_heart: | javac | 0m 40s | the patch passed |
| +1 :green_heart: | compile | 0m 45s | the patch passed with JDK v1.7.0_252 |
| +1 :green_heart: | javac | 0m 45s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 32s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 2m 51s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 5m 1s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | javadoc | 0m 31s | the patch passed with JDK v1.8.0_242 |
| +1 :green_heart: | javadoc | 0m 41s | the patch passed with JDK v1.7.0_252 |
| +1 :green_heart: | findbugs | 2m 58s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 130m 26s | hbase-server in the patch passed. |
| +1 :green_heart: | asflicense | 0m 30s | The patch does not generate ASF License warnings. |
| | | 171m 44s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1510/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1510 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 049d69b6eb0d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1510/out/precommit/personality/provided.sh |
| git revision | branch-1 / 7b12709 |
| Default Java | 1.7.0_252 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252 |
| findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1510/2/artifact/out/branch-findbugs-hbase-server-warnings.html |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1510/2/testReport/ |
| Max. process+thread count | 4094 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1510/2/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services