You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/06 17:12:52 UTC
[GitHub] [airflow] potiuk opened a new pull request #7081: [AIRFLOW-6489]
Add BATS support for Bash unit testing
potiuk opened a new pull request #7081: [AIRFLOW-6489] Add BATS support for Bash unit testing
URL: https://github.com/apache/airflow/pull/7081
We have far too much bash code around that is not automatically tested.
This is the first step to change it (simplifications and more tests are coming
soon).
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #7081: [AIRFLOW-6489] Add BATS
support for Bash unit testing
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #7081: [AIRFLOW-6489] Add BATS support for Bash unit testing
URL: https://github.com/apache/airflow/pull/7081#issuecomment-571225892
Are you planning to write tests for some core code, or will it be only for testing the development environment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj edited a comment on issue #7081: [AIRFLOW-6489]
Add BATS support for Bash unit testing
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on issue #7081: [AIRFLOW-6489] Add BATS support for Bash unit testing
URL: https://github.com/apache/airflow/pull/7081#issuecomment-571225892
Are you planning to write tests for some core code, or will it be only for testing the development environment - Breeze?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7081: [AIRFLOW-6489] Add BATS
support for Bash unit testing
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7081: [AIRFLOW-6489] Add BATS support for Bash unit testing
URL: https://github.com/apache/airflow/pull/7081#issuecomment-571249744
All green. Would love to merge that in order to continue working on prod image changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #7081: [AIRFLOW-6489] Add BATS
support for Bash unit testing
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7081: [AIRFLOW-6489] Add BATS support for Bash unit testing
URL: https://github.com/apache/airflow/pull/7081
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7081: [AIRFLOW-6489] Add BATS
support for Bash unit testing
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7081: [AIRFLOW-6489] Add BATS support for Bash unit testing
URL: https://github.com/apache/airflow/pull/7081#issuecomment-571233803
I am planning to first introduce it for Breeze (that's where it is needed badly) but anyone (including myself) can add tests for all the other bash scripts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7081: [AIRFLOW-6489] Add BATS
support for Bash unit testing
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7081: [AIRFLOW-6489] Add BATS support for Bash unit testing
URL: https://github.com/apache/airflow/pull/7081#issuecomment-571234900
For sure I will need it for build/ci scripts simplification in order to add production image support finally. This really prerequisite as it becomes more and more complex to make change without bash unit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services