You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2015/08/14 01:23:25 UTC
Review Request 37449: Fixed scheduler tests to work with heartbeats.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37449/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar and Ben Mahler.
Bugs: MESOS-3260
https://issues.apache.org/jira/browse/MESOS-3260
Repository: mesos
Description
-------
As a short term fix stopped enqueuing heartbeat events in the queue.
Diffs
-----
src/tests/scheduler_tests.cpp 837d9e8471548dfe4ab3c9ec9822947f51848ab4
Diff: https://reviews.apache.org/r/37449/diff/
Testing
-------
make check
Ran the scheduler tests in a loop.
Thanks,
Vinod Kone
Re: Review Request 37449: Fixed scheduler tests to work with
heartbeats.
Posted by Marco Massenzio <ma...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37449/#review95348
-----------------------------------------------------------
Ship it!
src/tests/scheduler_tests.cpp (line 106)
<https://reviews.apache.org/r/37449/#comment150259>
nit: looks like a tab slipped in? (or may just be an RB artifact)
- Marco Massenzio
On Aug. 13, 2015, 11:23 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37449/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2015, 11:23 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Ben Mahler.
>
>
> Bugs: MESOS-3260
> https://issues.apache.org/jira/browse/MESOS-3260
>
>
> Repository: mesos
>
>
> Description
> -------
>
> As a short term fix stopped enqueuing heartbeat events in the queue.
>
>
> Diffs
> -----
>
> src/tests/scheduler_tests.cpp 837d9e8471548dfe4ab3c9ec9822947f51848ab4
>
> Diff: https://reviews.apache.org/r/37449/diff/
>
>
> Testing
> -------
>
> make check
>
> Ran the scheduler tests in a loop.
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 37449: Fixed scheduler tests to work with
heartbeats.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37449/#review95349
-----------------------------------------------------------
Ship it!
LGTM !
src/tests/scheduler_tests.cpp (line 103)
<https://reviews.apache.org/r/37449/#comment150260>
micro nit : let's just do Event::HEARTBEAT
- Anand Mazumdar
On Aug. 13, 2015, 11:23 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37449/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2015, 11:23 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Ben Mahler.
>
>
> Bugs: MESOS-3260
> https://issues.apache.org/jira/browse/MESOS-3260
>
>
> Repository: mesos
>
>
> Description
> -------
>
> As a short term fix stopped enqueuing heartbeat events in the queue.
>
>
> Diffs
> -----
>
> src/tests/scheduler_tests.cpp 837d9e8471548dfe4ab3c9ec9822947f51848ab4
>
> Diff: https://reviews.apache.org/r/37449/diff/
>
>
> Testing
> -------
>
> make check
>
> Ran the scheduler tests in a loop.
>
>
> Thanks,
>
> Vinod Kone
>
>