You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by ch...@apache.org on 2018/01/08 19:22:10 UTC
[4/9] flink git commit: [FLINK-8200][tests] Use TemporaryFolder in
RocksDBAsyncSnapshotTest
[FLINK-8200][tests] Use TemporaryFolder in RocksDBAsyncSnapshotTest
This closes #5122.
Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/4ac348d1
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/4ac348d1
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/4ac348d1
Branch: refs/heads/master
Commit: 4ac348d1fa539d64ce9317035716243c74d70818
Parents: 10aae99
Author: wenlong.lwl <we...@alibaba-inc.com>
Authored: Tue Dec 5 15:16:32 2017 +0800
Committer: zentol <ch...@apache.org>
Committed: Mon Jan 8 18:47:07 2018 +0100
----------------------------------------------------------------------
.../streaming/state/RocksDBAsyncSnapshotTest.java | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flink/blob/4ac348d1/flink-contrib/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBAsyncSnapshotTest.java
----------------------------------------------------------------------
diff --git a/flink-contrib/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBAsyncSnapshotTest.java b/flink-contrib/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBAsyncSnapshotTest.java
index 2ba0494..71c5e77 100644
--- a/flink-contrib/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBAsyncSnapshotTest.java
+++ b/flink-contrib/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBAsyncSnapshotTest.java
@@ -25,7 +25,6 @@ import org.apache.flink.api.common.typeinfo.BasicTypeInfo;
import org.apache.flink.api.common.typeutils.base.StringSerializer;
import org.apache.flink.api.common.typeutils.base.VoidSerializer;
import org.apache.flink.api.java.functions.KeySelector;
-import org.apache.flink.configuration.ConfigConstants;
import org.apache.flink.core.testutils.OneShotLatch;
import org.apache.flink.runtime.checkpoint.CheckpointMetaData;
import org.apache.flink.runtime.checkpoint.CheckpointMetrics;
@@ -60,7 +59,9 @@ import org.apache.flink.util.IOUtils;
import org.apache.flink.util.TestLogger;
import org.junit.Assert;
+import org.junit.Rule;
import org.junit.Test;
+import org.junit.rules.TemporaryFolder;
import org.junit.runner.RunWith;
import org.powermock.core.classloader.annotations.PowerMockIgnore;
import org.powermock.modules.junit4.PowerMockRunner;
@@ -70,7 +71,6 @@ import java.io.IOException;
import java.lang.reflect.Field;
import java.util.Arrays;
import java.util.Map;
-import java.util.UUID;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.RunnableFuture;
@@ -96,6 +96,12 @@ import static org.mockito.Mockito.verify;
public class RocksDBAsyncSnapshotTest extends TestLogger {
/**
+ * Temporary fold for test.
+ */
+ @Rule
+ public TemporaryFolder temporaryFolder = new TemporaryFolder();
+
+ /**
* This ensures that asynchronous state handles are actually materialized asynchronously.
*
* <p>We use latches to block at various stages and see if the code still continues through
@@ -119,7 +125,7 @@ public class RocksDBAsyncSnapshotTest extends TestLogger {
StreamConfig streamConfig = testHarness.getStreamConfig();
- File dbDir = new File(new File(ConfigConstants.DEFAULT_TASK_MANAGER_TMP_PATH, UUID.randomUUID().toString()), "state");
+ File dbDir = temporaryFolder.newFolder();
RocksDBStateBackend backend = new RocksDBStateBackend(new MemoryStateBackend());
backend.setDbStoragePath(dbDir.getAbsolutePath());
@@ -225,7 +231,7 @@ public class RocksDBAsyncSnapshotTest extends TestLogger {
StreamConfig streamConfig = testHarness.getStreamConfig();
- File dbDir = new File(new File(ConfigConstants.DEFAULT_TASK_MANAGER_TMP_PATH, UUID.randomUUID().toString()), "state");
+ File dbDir = temporaryFolder.newFolder();
BlockingStreamMemoryStateBackend memoryStateBackend = new BlockingStreamMemoryStateBackend();
@@ -333,7 +339,7 @@ public class RocksDBAsyncSnapshotTest extends TestLogger {
RocksDBStateBackend backend = new RocksDBStateBackend(stateBackend);
- backend.setDbStoragePath("file:///tmp/foobar");
+ backend.setDbStoragePath(temporaryFolder.newFolder().toURI().toString());
AbstractKeyedStateBackend<Void> keyedStateBackend = backend.createKeyedStateBackend(
env,