You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "rtrivedi12 (via GitHub)" <gi...@apache.org> on 2026/07/29 19:25:38 UTC
[PR] HIVE-29423: Move delete_column_statistics_req out from HMSHandler [hive]
rtrivedi12 opened a new pull request, #6661:
URL: https://github.com/apache/hive/pull/6661
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Extract `delete_column_statistics_req` logic from `HMSHandler` into a new `DeleteColumnStatisticsHandler`, following the existing `@RequestHandler` / `AbstractRequestHandler`
- Add `DeleteColumnStatisticsHandler` for table- and partition-level column statistics deletion, including transactional listener events and post-commit notification.
- `HMSHandler.delete_column_statistics_req()` used to audit logging (`startFunction` / `endFunction`) and delegation via `AbstractRequestHandler.offer(this, req)`.
### Why are the changes needed?
`HMSHandler` is being decomposed into focused request handlers ([HIVE-27224](https://issues.apache.org/jira/browse/HIVE-27224)).
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
mvn test -pl standalone-metastore/metastore-server -am \
-Dtest=TestStats,TestStatisticsManagement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29423: Move delete_column_statistics_req out from HMSHandler [hive]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #6661:
URL: https://github.com/apache/hive/pull/6661#issuecomment-5123247743
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6661) **Quality Gate passed**
Issues
 [8 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6661&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6661&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=6661&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6661&metric=new_coverage&view=list)
 [1.4% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6661&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6661)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29423: Move delete_column_statistics_req out from HMSHandler [hive]
Posted by "rtrivedi12 (via GitHub)" <gi...@apache.org>.
rtrivedi12 commented on code in PR #6661:
URL: https://github.com/apache/hive/pull/6661#discussion_r3693742693
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -2552,73 +2552,19 @@ public boolean delete_column_statistics_req(DeleteColumnStatisticsRequest req) t
startFunction("delete_column_statistics_req", ": table=" +
TableName.getQualified(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], tableName) +
" partitions=" + req.getPart_names() + " column=" + colNames + " engine=" + engine);
- boolean ret = false, committed = false;
- List<ListenerEvent> events = new ArrayList<>();
- EventType eventType = null;
- final RawStore rawStore = getMS();
- rawStore.openTransaction();
- try {
- Table table = rawStore.getTable(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], tableName);
- boolean isPartitioned = table.getPartitionKeysSize() > 0;
- if (TxnUtils.isTransactionalTable(table)) {
- throw new MetaException("Cannot delete stats via this API for a transactional table");
- }
- if (!isPartitioned || req.isTableLevel()) {
- ret = rawStore.deleteTableColumnStatistics(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], tableName, colNames, engine);
- if (ret) {
- eventType = EventType.DELETE_TABLE_COLUMN_STAT;
- for (String colName : colNames == null || colNames.isEmpty() ?
- table.getSd().getCols().stream().map(FieldSchema::getName).toList() : colNames) {
- if (transactionalListeners != null && !transactionalListeners.isEmpty()) {
- MetaStoreListenerNotifier.notifyEvent(transactionalListeners, eventType,
- new DeleteTableColumnStatEvent(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], tableName, colName, engine, this));
- }
- events.add(new DeleteTableColumnStatEvent(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], tableName, colName, engine, this));
- }
- }
- } else {
- List<String> partNames = new ArrayList<>();
- if (req.getPart_namesSize() > 0) {
- partNames.addAll(req.getPart_names());
- } else {
- partNames.addAll(rawStore.listPartitionNames(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], tableName, (short) -1));
- }
- if (partNames.isEmpty()) {
- // no partition found, bail out early
- return true;
- }
- ret = rawStore.deletePartitionColumnStatistics(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], tableName,
- partNames, colNames, engine);
- if (ret) {
- eventType = EventType.DELETE_PARTITION_COLUMN_STAT;
- for (String colName : colNames == null || colNames.isEmpty() ?
- table.getSd().getCols().stream().map(FieldSchema::getName).toList() : colNames) {
- for (String partName : partNames) {
- List<String> partVals = getPartValsFromName(table, partName);
- if (transactionalListeners != null && !transactionalListeners.isEmpty()) {
- MetaStoreListenerNotifier.notifyEvent(transactionalListeners, eventType,
- new DeletePartitionColumnStatEvent(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], tableName,
- partName, partVals, colName, engine, this));
- }
- events.add(new DeletePartitionColumnStatEvent(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], tableName,
- partName, partVals, colName, engine, this));
- }
- }
- }
- }
- committed = rawStore.commitTransaction();
+ Exception ex = null;
+ boolean ret = false;
+ try {
+ ret = AbstractRequestHandler.offer(this, req).success();
+ return ret;
+ } catch (Exception e) {
+ ex = e;
+ throw handleException(e).throwIfInstance(MetaException.class, NoSuchObjectException.class)
Review Comment:
Thanks for the review @dengzhhu653 ! Updated the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29423: Move delete_column_statistics_req out from HMSHandler [hive]
Posted by "dengzhhu653 (via GitHub)" <gi...@apache.org>.
dengzhhu653 merged PR #6661:
URL: https://github.com/apache/hive/pull/6661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29423: Move delete_column_statistics_req out from HMSHandler [hive]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #6661:
URL: https://github.com/apache/hive/pull/6661#issuecomment-5173788706
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6661) **Quality Gate passed**
Issues
 [5 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6661&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6661&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=6661&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6661&metric=new_coverage&view=list)
 [1.4% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6661&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6661)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29423: Move delete_column_statistics_req out from HMSHandler [hive]
Posted by "dengzhhu653 (via GitHub)" <gi...@apache.org>.
dengzhhu653 commented on code in PR #6661:
URL: https://github.com/apache/hive/pull/6661#discussion_r3681041577
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -2552,73 +2552,19 @@ public boolean delete_column_statistics_req(DeleteColumnStatisticsRequest req) t
startFunction("delete_column_statistics_req", ": table=" +
TableName.getQualified(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], tableName) +
" partitions=" + req.getPart_names() + " column=" + colNames + " engine=" + engine);
- boolean ret = false, committed = false;
- List<ListenerEvent> events = new ArrayList<>();
- EventType eventType = null;
- final RawStore rawStore = getMS();
- rawStore.openTransaction();
- try {
- Table table = rawStore.getTable(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], tableName);
- boolean isPartitioned = table.getPartitionKeysSize() > 0;
- if (TxnUtils.isTransactionalTable(table)) {
- throw new MetaException("Cannot delete stats via this API for a transactional table");
- }
- if (!isPartitioned || req.isTableLevel()) {
- ret = rawStore.deleteTableColumnStatistics(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], tableName, colNames, engine);
- if (ret) {
- eventType = EventType.DELETE_TABLE_COLUMN_STAT;
- for (String colName : colNames == null || colNames.isEmpty() ?
- table.getSd().getCols().stream().map(FieldSchema::getName).toList() : colNames) {
- if (transactionalListeners != null && !transactionalListeners.isEmpty()) {
- MetaStoreListenerNotifier.notifyEvent(transactionalListeners, eventType,
- new DeleteTableColumnStatEvent(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], tableName, colName, engine, this));
- }
- events.add(new DeleteTableColumnStatEvent(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], tableName, colName, engine, this));
- }
- }
- } else {
- List<String> partNames = new ArrayList<>();
- if (req.getPart_namesSize() > 0) {
- partNames.addAll(req.getPart_names());
- } else {
- partNames.addAll(rawStore.listPartitionNames(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], tableName, (short) -1));
- }
- if (partNames.isEmpty()) {
- // no partition found, bail out early
- return true;
- }
- ret = rawStore.deletePartitionColumnStatistics(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], tableName,
- partNames, colNames, engine);
- if (ret) {
- eventType = EventType.DELETE_PARTITION_COLUMN_STAT;
- for (String colName : colNames == null || colNames.isEmpty() ?
- table.getSd().getCols().stream().map(FieldSchema::getName).toList() : colNames) {
- for (String partName : partNames) {
- List<String> partVals = getPartValsFromName(table, partName);
- if (transactionalListeners != null && !transactionalListeners.isEmpty()) {
- MetaStoreListenerNotifier.notifyEvent(transactionalListeners, eventType,
- new DeletePartitionColumnStatEvent(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], tableName,
- partName, partVals, colName, engine, this));
- }
- events.add(new DeletePartitionColumnStatEvent(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], tableName,
- partName, partVals, colName, engine, this));
- }
- }
- }
- }
- committed = rawStore.commitTransaction();
+ Exception ex = null;
+ boolean ret = false;
+ try {
+ ret = AbstractRequestHandler.offer(this, req).success();
+ return ret;
+ } catch (Exception e) {
+ ex = e;
+ throw handleException(e).throwIfInstance(MetaException.class, NoSuchObjectException.class)
Review Comment:
nit: can we just transform the exception to TException? `throw handleException(e).defaultTException()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29423: Move delete_column_statistics_req out from HMSHandler [hive]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #6661:
URL: https://github.com/apache/hive/pull/6661#discussion_r3680993288
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/handler/DeleteColumnStatisticsHandler.java:
##########
@@ -0,0 +1,168 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.metastore.handler;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.stream.Collectors;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hive.common.TableName;
+import org.apache.hadoop.hive.metastore.IHMSHandler;
+import org.apache.hadoop.hive.metastore.MetaStoreListenerNotifier;
+import org.apache.hadoop.hive.metastore.RawStore;
+import org.apache.hadoop.hive.metastore.api.DeleteColumnStatisticsRequest;
+import org.apache.hadoop.hive.metastore.api.FieldSchema;
+import org.apache.hadoop.hive.metastore.api.MetaException;
+import org.apache.hadoop.hive.metastore.api.Table;
+import org.apache.hadoop.hive.metastore.events.DeletePartitionColumnStatEvent;
+import org.apache.hadoop.hive.metastore.events.DeleteTableColumnStatEvent;
+import org.apache.hadoop.hive.metastore.events.ListenerEvent;
+import org.apache.hadoop.hive.metastore.messaging.EventMessage.EventType;
+import org.apache.hadoop.hive.metastore.txn.TxnUtils;
+import org.apache.thrift.TException;
+
+import static org.apache.hadoop.hive.metastore.utils.MetaStoreServerUtils.getPartValsFromName;
+import static org.apache.hadoop.hive.metastore.utils.MetaStoreUtils.CAT_NAME;
+import static org.apache.hadoop.hive.metastore.utils.MetaStoreUtils.DB_NAME;
+import static org.apache.hadoop.hive.metastore.utils.MetaStoreUtils.parseDbName;
+import static org.apache.hadoop.hive.metastore.utils.StringUtils.normalizeIdentifier;
+
+@SuppressWarnings("unused")
+@RequestHandler(requestBody = DeleteColumnStatisticsRequest.class)
+public class DeleteColumnStatisticsHandler
+ extends AbstractRequestHandler<DeleteColumnStatisticsRequest,
+ DeleteColumnStatisticsHandler.DeleteColumnStatisticsResult> {
+ private RawStore ms;
+ private Configuration conf;
+ private String catName;
+ private String dbName;
+ private String tableName;
+ private List<String> colNames;
+ private String engine;
+ private List<ListenerEvent> events;
+ private EventType eventType;
+
+ DeleteColumnStatisticsHandler(IHMSHandler handler, DeleteColumnStatisticsRequest request) {
+ super(handler, false, request);
+ }
+
+ @Override
+ protected void beforeExecute() throws TException, IOException {
+ this.conf = handler.getConf();
+ this.ms = handler.getMS();
+ this.colNames = request.getCol_names();
+ this.engine = request.getEngine();
+ String normalizedDbName = normalizeIdentifier(request.getDb_name());
+ this.tableName = normalizeIdentifier(request.getTbl_name());
+ String[] parsedDbName = parseDbName(normalizedDbName, conf);
+ if (request.getCat_name() != null) {
+ parsedDbName[CAT_NAME] = normalizeIdentifier(request.getCat_name());
+ }
+ this.catName = parsedDbName[CAT_NAME];
+ this.dbName = parsedDbName[DB_NAME];
+ this.events = new ArrayList<>();
+ }
+
+ @Override
+ protected DeleteColumnStatisticsResult execute() throws TException, IOException {
+ boolean ret = false;
+ boolean committed = false;
+ ms.openTransaction();
+ try {
+ Table table = ms.getTable(catName, dbName, tableName);
+ boolean isPartitioned = table.getPartitionKeysSize() > 0;
+ if (TxnUtils.isTransactionalTable(table)) {
+ throw new MetaException("Cannot delete stats via this API for a transactional table");
+ }
+ if (!isPartitioned || request.isTableLevel()) {
+ ret = ms.deleteTableColumnStatistics(catName, dbName, tableName, colNames, engine);
+ if (ret) {
+ eventType = EventType.DELETE_TABLE_COLUMN_STAT;
+ for (String colName : colNames == null || colNames.isEmpty() ?
+ table.getSd().getCols().stream().map(FieldSchema::getName).collect(Collectors.toList())
+ : colNames) {
+ if (!handler.getTransactionalListeners().isEmpty()) {
+ MetaStoreListenerNotifier.notifyEvent(handler.getTransactionalListeners(), eventType,
+ new DeleteTableColumnStatEvent(catName, dbName, tableName, colName, engine, handler));
+ }
+ events.add(new DeleteTableColumnStatEvent(catName, dbName, tableName, colName, engine, handler));
+ }
+ }
+ } else {
+ List<String> partNames = new ArrayList<>();
+ if (request.getPart_namesSize() > 0) {
+ partNames.addAll(request.getPart_names());
+ } else {
+ partNames.addAll(ms.listPartitionNames(catName, dbName, tableName, (short) -1));
+ }
+ if (partNames.isEmpty()) {
+ // no partition found, bail out early
+ return new DeleteColumnStatisticsResult(true, events, eventType);
+ }
+ ret = ms.deletePartitionColumnStatistics(catName, dbName, tableName, partNames, colNames, engine);
+ if (ret) {
+ eventType = EventType.DELETE_PARTITION_COLUMN_STAT;
+ for (String colName : colNames == null || colNames.isEmpty() ?
+ table.getSd().getCols().stream().map(FieldSchema::getName).collect(Collectors.toList())
+ : colNames) {
+ for (String partName : partNames) {
+ List<String> partVals = getPartValsFromName(table, partName);
+ if (!handler.getTransactionalListeners().isEmpty()) {
+ MetaStoreListenerNotifier.notifyEvent(handler.getTransactionalListeners(), eventType,
+ new DeletePartitionColumnStatEvent(catName, dbName, tableName,
+ partName, partVals, colName, engine, handler));
+ }
+ events.add(new DeletePartitionColumnStatEvent(catName, dbName, tableName,
+ partName, partVals, colName, engine, handler));
+ }
+ }
+ }
+ }
+ committed = ms.commitTransaction();
+ } finally {
+ if (!committed) {
+ ms.rollbackTransaction();
+ }
+ }
+ return new DeleteColumnStatisticsResult(ret, events, eventType);
+ }
+
+ @Override
+ protected void afterExecute(DeleteColumnStatisticsResult result) throws TException, IOException {
+ if (result != null && !handler.getListeners().isEmpty()) {
+ for (ListenerEvent event : result.events()) {
+ MetaStoreListenerNotifier.notifyEvent(handler.getTransactionalListeners(), result.eventType(), event);
+ }
+ }
+ super.afterExecute(result);
+ }
Review Comment:
Post-commit listener notification is using the transactional listener list. Transactional listeners were already notified during execution; this should notify the regular listeners (handler.getListeners()) after commit. As written, non-transactional listeners will never receive DELETE_*_COLUMN_STAT events, and transactional listeners may receive duplicate notifications.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29423: Move delete_column_statistics_req out from HMSHandler [hive]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #6661:
URL: https://github.com/apache/hive/pull/6661#issuecomment-5181483460
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6661) **Quality Gate passed**
Issues
 [5 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6661&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6661&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=6661&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6661&metric=new_coverage&view=list)
 [1.4% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6661&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6661)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29423: Move delete_column_statistics_req out from HMSHandler [hive]
Posted by "rtrivedi12 (via GitHub)" <gi...@apache.org>.
rtrivedi12 commented on PR #6661:
URL: https://github.com/apache/hive/pull/6661#issuecomment-5184215883
Thanks @dengzhhu653 for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29423: Move delete_column_statistics_req out from HMSHandler [hive]
Posted by "dengzhhu653 (via GitHub)" <gi...@apache.org>.
dengzhhu653 commented on code in PR #6661:
URL: https://github.com/apache/hive/pull/6661#discussion_r3681047264
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/handler/DeleteColumnStatisticsHandler.java:
##########
@@ -0,0 +1,168 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.metastore.handler;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.stream.Collectors;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hive.common.TableName;
+import org.apache.hadoop.hive.metastore.IHMSHandler;
+import org.apache.hadoop.hive.metastore.MetaStoreListenerNotifier;
+import org.apache.hadoop.hive.metastore.RawStore;
+import org.apache.hadoop.hive.metastore.api.DeleteColumnStatisticsRequest;
+import org.apache.hadoop.hive.metastore.api.FieldSchema;
+import org.apache.hadoop.hive.metastore.api.MetaException;
+import org.apache.hadoop.hive.metastore.api.Table;
+import org.apache.hadoop.hive.metastore.events.DeletePartitionColumnStatEvent;
+import org.apache.hadoop.hive.metastore.events.DeleteTableColumnStatEvent;
+import org.apache.hadoop.hive.metastore.events.ListenerEvent;
+import org.apache.hadoop.hive.metastore.messaging.EventMessage.EventType;
+import org.apache.hadoop.hive.metastore.txn.TxnUtils;
+import org.apache.thrift.TException;
+
+import static org.apache.hadoop.hive.metastore.utils.MetaStoreServerUtils.getPartValsFromName;
+import static org.apache.hadoop.hive.metastore.utils.MetaStoreUtils.CAT_NAME;
+import static org.apache.hadoop.hive.metastore.utils.MetaStoreUtils.DB_NAME;
+import static org.apache.hadoop.hive.metastore.utils.MetaStoreUtils.parseDbName;
+import static org.apache.hadoop.hive.metastore.utils.StringUtils.normalizeIdentifier;
+
+@SuppressWarnings("unused")
+@RequestHandler(requestBody = DeleteColumnStatisticsRequest.class)
+public class DeleteColumnStatisticsHandler
+ extends AbstractRequestHandler<DeleteColumnStatisticsRequest,
+ DeleteColumnStatisticsHandler.DeleteColumnStatisticsResult> {
+ private RawStore ms;
+ private Configuration conf;
+ private String catName;
+ private String dbName;
+ private String tableName;
+ private List<String> colNames;
+ private String engine;
+ private List<ListenerEvent> events;
+ private EventType eventType;
+
+ DeleteColumnStatisticsHandler(IHMSHandler handler, DeleteColumnStatisticsRequest request) {
+ super(handler, false, request);
+ }
+
+ @Override
+ protected void beforeExecute() throws TException, IOException {
+ this.conf = handler.getConf();
+ this.ms = handler.getMS();
+ this.colNames = request.getCol_names();
+ this.engine = request.getEngine();
+ String normalizedDbName = normalizeIdentifier(request.getDb_name());
+ this.tableName = normalizeIdentifier(request.getTbl_name());
+ String[] parsedDbName = parseDbName(normalizedDbName, conf);
+ if (request.getCat_name() != null) {
+ parsedDbName[CAT_NAME] = normalizeIdentifier(request.getCat_name());
+ }
+ this.catName = parsedDbName[CAT_NAME];
+ this.dbName = parsedDbName[DB_NAME];
+ this.events = new ArrayList<>();
+ }
+
+ @Override
+ protected DeleteColumnStatisticsResult execute() throws TException, IOException {
+ boolean ret = false;
+ boolean committed = false;
+ ms.openTransaction();
+ try {
+ Table table = ms.getTable(catName, dbName, tableName);
+ boolean isPartitioned = table.getPartitionKeysSize() > 0;
+ if (TxnUtils.isTransactionalTable(table)) {
+ throw new MetaException("Cannot delete stats via this API for a transactional table");
+ }
+ if (!isPartitioned || request.isTableLevel()) {
+ ret = ms.deleteTableColumnStatistics(catName, dbName, tableName, colNames, engine);
+ if (ret) {
+ eventType = EventType.DELETE_TABLE_COLUMN_STAT;
+ for (String colName : colNames == null || colNames.isEmpty() ?
+ table.getSd().getCols().stream().map(FieldSchema::getName).collect(Collectors.toList())
+ : colNames) {
+ if (!handler.getTransactionalListeners().isEmpty()) {
+ MetaStoreListenerNotifier.notifyEvent(handler.getTransactionalListeners(), eventType,
+ new DeleteTableColumnStatEvent(catName, dbName, tableName, colName, engine, handler));
+ }
+ events.add(new DeleteTableColumnStatEvent(catName, dbName, tableName, colName, engine, handler));
+ }
+ }
+ } else {
+ List<String> partNames = new ArrayList<>();
+ if (request.getPart_namesSize() > 0) {
+ partNames.addAll(request.getPart_names());
+ } else {
+ partNames.addAll(ms.listPartitionNames(catName, dbName, tableName, (short) -1));
+ }
+ if (partNames.isEmpty()) {
+ // no partition found, bail out early
+ return new DeleteColumnStatisticsResult(true, events, eventType);
+ }
+ ret = ms.deletePartitionColumnStatistics(catName, dbName, tableName, partNames, colNames, engine);
+ if (ret) {
+ eventType = EventType.DELETE_PARTITION_COLUMN_STAT;
+ for (String colName : colNames == null || colNames.isEmpty() ?
+ table.getSd().getCols().stream().map(FieldSchema::getName).collect(Collectors.toList())
+ : colNames) {
+ for (String partName : partNames) {
+ List<String> partVals = getPartValsFromName(table, partName);
+ if (!handler.getTransactionalListeners().isEmpty()) {
+ MetaStoreListenerNotifier.notifyEvent(handler.getTransactionalListeners(), eventType,
+ new DeletePartitionColumnStatEvent(catName, dbName, tableName,
+ partName, partVals, colName, engine, handler));
+ }
+ events.add(new DeletePartitionColumnStatEvent(catName, dbName, tableName,
+ partName, partVals, colName, engine, handler));
+ }
+ }
+ }
+ }
+ committed = ms.commitTransaction();
+ } finally {
+ if (!committed) {
+ ms.rollbackTransaction();
+ }
+ }
+ return new DeleteColumnStatisticsResult(ret, events, eventType);
+ }
+
+ @Override
+ protected void afterExecute(DeleteColumnStatisticsResult result) throws TException, IOException {
+ if (result != null && !handler.getListeners().isEmpty()) {
+ for (ListenerEvent event : result.events()) {
+ MetaStoreListenerNotifier.notifyEvent(handler.getTransactionalListeners(), result.eventType(), event);
+ }
+ }
+ super.afterExecute(result);
+ }
Review Comment:
Please take care of this typo fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29423: Move delete_column_statistics_req out from HMSHandler [hive]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #6661:
URL: https://github.com/apache/hive/pull/6661#issuecomment-5175047843
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6661) **Quality Gate passed**
Issues
 [5 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6661&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6661&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=6661&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6661&metric=new_coverage&view=list)
 [1.4% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6661&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6661)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29423: Move delete_column_statistics_req out from HMSHandler [hive]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #6661:
URL: https://github.com/apache/hive/pull/6661#issuecomment-5163826802
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6661) **Quality Gate passed**
Issues
 [6 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6661&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6661&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=6661&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6661&metric=new_coverage&view=list)
 [0.8% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6661&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6661)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org