You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/08/10 08:16:51 UTC
[GitHub] [incubator-mxnet] cs8105 opened a new issue #18886: bug of NDarray.reshape
cs8105 opened a new issue #18886:
URL: https://github.com/apache/incubator-mxnet/issues/18886
`
In [26]: import mxnet as mx
In [27]: mx.__version__
Out[27]: '1.6.0'
In [28]: nd = mx.nd
In [29]: a = nd.arange(27).reshape((3,3,3))
In [30]: a.reshape((3,3))
Out[30]:
[[0. 1. 2.]
[3. 4. 5.]
[6. 7. 8.]]
<NDArray 3x3 @cpu(0)>
`
the the old shape (3,3,3) and new shape (3,3) is not in the same size.
is there some special purpose for this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha closed issue #18886: bug of NDarray.reshape
Posted by GitBox <gi...@apache.org>.
szha closed issue #18886:
URL: https://github.com/apache/incubator-mxnet/issues/18886
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@mxnet.apache.org
For additional commands, e-mail: issues-help@mxnet.apache.org
[GitHub] [incubator-mxnet] r3stl355 commented on issue #18886: bug of NDarray.reshape
Posted by GitBox <gi...@apache.org>.
r3stl355 commented on issue #18886:
URL: https://github.com/apache/incubator-mxnet/issues/18886#issuecomment-777011387
This was fixed by https://github.com/apache/incubator-mxnet/pull/19095 few months ago and merged into v1.x branch but was not picked for 1.8 release. Should be closed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@mxnet.apache.org
For additional commands, e-mail: issues-help@mxnet.apache.org
[GitHub] [incubator-mxnet] leezu commented on issue #18886: bug of NDarray.reshape
Posted by GitBox <gi...@apache.org>.
leezu commented on issue #18886:
URL: https://github.com/apache/incubator-mxnet/issues/18886#issuecomment-685875130
@r3stl355 you can open the PR against the master branch and v1.x branch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@mxnet.apache.org
For additional commands, e-mail: issues-help@mxnet.apache.org
[GitHub] [incubator-mxnet] szha commented on issue #18886: bug of NDarray.reshape
Posted by GitBox <gi...@apache.org>.
szha commented on issue #18886:
URL: https://github.com/apache/incubator-mxnet/issues/18886#issuecomment-671536474
@cs8105 congrats that you have found mxnet's built-in way of creating memory leaks🤦♂️
Joke aside, I think what we need here is a check for consistent size. the logic for ndarray can be found here:
https://github.com/apache/incubator-mxnet/blob/cc287a0fc2de030c5cbb826092cd1863c72931aa/python/mxnet/ndarray/ndarray.py#L1501-L1520
Would you like to open a PR to add a check that makes sure the size is consistent before and after the reshape, and raise ValueError otherwise? The process is described at https://cwiki.apache.org/confluence/display/MXNET/Git+Setup+and+Workflow
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on issue #18886: bug of NDarray.reshape
Posted by GitBox <gi...@apache.org>.
leezu commented on issue #18886:
URL: https://github.com/apache/incubator-mxnet/issues/18886#issuecomment-671518247
I verified that this doesn't affect the `np` interface: `mx.np.arange(27).reshape((3,3))` works as expected on master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] r3stl355 commented on issue #18886: bug of NDarray.reshape
Posted by GitBox <gi...@apache.org>.
r3stl355 commented on issue #18886:
URL: https://github.com/apache/incubator-mxnet/issues/18886#issuecomment-685868924
I'm new so forgive my ignorance. The same bug seems to be present v2.0, shall I just give PR a go on the v2 branch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@mxnet.apache.org
For additional commands, e-mail: issues-help@mxnet.apache.org