[GitHub] [hive] dengzhhu653 commented on a change in pull request #980: HIVE-22458: Add more constraints on showing partitions

[GitBox <gi...@apache.org>]

dengzhhu653 commented on a change in pull request #980: HIVE-22458: Add more constraints on showing partitions
URL: https://github.com/apache/hive/pull/980#discussion_r407144654
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/show/ShowPartitionAnalyzer.java
 ##########
 @@ -57,10 +67,75 @@ public void analyzeInternal(ASTNode ast) throws SemanticException {
     inputs.add(new ReadEntity(table));
 
     ShowPartitionsDesc desc = new ShowPartitionsDesc(tableName, ctx.getResFile(), partSpec);
+    analyzeShowPartitionsConstraints(ast, table, desc);
     Task<DDLWork> task = TaskFactory.get(new DDLWork(getInputs(), getOutputs(), desc));
     rootTasks.add(task);
 
     task.setFetchSource(true);
     setFetchTask(createFetchTask(ShowPartitionsDesc.SCHEMA));
   }
+
+  private void analyzeShowPartitionsConstraints(ASTNode ast, Table tab,
 
 Review comment:
   @miklosgergely Thanks for reviewing. Update codes to move the parser into 3 different methods and make the variable in ShowPartitionDesc all final.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org