You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm-dev@maven.apache.org by "Dennis Lundberg (JIRA)" <ji...@codehaus.org> on 2005/12/10 19:39:46 UTC
[jira] Created: (SCM-106) Validation of scm url fails because of
ambiquities between source code and site documentation
Validation of scm url fails because of ambiquities between source code and site documentation
---------------------------------------------------------------------------------------------
Key: SCM-106
URL: http://jira.codehaus.org/browse/SCM-106
Project: Maven SCM
Type: Bug
Components: maven-scm-api
Reporter: Dennis Lundberg
I am trying out Continuum and am tracking down the cause of why I get an error regarding the scm url that I provide when adding an ant project. This has led me here. I copied the scm url from my maven 1 project.xml and got a very breif error message telling me to enter a valid scm url.
My scm url looks like this:
scm|cvs|pserver|user@localhost|C:/Program/cvsnt/repositories|project-name
This works just fine using maven 1.
These two files are involved in this:
maven-scm-api/src/main/java/org/apache/maven/scm/manager/AbstractScmManager.java
maven-scm-site/src/site/apt/cvs.apt
AbstractScmManager.java has the following error message declared:
private final static String ILLEGAL_SCM_URL = "The scm url must be on the form "
+ "'scm:<scm provider><delimiter><provider specific part>' "
+ "where <delimiter> can be either ':' or '|'.";
which explains how a correct scm url should look.
cvs.apt on the other hand does not have this explanation. It does say:
For all URLs below, we use a colon (:) as separator. If you use a colon for one of the variables (e.g. a windows path), then use a pipe (|) as separator.
Then follows a bunch of examples, none of which use pipe (|) as a separator.
So to conclude: Continuum uses validateScmRepository(String scmUrl) and maven scm flags my scm url as invalid, but the docs for the urls are not really clear about what a delimiter/separator is and where they are in the scm url.
Asuming that the source code is correct, the the docs need updating to reflect this. There should also be an example using pipe as a separator. If someone can confirm this I can write a patch for the docs.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (SCM-106) Validation of scm url fails because of
ambiquities between source code and site documentation
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SCM-106?page=comments#action_53320 ]
Dennis Lundberg commented on SCM-106:
-------------------------------------
A patch for the code is in the works. I thought that I would write a testcase for it as well, but am having trouble finding a good home for it.
The class I really want to test is AbstractScmManager which is in maven-scm-api,
but since that class is abstract I thought that I would test DefaultScmManager in maven-scm-managers. So I put my testcase there.
The method validateScmRepository( String ) in AbstractScmManager makes use of providers which in turn are found in maven-scm-provider. But maven-scm-managers does not have a dependency on maven-scm-provider, so I'm stuck! The tests that should pass, fails because no providers can be found...
Should I just drop the whole testcase and just attach a patch for the source code and documentation?
> Validation of scm url fails because of ambiquities between source code and site documentation
> ---------------------------------------------------------------------------------------------
>
> Key: SCM-106
> URL: http://jira.codehaus.org/browse/SCM-106
> Project: Maven SCM
> Type: Bug
> Components: maven-scm-api
> Reporter: Dennis Lundberg
>
>
> I am trying out Continuum and am tracking down the cause of why I get an error regarding the scm url that I provide when adding an ant project. This has led me here. I copied the scm url from my maven 1 project.xml and got a very breif error message telling me to enter a valid scm url.
> My scm url looks like this:
> scm|cvs|pserver|user@localhost|C:/Program/cvsnt/repositories|project-name
> This works just fine using maven 1.
> These two files are involved in this:
> maven-scm-api/src/main/java/org/apache/maven/scm/manager/AbstractScmManager.java
> maven-scm-site/src/site/apt/cvs.apt
> AbstractScmManager.java has the following error message declared:
> private final static String ILLEGAL_SCM_URL = "The scm url must be on the form "
> + "'scm:<scm provider><delimiter><provider specific part>' "
> + "where <delimiter> can be either ':' or '|'.";
> which explains how a correct scm url should look.
> cvs.apt on the other hand does not have this explanation. It does say:
> For all URLs below, we use a colon (:) as separator. If you use a colon for one of the variables (e.g. a windows path), then use a pipe (|) as separator.
> Then follows a bunch of examples, none of which use pipe (|) as a separator.
> So to conclude: Continuum uses validateScmRepository(String scmUrl) and maven scm flags my scm url as invalid, but the docs for the urls are not really clear about what a delimiter/separator is and where they are in the scm url.
> Asuming that the source code is correct, the the docs need updating to reflect this. There should also be an example using pipe as a separator. If someone can confirm this I can write a patch for the docs.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (SCM-106) Validation of scm url fails because of
ambiquities between source code and site documentation
Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SCM-106?page=comments#action_53258 ]
Emmanuel Venisse commented on SCM-106:
--------------------------------------
I confirm it's a bug in code. After "scm", we should have ":" or "|". Documentation is correct.
What do we need?
- a patch for code
- a patch for the documentation relative to this bug.
> Validation of scm url fails because of ambiquities between source code and site documentation
> ---------------------------------------------------------------------------------------------
>
> Key: SCM-106
> URL: http://jira.codehaus.org/browse/SCM-106
> Project: Maven SCM
> Type: Bug
> Components: maven-scm-api
> Reporter: Dennis Lundberg
>
>
> I am trying out Continuum and am tracking down the cause of why I get an error regarding the scm url that I provide when adding an ant project. This has led me here. I copied the scm url from my maven 1 project.xml and got a very breif error message telling me to enter a valid scm url.
> My scm url looks like this:
> scm|cvs|pserver|user@localhost|C:/Program/cvsnt/repositories|project-name
> This works just fine using maven 1.
> These two files are involved in this:
> maven-scm-api/src/main/java/org/apache/maven/scm/manager/AbstractScmManager.java
> maven-scm-site/src/site/apt/cvs.apt
> AbstractScmManager.java has the following error message declared:
> private final static String ILLEGAL_SCM_URL = "The scm url must be on the form "
> + "'scm:<scm provider><delimiter><provider specific part>' "
> + "where <delimiter> can be either ':' or '|'.";
> which explains how a correct scm url should look.
> cvs.apt on the other hand does not have this explanation. It does say:
> For all URLs below, we use a colon (:) as separator. If you use a colon for one of the variables (e.g. a windows path), then use a pipe (|) as separator.
> Then follows a bunch of examples, none of which use pipe (|) as a separator.
> So to conclude: Continuum uses validateScmRepository(String scmUrl) and maven scm flags my scm url as invalid, but the docs for the urls are not really clear about what a delimiter/separator is and where they are in the scm url.
> Asuming that the source code is correct, the the docs need updating to reflect this. There should also be an example using pipe as a separator. If someone can confirm this I can write a patch for the docs.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (SCM-106) Validation of scm url fails because of
ambiquities between source code and site documentation
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SCM-106?page=all ]
Dennis Lundberg updated SCM-106:
--------------------------------
Attachment: SCM-106.patch
> Validation of scm url fails because of ambiquities between source code and site documentation
> ---------------------------------------------------------------------------------------------
>
> Key: SCM-106
> URL: http://jira.codehaus.org/browse/SCM-106
> Project: Maven SCM
> Type: Bug
> Components: maven-scm-api
> Reporter: Dennis Lundberg
> Attachments: SCM-106.patch
>
>
> I am trying out Continuum and am tracking down the cause of why I get an error regarding the scm url that I provide when adding an ant project. This has led me here. I copied the scm url from my maven 1 project.xml and got a very breif error message telling me to enter a valid scm url.
> My scm url looks like this:
> scm|cvs|pserver|user@localhost|C:/Program/cvsnt/repositories|project-name
> This works just fine using maven 1.
> These two files are involved in this:
> maven-scm-api/src/main/java/org/apache/maven/scm/manager/AbstractScmManager.java
> maven-scm-site/src/site/apt/cvs.apt
> AbstractScmManager.java has the following error message declared:
> private final static String ILLEGAL_SCM_URL = "The scm url must be on the form "
> + "'scm:<scm provider><delimiter><provider specific part>' "
> + "where <delimiter> can be either ':' or '|'.";
> which explains how a correct scm url should look.
> cvs.apt on the other hand does not have this explanation. It does say:
> For all URLs below, we use a colon (:) as separator. If you use a colon for one of the variables (e.g. a windows path), then use a pipe (|) as separator.
> Then follows a bunch of examples, none of which use pipe (|) as a separator.
> So to conclude: Continuum uses validateScmRepository(String scmUrl) and maven scm flags my scm url as invalid, but the docs for the urls are not really clear about what a delimiter/separator is and where they are in the scm url.
> Asuming that the source code is correct, the the docs need updating to reflect this. There should also be an example using pipe as a separator. If someone can confirm this I can write a patch for the docs.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (SCM-106) Validation of scm url fails because of
ambiquities between source code and site documentation
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SCM-106?page=all ]
Dennis Lundberg updated SCM-106:
--------------------------------
Attachment: SCM-106-2.patch
> Validation of scm url fails because of ambiquities between source code and site documentation
> ---------------------------------------------------------------------------------------------
>
> Key: SCM-106
> URL: http://jira.codehaus.org/browse/SCM-106
> Project: Maven SCM
> Type: Bug
> Components: maven-scm-api
> Reporter: Dennis Lundberg
> Assignee: Emmanuel Venisse
> Fix For: 1.0-beta-3
> Attachments: SCM-106-2.patch, SCM-106.patch
>
>
> I am trying out Continuum and am tracking down the cause of why I get an error regarding the scm url that I provide when adding an ant project. This has led me here. I copied the scm url from my maven 1 project.xml and got a very breif error message telling me to enter a valid scm url.
> My scm url looks like this:
> scm|cvs|pserver|user@localhost|C:/Program/cvsnt/repositories|project-name
> This works just fine using maven 1.
> These two files are involved in this:
> maven-scm-api/src/main/java/org/apache/maven/scm/manager/AbstractScmManager.java
> maven-scm-site/src/site/apt/cvs.apt
> AbstractScmManager.java has the following error message declared:
> private final static String ILLEGAL_SCM_URL = "The scm url must be on the form "
> + "'scm:<scm provider><delimiter><provider specific part>' "
> + "where <delimiter> can be either ':' or '|'.";
> which explains how a correct scm url should look.
> cvs.apt on the other hand does not have this explanation. It does say:
> For all URLs below, we use a colon (:) as separator. If you use a colon for one of the variables (e.g. a windows path), then use a pipe (|) as separator.
> Then follows a bunch of examples, none of which use pipe (|) as a separator.
> So to conclude: Continuum uses validateScmRepository(String scmUrl) and maven scm flags my scm url as invalid, but the docs for the urls are not really clear about what a delimiter/separator is and where they are in the scm url.
> Asuming that the source code is correct, the the docs need updating to reflect this. There should also be an example using pipe as a separator. If someone can confirm this I can write a patch for the docs.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (SCM-106) Validation of scm url fails because of
ambiquities between source code and site documentation
Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SCM-106?page=all ]
Emmanuel Venisse closed SCM-106:
--------------------------------
Assign To: Emmanuel Venisse
Resolution: Fixed
Fix Version: 1.0-beta-3
Applied. Thanks.
> Validation of scm url fails because of ambiquities between source code and site documentation
> ---------------------------------------------------------------------------------------------
>
> Key: SCM-106
> URL: http://jira.codehaus.org/browse/SCM-106
> Project: Maven SCM
> Type: Bug
> Components: maven-scm-api
> Reporter: Dennis Lundberg
> Assignee: Emmanuel Venisse
> Fix For: 1.0-beta-3
> Attachments: SCM-106.patch
>
>
> I am trying out Continuum and am tracking down the cause of why I get an error regarding the scm url that I provide when adding an ant project. This has led me here. I copied the scm url from my maven 1 project.xml and got a very breif error message telling me to enter a valid scm url.
> My scm url looks like this:
> scm|cvs|pserver|user@localhost|C:/Program/cvsnt/repositories|project-name
> This works just fine using maven 1.
> These two files are involved in this:
> maven-scm-api/src/main/java/org/apache/maven/scm/manager/AbstractScmManager.java
> maven-scm-site/src/site/apt/cvs.apt
> AbstractScmManager.java has the following error message declared:
> private final static String ILLEGAL_SCM_URL = "The scm url must be on the form "
> + "'scm:<scm provider><delimiter><provider specific part>' "
> + "where <delimiter> can be either ':' or '|'.";
> which explains how a correct scm url should look.
> cvs.apt on the other hand does not have this explanation. It does say:
> For all URLs below, we use a colon (:) as separator. If you use a colon for one of the variables (e.g. a windows path), then use a pipe (|) as separator.
> Then follows a bunch of examples, none of which use pipe (|) as a separator.
> So to conclude: Continuum uses validateScmRepository(String scmUrl) and maven scm flags my scm url as invalid, but the docs for the urls are not really clear about what a delimiter/separator is and where they are in the scm url.
> Asuming that the source code is correct, the the docs need updating to reflect this. There should also be an example using pipe as a separator. If someone can confirm this I can write a patch for the docs.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Reopened: (SCM-106) Validation of scm url fails because of
ambiquities between source code and site documentation
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SCM-106?page=all ]
Dennis Lundberg reopened SCM-106:
---------------------------------
After some discussion on scm-dev we have come to the conclusion that the correct format of an scm url should be:
scm:<scm_provider><delimiter><provider_specific_part>
I will attach a new patch for this later on.
> Validation of scm url fails because of ambiquities between source code and site documentation
> ---------------------------------------------------------------------------------------------
>
> Key: SCM-106
> URL: http://jira.codehaus.org/browse/SCM-106
> Project: Maven SCM
> Type: Bug
> Components: maven-scm-api
> Reporter: Dennis Lundberg
> Assignee: Emmanuel Venisse
> Fix For: 1.0-beta-3
> Attachments: SCM-106.patch
>
>
> I am trying out Continuum and am tracking down the cause of why I get an error regarding the scm url that I provide when adding an ant project. This has led me here. I copied the scm url from my maven 1 project.xml and got a very breif error message telling me to enter a valid scm url.
> My scm url looks like this:
> scm|cvs|pserver|user@localhost|C:/Program/cvsnt/repositories|project-name
> This works just fine using maven 1.
> These two files are involved in this:
> maven-scm-api/src/main/java/org/apache/maven/scm/manager/AbstractScmManager.java
> maven-scm-site/src/site/apt/cvs.apt
> AbstractScmManager.java has the following error message declared:
> private final static String ILLEGAL_SCM_URL = "The scm url must be on the form "
> + "'scm:<scm provider><delimiter><provider specific part>' "
> + "where <delimiter> can be either ':' or '|'.";
> which explains how a correct scm url should look.
> cvs.apt on the other hand does not have this explanation. It does say:
> For all URLs below, we use a colon (:) as separator. If you use a colon for one of the variables (e.g. a windows path), then use a pipe (|) as separator.
> Then follows a bunch of examples, none of which use pipe (|) as a separator.
> So to conclude: Continuum uses validateScmRepository(String scmUrl) and maven scm flags my scm url as invalid, but the docs for the urls are not really clear about what a delimiter/separator is and where they are in the scm url.
> Asuming that the source code is correct, the the docs need updating to reflect this. There should also be an example using pipe as a separator. If someone can confirm this I can write a patch for the docs.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (SCM-106) Validation of scm url fails because of
ambiquities between source code and site documentation
Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SCM-106?page=all ]
Emmanuel Venisse closed SCM-106:
--------------------------------
Resolution: Fixed
Applied. Thanks.
> Validation of scm url fails because of ambiquities between source code and site documentation
> ---------------------------------------------------------------------------------------------
>
> Key: SCM-106
> URL: http://jira.codehaus.org/browse/SCM-106
> Project: Maven SCM
> Type: Bug
> Components: maven-scm-api
> Reporter: Dennis Lundberg
> Assignee: Emmanuel Venisse
> Fix For: 1.0-beta-3
> Attachments: SCM-106-2.patch, SCM-106.patch
>
>
> I am trying out Continuum and am tracking down the cause of why I get an error regarding the scm url that I provide when adding an ant project. This has led me here. I copied the scm url from my maven 1 project.xml and got a very breif error message telling me to enter a valid scm url.
> My scm url looks like this:
> scm|cvs|pserver|user@localhost|C:/Program/cvsnt/repositories|project-name
> This works just fine using maven 1.
> These two files are involved in this:
> maven-scm-api/src/main/java/org/apache/maven/scm/manager/AbstractScmManager.java
> maven-scm-site/src/site/apt/cvs.apt
> AbstractScmManager.java has the following error message declared:
> private final static String ILLEGAL_SCM_URL = "The scm url must be on the form "
> + "'scm:<scm provider><delimiter><provider specific part>' "
> + "where <delimiter> can be either ':' or '|'.";
> which explains how a correct scm url should look.
> cvs.apt on the other hand does not have this explanation. It does say:
> For all URLs below, we use a colon (:) as separator. If you use a colon for one of the variables (e.g. a windows path), then use a pipe (|) as separator.
> Then follows a bunch of examples, none of which use pipe (|) as a separator.
> So to conclude: Continuum uses validateScmRepository(String scmUrl) and maven scm flags my scm url as invalid, but the docs for the urls are not really clear about what a delimiter/separator is and where they are in the scm url.
> Asuming that the source code is correct, the the docs need updating to reflect this. There should also be an example using pipe as a separator. If someone can confirm this I can write a patch for the docs.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira