You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@texera.apache.org by "eugenegujing (via GitHub)" <gi...@apache.org> on 2026/08/14 00:06:55 UTC

[I] add unit test coverage for the coordinator AdvanceRegionExecutionsHandler [texera]

eugenegujing opened a new issue, #7646:
URL: https://github.com/apache/texera/issues/7646

   ### Task Summary
   
   `amber/src/main/scala/org/apache/texera/amber/engine/architecture/coordinator/promisehandlers/AdvanceRegionExecutionsHandler.scala` (added in #6960) runs the region-execution advance in its own control round: handlers that need regions advanced send this RPC to the coordinator itself instead of advancing inline, so that terminating completed regions happens after every reply the requesting round owed. On failure it notifies the client with a `FatalError`, attaching the related worker id when the failure came from a worker RPC and `None` otherwise.
   
   The handler body has no direct coverage: `PortCompletedHandlerSpec` asserts that the advance is requested (it checks the outgoing invocation) but never drives this handler, so the advance delegation and both `FatalError` notification paths are unasserted.
   
   ### Task Type
   
   - [ ] Refactor / Cleanup
   - [ ] DevOps / Deployment / CI
   - [x] Testing / QA
   - [ ] Documentation
   - [ ] Performance
   - [ ] Other


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] add unit test coverage for the coordinator AdvanceRegionExecutionsHandler [texera]

Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.

aglinxinyuan closed issue #7646: add unit test coverage for the coordinator AdvanceRegionExecutionsHandler
URL: https://github.com/apache/texera/issues/7646


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org