You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "harshithasudhakar (via GitHub)" <gi...@apache.org> on 2023/04/15 17:39:33 UTC

[GitHub] [eventmesh] harshithasudhakar opened a new pull request, #3741: [ISSUE #3730]Reduce the total number of continue statements in this loop.[HeartBeatProcessor]

harshithasudhakar opened a new pull request, #3741:
URL: https://github.com/apache/eventmesh/pull/3741

   Fixes #3730 
   
   ### Modifications
   
   Reduced the total number of continue statements used in lines 125, 152
   
   
   ### Documentation
   
   - Does this pull request introduce a new feature? no
   - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [eventmesh] codecov[bot] commented on pull request #3741: [ISSUE #3730]Reduce the total number of continue statements in this loop.[HeartBeatProcessor]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3741:
URL: https://github.com/apache/eventmesh/pull/3741#issuecomment-1510999190

   ## [Codecov](https://codecov.io/gh/apache/eventmesh/pull/3741?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3741](https://codecov.io/gh/apache/eventmesh/pull/3741?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (df8a29d) into [master](https://codecov.io/gh/apache/eventmesh/commit/58b5ab715f27cf67b069f62beb6254b7ec20cdb5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (58b5ab7) will **decrease** coverage by `0.01%`.
   > The diff coverage is `0.00%`.
   
   > :exclamation: Current head df8a29d differs from pull request most recent head b68df81. Consider uploading reports for the commit b68df81 to get more accurate results
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3741      +/-   ##
   ============================================
   - Coverage     13.76%   13.75%   -0.01%     
     Complexity     1291     1291              
   ============================================
     Files           571      571              
     Lines         29234    29225       -9     
     Branches       2883     2870      -13     
   ============================================
   - Hits           4024     4020       -4     
   + Misses        24836    24832       -4     
   + Partials        374      373       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/eventmesh/pull/3741?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...re/protocol/http/processor/HeartBeatProcessor.java](https://codecov.io/gh/apache/eventmesh/pull/3741?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wcm9jZXNzb3IvSGVhcnRCZWF0UHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   
   ... and [7 files with indirect coverage changes](https://codecov.io/gh/apache/eventmesh/pull/3741/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org


[GitHub] [eventmesh] weihubeats merged pull request #3741: [ISSUE #3730]Reduce the total number of continue statements in this loop.[HeartBeatProcessor]

Posted by "weihubeats (via GitHub)" <gi...@apache.org>.
weihubeats merged PR #3741:
URL: https://github.com/apache/eventmesh/pull/3741


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org