You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2023/01/10 20:38:18 UTC
[GitHub] [kafka] mumrah opened a new pull request, #13103: KAFKA-14304 Use boolean for ZK migrating brokers in RPC/record
mumrah opened a new pull request, #13103:
URL: https://github.com/apache/kafka/pull/13103
With the new broker epoch validation logic introduce in #12998, we no longer need the ZK broker epoch to be sent to the KRaft controller. This patch removes that epoch and replaces it with a boolean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mumrah commented on pull request #13103: KAFKA-14304 Use boolean for ZK migrating brokers in RPC/record
Posted by GitBox <gi...@apache.org>.
mumrah commented on PR #13103:
URL: https://github.com/apache/kafka/pull/13103#issuecomment-1379387869
Two runs with different sets of flaky tests. They are all unrelated to this change (which is gated behind the migration config)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on a diff in pull request #13103: KAFKA-14304 Use boolean for ZK migrating brokers in RPC/record
Posted by GitBox <gi...@apache.org>.
cmccabe commented on code in PR #13103:
URL: https://github.com/apache/kafka/pull/13103#discussion_r1066357853
##########
core/src/main/scala/kafka/server/KafkaServer.scala:
##########
@@ -812,7 +811,7 @@ class KafkaServer(
_brokerState = BrokerState.PENDING_CONTROLLED_SHUTDOWN
- if (config.migrationEnabled && lifecycleManager != null) {
+ if (config.migrationEnabled && lifecycleManager != null && metadataCache.getControllerId.exists(_.isInstanceOf[KRaftCachedControllerId])) {
Review Comment:
this is a good fix, can you include it in the change description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mumrah merged pull request #13103: KAFKA-14304 Use boolean for ZK migrating brokers in RPC/record
Posted by GitBox <gi...@apache.org>.
mumrah merged PR #13103:
URL: https://github.com/apache/kafka/pull/13103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org