You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/03/08 01:06:16 UTC

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #5473: [Bug] Fix bug that data lost when doing backup job

yangzhg commented on a change in pull request #5473:
URL: https://github.com/apache/incubator-doris/pull/5473#discussion_r588804740



##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/Catalog.java
##########
@@ -3324,7 +3324,8 @@ public void dropPartition(Database db, OlapTable olapTable, DropPartitionClause
                     }
                 }
             }
-            olapTable.dropPartition(db.getId(), partitionName, clause.isForceDrop());
+            olapTable.dropPartition(db.getId(), partitionName, clause.isForceDrop(),
+                    clause.isForceDrop() /* If force, then drop tablet too, if not, keey the tablet too.*/);

Review comment:
       ```
   
   +                    clause.isForceDrop() /* If force, then drop tablet too, if not, keep the tablet.*/);
   
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org