You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/11/08 22:47:07 UTC

[GitHub] [maven-plugin-tools] slawekjaranowski commented on a diff in pull request #117: [4.x] Support for the new maven4 api

slawekjaranowski commented on code in PR #117:
URL: https://github.com/apache/maven-plugin-tools/pull/117#discussion_r1017194129


##########
maven-plugin-tools-generators/src/main/resources/help-class-source.vm:
##########
@@ -1,13 +1,20 @@
+#if ( $useMaven4Api )
+#set ( $mojoException = "MojoException" )
+#set ( $logger = "logger" )
+#else
+#set ( $mojoException = "MojoExecutionException" )
+#set ( $logger = "getLog()" )
+#end

Review Comment:
   Maybe separate file for v3 and v4.
   in V4 we can drop javadoc tags



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org