You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2021/08/21 04:54:50 UTC
[GitHub] [zookeeper] zhongxiongzeng opened a new pull request #1721: ZOOKEEPER-4346: remove never used field
zhongxiongzeng opened a new pull request #1721:
URL: https://github.com/apache/zookeeper/pull/1721
remove some never used field
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] maoling commented on pull request #1721: ZOOKEEPER-4332: remove never used field
Posted by GitBox <gi...@apache.org>.
maoling commented on pull request #1721:
URL: https://github.com/apache/zookeeper/pull/1721#issuecomment-887156761
@zhongxiongzeng
- Any advance? Or need any help?
- I'm waiting here for merging this PR :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] zhongxiongzeng commented on a change in pull request #1721: ZOOKEEPER-4332: remove never used field
Posted by GitBox <gi...@apache.org>.
zhongxiongzeng commented on a change in pull request #1721:
URL: https://github.com/apache/zookeeper/pull/1721#discussion_r664017809
##########
File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooTrace.java
##########
@@ -33,8 +33,6 @@
public static final long CLIENT_REQUEST_TRACE_MASK = 1 << 1;
- public static final long CLIENT_DATA_PACKET_TRACE_MASK = 1 << 2;
Review comment:
get
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] asfgit closed pull request #1721: ZOOKEEPER-4346: remove never used field
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1721:
URL: https://github.com/apache/zookeeper/pull/1721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] bigmarvin removed a comment on pull request #1721: ZOOKEEPER-4332: remove never used field
Posted by GitBox <gi...@apache.org>.
bigmarvin removed a comment on pull request #1721:
URL: https://github.com/apache/zookeeper/pull/1721#issuecomment-872219894
@zhongxiongzeng, are you sure this change is trying to address [ZOOKEEPER-4331](https://issues.apache.org/jira/browse/ZOOKEEPER-4331)? If not, do you mind filing another ticket for tracking?
Though I'm proposing the fix in https://github.com/apache/zookeeper/pull/1720, I'm open to better alternatives. However, this PR just seems not really related, and I would appreciate it a lot if this PR is no longer associated with ZOOKEEPER-4331. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli commented on a change in pull request #1721: ZOOKEEPER-4332: remove never used field
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #1721:
URL: https://github.com/apache/zookeeper/pull/1721#discussion_r663992659
##########
File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooTrace.java
##########
@@ -33,8 +33,6 @@
public static final long CLIENT_REQUEST_TRACE_MASK = 1 << 1;
- public static final long CLIENT_DATA_PACKET_TRACE_MASK = 1 << 2;
Review comment:
it is better to keep this constant here.
we can add a comment and say that this is obsolete
the same applies to `JMX_TRACE_MASK`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] bigmarvin commented on pull request #1721: ZOOKEEPER-4331: remove never used field
Posted by GitBox <gi...@apache.org>.
bigmarvin commented on pull request #1721:
URL: https://github.com/apache/zookeeper/pull/1721#issuecomment-872219894
@zhongxiongzeng, are you sure this change is trying to address [ZOOKEEPER-4331](https://issues.apache.org/jira/browse/ZOOKEEPER-4331)? If not, do you mind filing another ticket for tracking?
Though I'm proposing the fix in https://github.com/apache/zookeeper/pull/1720, I'm open to better alternatives. However, this PR just seems not really related, and I would appreciate it a lot if this PR is no longer associated with ZOOKEEPER-4331. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] zhongxiongzeng commented on a change in pull request #1721: ZOOKEEPER-4332: remove never used field
Posted by GitBox <gi...@apache.org>.
zhongxiongzeng commented on a change in pull request #1721:
URL: https://github.com/apache/zookeeper/pull/1721#discussion_r664017809
##########
File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooTrace.java
##########
@@ -33,8 +33,6 @@
public static final long CLIENT_REQUEST_TRACE_MASK = 1 << 1;
- public static final long CLIENT_DATA_PACKET_TRACE_MASK = 1 << 2;
Review comment:
get
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] maoling closed pull request #1721: ZOOKEEPER-4346: remove never used field
Posted by GitBox <gi...@apache.org>.
maoling closed pull request #1721:
URL: https://github.com/apache/zookeeper/pull/1721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] maoling commented on pull request #1721: ZOOKEEPER-4346: remove never used field
Posted by GitBox <gi...@apache.org>.
maoling commented on pull request #1721:
URL: https://github.com/apache/zookeeper/pull/1721#issuecomment-903090671
- @zhongxiongzeng Thanks for your contribution.
- Look at what I did, I create a new JIRA https://issues.apache.org/jira/browse/ZOOKEEPER-4346 for this PR and bind them. remember it at next time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] bigmarvin removed a comment on pull request #1721: ZOOKEEPER-4332: remove never used field
Posted by GitBox <gi...@apache.org>.
bigmarvin removed a comment on pull request #1721:
URL: https://github.com/apache/zookeeper/pull/1721#issuecomment-872219894
@zhongxiongzeng, are you sure this change is trying to address [ZOOKEEPER-4331](https://issues.apache.org/jira/browse/ZOOKEEPER-4331)? If not, do you mind filing another ticket for tracking?
Though I'm proposing the fix in https://github.com/apache/zookeeper/pull/1720, I'm open to better alternatives. However, this PR just seems not really related, and I would appreciate it a lot if this PR is no longer associated with ZOOKEEPER-4331. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] maoling commented on pull request #1721: ZOOKEEPER-4332: remove never used field
Posted by GitBox <gi...@apache.org>.
maoling commented on pull request #1721:
URL: https://github.com/apache/zookeeper/pull/1721#issuecomment-879012717
@zhongxiongzeng
> Do you mean to create a new pr?
- Nope, you should create a new JIRA and change this PR description.
- It's better to create a [JIRA](https://issues.apache.org/jira/projects/ZOOKEEPER/) issue (sign up JIRA if you don't have an account) to bind this PR to a JIRA-ID. ZooKeeper uses the GitHub workflow. The contributor guideline is [here](https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] zhongxiongzeng commented on pull request #1721: ZOOKEEPER-4332: remove never used field
Posted by GitBox <gi...@apache.org>.
zhongxiongzeng commented on pull request #1721:
URL: https://github.com/apache/zookeeper/pull/1721#issuecomment-877933520
> Hi @zhongxiongzeng,
>
> Thank you for your contribution! [ZOOKEEPER-4332](https://issues.apache.org/jira/browse/ZOOKEEPER-4332) ("Cannot access children of znode that owns too many znodes") is unrelated to the changes in this pull request, however. Would you mind opening another ticket, and updating the association?
>
> Thanks!
Do you mean to create a new pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli commented on a change in pull request #1721: ZOOKEEPER-4332: remove never used field
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #1721:
URL: https://github.com/apache/zookeeper/pull/1721#discussion_r663992659
##########
File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooTrace.java
##########
@@ -33,8 +33,6 @@
public static final long CLIENT_REQUEST_TRACE_MASK = 1 << 1;
- public static final long CLIENT_DATA_PACKET_TRACE_MASK = 1 << 2;
Review comment:
it is better to keep this constant here.
we can add a comment and say that this is obsolete
the same applies to `JMX_TRACE_MASK`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org