You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by yi...@apache.org on 2022/05/02 10:05:05 UTC

[incubator-doris] branch master updated: [Bug] [Build] fix clang build fail (#9323)

This is an automated email from the ASF dual-hosted git repository.

yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git


The following commit(s) were added to refs/heads/master by this push:
     new b1870faddd [Bug] [Build] fix clang build fail (#9323)
b1870faddd is described below

commit b1870fadddb44aa009bdad0f30e04c99c3057885
Author: Pxl <95...@qq.com>
AuthorDate: Mon May 2 18:04:57 2022 +0800

    [Bug] [Build] fix clang build fail (#9323)
    
    * fix clang compile fail
---
 be/src/exec/broker_scan_node.h | 20 ++++++++++++--------
 be/src/exec/broker_scanner.h   |  6 +++++-
 2 files changed, 17 insertions(+), 9 deletions(-)

diff --git a/be/src/exec/broker_scan_node.h b/be/src/exec/broker_scan_node.h
index 68adbf007c..e8fb99b24b 100644
--- a/be/src/exec/broker_scan_node.h
+++ b/be/src/exec/broker_scan_node.h
@@ -41,29 +41,33 @@ struct ScannerCounter;
 class BrokerScanNode : public ScanNode {
 public:
     BrokerScanNode(ObjectPool* pool, const TPlanNode& tnode, const DescriptorTbl& descs);
-    virtual ~BrokerScanNode();
+    ~BrokerScanNode() override;
 
     // Called after create this scan node
-    virtual Status init(const TPlanNode& tnode, RuntimeState* state = nullptr) override;
+    Status init(const TPlanNode& tnode, RuntimeState* state = nullptr) override;
 
     // Prepare partition infos & set up timer
-    virtual Status prepare(RuntimeState* state) override;
+    Status prepare(RuntimeState* state) override;
 
     // Start broker scan using ParquetScanner or BrokerScanner.
-    virtual Status open(RuntimeState* state) override;
+    Status open(RuntimeState* state) override;
 
     // Fill the next row batch by calling next() on the scanner,
-    virtual Status get_next(RuntimeState* state, RowBatch* row_batch, bool* eos) override;
+    Status get_next(RuntimeState* state, RowBatch* row_batch, bool* eos) override;
+
+    Status get_next(RuntimeState* state, vectorized::Block* block, bool* eos) override {
+        return Status::NotSupported("Not Implemented get block");
+    }
 
     // Close the scanner, and report errors.
-    virtual Status close(RuntimeState* state) override;
+    Status close(RuntimeState* state) override;
 
     // No use
-    virtual Status set_scan_ranges(const std::vector<TScanRangeParams>& scan_ranges) override;
+    Status set_scan_ranges(const std::vector<TScanRangeParams>& scan_ranges) override;
 
 protected:
     // Write debug string of this into out.
-    virtual void debug_string(int indentation_level, std::stringstream* out) const override;
+    void debug_string(int indentation_level, std::stringstream* out) const override;
 
     // Update process status to one failed status,
     // NOTE: Must hold the mutex of this scan node
diff --git a/be/src/exec/broker_scanner.h b/be/src/exec/broker_scanner.h
index e56fce6bc6..7906b98ff4 100644
--- a/be/src/exec/broker_scanner.h
+++ b/be/src/exec/broker_scanner.h
@@ -56,7 +56,7 @@ public:
                   const TBrokerScanRangeParams& params, const std::vector<TBrokerRangeDesc>& ranges,
                   const std::vector<TNetworkAddress>& broker_addresses,
                   const std::vector<TExpr>& pre_filter_texprs, ScannerCounter* counter);
-    virtual ~BrokerScanner();
+    ~BrokerScanner() override;
 
     // Open this scanner, will initialize information need to
     Status open() override;
@@ -64,6 +64,10 @@ public:
     // Get next tuple
     Status get_next(Tuple* tuple, MemPool* tuple_pool, bool* eof, bool* fill_tuple) override;
 
+    Status get_next(std::vector<vectorized::MutableColumnPtr>& columns, bool* eof) override {
+        return Status::NotSupported("Not Implemented get columns");
+    }
+
     // Close this scanner
     void close() override;
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org