You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by twalthr <gi...@git.apache.org> on 2018/05/17 14:41:08 UTC

[GitHub] flink pull request #6034: [FLINK-7450] [types] Fix type extraction of bounde...

GitHub user twalthr opened a pull request:

    https://github.com/apache/flink/pull/6034

    [FLINK-7450] [types] Fix type extraction of bounded generic POJO fields

    ## What is the purpose of the change
    
    This PR fixes the type extraction of POJO fields with bounded generics. Before those fields were treated as unknown fields with `Object` type in Kryo. This PR breaks backwards compatibility for jobs with such special cases. We need to discuss if we want to do that.
    
    ## Brief change log
    
    - Use generic bounds of type variables during POJO extraction
    
    
    ## Verifying this change
    
    - Two unit tests have been added
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
      - The serializers: yes
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
      - The S3 file system connector: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no
      - If yes, how is the feature documented? JavaDocs


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twalthr/flink FLINK-7450

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6034.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6034
    
----
commit d94eda3b85273603e92ce41ec269494be512758d
Author: Timo Walther <tw...@...>
Date:   2018-05-17T14:12:54Z

    [FLINK-7450] [types] Fix type extraction of bounded generic POJO fields

----


---