svn commit: r628214 - in /db/jdo/trunk/tck2: maven.xml src/java/org/apache/jdo/tck/api/persistencemanagerfactory/config/Jdoconfig.java

[mc...@apache.org]

Author: mcaisse
Date: Fri Feb 15 16:29:11 2008
New Revision: 628214

URL: http://svn.apache.org/viewvc?rev=628214&view=rev
Log:
JDO-576 Added comments to test, check-in maven.xml, missing from previous check-in

Modified:
    db/jdo/trunk/tck2/maven.xml
    db/jdo/trunk/tck2/src/java/org/apache/jdo/tck/api/persistencemanagerfactory/config/Jdoconfig.java

Modified: db/jdo/trunk/tck2/maven.xml
URL: http://svn.apache.org/viewvc/db/jdo/trunk/tck2/maven.xml?rev=628214&r1=628213&r2=628214&view=diff
==============================================================================
--- db/jdo/trunk/tck2/maven.xml (original)
+++ db/jdo/trunk/tck2/maven.xml Fri Feb 15 16:29:11 2008
@@ -475,6 +475,8 @@
                          value="${jdo.tck.cleanupaftertest}"/>
             <sysproperty key="jdo.tck.requiredOptions"
                          value="${jdo.tck.requiredOptions}"/>
+            <sysproperty key="jdo.tck.schemaname"
+                         value="${schemaname}"/>
             <sysproperty key="jdo.tck.mapping.companyfactory"
                          value="${jdo.tck.mapping.companyfactory}"/>
             <sysproperty key="jdo.tck.closePMFAfterEachTest"

Modified: db/jdo/trunk/tck2/src/java/org/apache/jdo/tck/api/persistencemanagerfactory/config/Jdoconfig.java
URL: http://svn.apache.org/viewvc/db/jdo/trunk/tck2/src/java/org/apache/jdo/tck/api/persistencemanagerfactory/config/Jdoconfig.java?rev=628214&r1=628213&r2=628214&view=diff
==============================================================================
--- db/jdo/trunk/tck2/src/java/org/apache/jdo/tck/api/persistencemanagerfactory/config/Jdoconfig.java (original)
+++ db/jdo/trunk/tck2/src/java/org/apache/jdo/tck/api/persistencemanagerfactory/config/Jdoconfig.java Fri Feb 15 16:29:11 2008
@@ -27,11 +27,11 @@
 
 /**
  *<B>Title:</B>Close of PersistenceManagerFactory  
- *<BR>
+ *<BR/>
  *<B>Keywords:</B> persistencemanagerfactory, jdoconfig.xml
- *<BR>
+ *<BR/>
  *<B>Assertion IDs:</B> A11.1.2-1
- *<BR>
+ *<BR/>
  *<B>Assertion Description: </B>
  * Users can access a PersistenceManagerFactory by creating a jdoconfig.xml file
  * and making it available on the class path as META-INF/jdoconfig.xml.
@@ -63,12 +63,17 @@
      * @see JDO_Test#localSetUp()
      */
     protected void localSetUp() {
+        /* Instance can be persisted ONLY if javax.jdo.mapping.Schema
+         *   is overriden with 
+         *   JDOHelper.getPersistenceManagerFactory(Map overrides, ...).
+         *   The value depends on identity type so can only be known at runtime.
+         */
         if (isTestToBePerformed()) {
             overrides.put("javax.jdo.mapping.Schema", schemaname);
         }
     }
 
-    /** */
+    /** */ 
     public void testGetPMFNoArgs() {
         pmf = JDOHelper.getPersistenceManagerFactory();
         checkIsOpen(ANONYMOUS_PMF_NAME);
@@ -156,7 +161,11 @@
         pmf = null;
     }
 
-    /** */
+    /** 
+     * Checks if instance can be persisted. Can be used if
+     *    javax.jdo.mapping.Schema is overriden with the correct value
+     *    with JDOHelper.getPersistenceManagerFactory(Map overrides, ...).
+     */
     public void checkPersistent(String name) {
         assertEquals("Incorrect PMF name", pmf.getName(), name);