You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Alexander Rojas <al...@mesosphere.io> on 2015/02/04 11:37:59 UTC
Review Request 30612: Added
/master/frameworks/{framework}/tasks/{task} endpoint.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
Bugs: MESOS-2157
https://issues.apache.org/jira/browse/MESOS-2157
Repository: mesos
Description
-------
Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
Works with [29883](https://reviews.apache.org/r/29883).
Builds on the abandoned patch 14286.
Diffs
-----
src/master/http.cpp 3981b18
src/master/master.hpp cd37ee9
src/master/master.cpp d04b2c4
src/tests/master_tests.cpp 678d27f
Diff: https://reviews.apache.org/r/30612/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 30612: Added
/master/frameworks/{framework}/tasks/{task} endpoint.
Posted by Alexander Rojas <al...@mesosphere.io>.
> On Feb. 4, 2015, 7:02 p.m., Alexander Rukletsov wrote:
> > src/master/master.cpp, lines 601-603
> > <https://reviews.apache.org/r/30612/diff/2/?file=847632#file847632line601>
> >
> > Shouldn't it be `/frameworks.json`?
This is a good question. On principle, I agree with you, but the route is more than frameworks, and using the `.json` suffix would requiere then manual of the path or having something like `/frameworks.json/{whatever-comes-next}`
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/#review70982
-----------------------------------------------------------
On Feb. 4, 2015, 2:34 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30612/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 2:34 p.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
>
>
> Bugs: MESOS-2157
> https://issues.apache.org/jira/browse/MESOS-2157
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
>
> Works with [29883](https://reviews.apache.org/r/29883).
>
> Builds on the abandoned patch 14286.
>
>
> Diffs
> -----
>
> src/master/http.cpp 3981b18
> src/master/master.hpp cd37ee9
> src/master/master.cpp d04b2c4
> src/tests/master_tests.cpp 678d27f
>
> Diff: https://reviews.apache.org/r/30612/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 30612: Added
/master/frameworks/{framework}/tasks/{task} endpoint.
Posted by Alexander Rojas <al...@mesosphere.io>.
> On Feb. 4, 2015, 7:02 p.m., Alexander Rukletsov wrote:
> > Thanks for the patch, Alexander! I have a high-level question. In such checks:
> > ```
> > Try<JSON::Value> expected = JSON::parse("[]");
> > ASSERT_SOME(expected);
> >
> > Result<JSON::Value> _tasks = framework.find<JSON::Value>("tasks");
> > EXPECT_SOME_EQ(expected.get(), _tasks);
> > ```
> > do we want instead (or additionally) to check that the task array is empty? If possible, I would prefer to operate with high-level abstractions here and leave JSON representation details for JSON tests.
Originally the implementation was as you suggested, but Niklas mentioned it was more readably if you just set an expected object and then compare the result to it. I not only agree with this, but is also what all other tests on the file do, so it is also consistent.
> On Feb. 4, 2015, 7:02 p.m., Alexander Rukletsov wrote:
> > src/tests/master_tests.cpp, lines 1593-1596
> > <https://reviews.apache.org/r/30612/diff/2/?file=847633#file847633line1593>
> >
> > Isn't it more stable to check that `frameworks` key is present and the associated array is empty?
See my comment above.
> On Feb. 4, 2015, 7:02 p.m., Alexander Rukletsov wrote:
> > src/tests/master_tests.cpp, line 1819
> > <https://reviews.apache.org/r/30612/diff/2/?file=847633#file847633line1819>
> >
> > Shouldn't we check the array is empty?
See my first comment. It just compares two json objects and expect them to be equivalent.
> On Feb. 4, 2015, 7:02 p.m., Alexander Rukletsov wrote:
> > src/tests/master_tests.cpp, lines 1985-1989
> > <https://reviews.apache.org/r/30612/diff/2/?file=847633#file847633line1985>
> >
> > Isn't it covered in a previous test?
The tests are different. The returned objects are different whether you use `/master/frameworks` or `master/frameworks/{frameworkId}` or `master/frameworks/{frameworkId}/tasks` or `master/frameworks/{frameworkId}/tasks/{taskId}`. However, since the set up of the cluster is the same, you compare to the same values.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/#review70982
-----------------------------------------------------------
On Feb. 4, 2015, 2:34 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30612/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 2:34 p.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
>
>
> Bugs: MESOS-2157
> https://issues.apache.org/jira/browse/MESOS-2157
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
>
> Works with [29883](https://reviews.apache.org/r/29883).
>
> Builds on the abandoned patch 14286.
>
>
> Diffs
> -----
>
> src/master/http.cpp 3981b18
> src/master/master.hpp cd37ee9
> src/master/master.cpp d04b2c4
> src/tests/master_tests.cpp 678d27f
>
> Diff: https://reviews.apache.org/r/30612/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 30612: Added
/master/frameworks/{framework}/tasks/{task} endpoint.
Posted by Alexander Rojas <al...@mesosphere.io>.
> On Feb. 4, 2015, 7:02 p.m., Alexander Rukletsov wrote:
> > src/tests/master_tests.cpp, lines 1653-1654
> > <https://reviews.apache.org/r/30612/diff/2/?file=847633#file847633line1653>
> >
> > What "black magic" do you mean?
You're right, this comment shouldn't be there. Moreover, two slaves are not longer used, just part of a previous version of the patch.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/#review70982
-----------------------------------------------------------
On Feb. 5, 2015, 12:52 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30612/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2015, 12:52 a.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
>
>
> Bugs: MESOS-2157
> https://issues.apache.org/jira/browse/MESOS-2157
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
>
> Works with [29883](https://reviews.apache.org/r/29883).
>
> Builds on the abandoned patch 14286.
>
>
> Diffs
> -----
>
> src/master/http.cpp 3981b18
> src/master/master.hpp cd37ee9
> src/master/master.cpp d04b2c4
> src/tests/master_tests.cpp 678d27f
>
> Diff: https://reviews.apache.org/r/30612/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 30612: Added
/master/frameworks/{framework}/tasks/{task} endpoint.
Posted by Alexander Rojas <al...@mesosphere.io>.
> On Feb. 4, 2015, 7:02 p.m., Alexander Rukletsov wrote:
> > src/master/master.cpp, lines 601-603
> > <https://reviews.apache.org/r/30612/diff/2/?file=847632#file847632line601>
> >
> > Shouldn't it be `/frameworks.json`?
>
> Alexander Rojas wrote:
> This is a good question. On principle, I agree with you, but the route is more than frameworks, and using the `.json` suffix would requiere then manual of the path or having something like `/frameworks.json/{whatever-comes-next}`
So this was discussed this with nnielsen and at the end it boils down to, in REST like endpoints, is not commong to have something like `/frameworks.json/UUID/tasks.json/UUID`. Marathon also has the endpoints: `/v2/apps/` and `/v2/apps/UUID/` which are not suffixed with json.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/#review70982
-----------------------------------------------------------
On Feb. 5, 2015, 1:54 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30612/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2015, 1:54 a.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
>
>
> Bugs: MESOS-2157
> https://issues.apache.org/jira/browse/MESOS-2157
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
>
> Works with [29883](https://reviews.apache.org/r/29883).
>
> Builds on the abandoned patch 14286.
>
>
> Diffs
> -----
>
> src/master/http.cpp 3981b18
> src/master/master.hpp cd37ee9
> src/master/master.cpp d04b2c4
> src/tests/master_tests.cpp 678d27f
>
> Diff: https://reviews.apache.org/r/30612/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 30612: Added
/master/frameworks/{framework}/tasks/{task} endpoint.
Posted by Alexander Rukletsov <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/#review70982
-----------------------------------------------------------
Thanks for the patch, Alexander! I have a high-level question. In such checks:
```
Try<JSON::Value> expected = JSON::parse("[]");
ASSERT_SOME(expected);
Result<JSON::Value> _tasks = framework.find<JSON::Value>("tasks");
EXPECT_SOME_EQ(expected.get(), _tasks);
```
do we want instead (or additionally) to check that the task array is empty? If possible, I would prefer to operate with high-level abstractions here and leave JSON representation details for JSON tests.
src/master/master.cpp
<https://reviews.apache.org/r/30612/#comment116461>
Shouldn't it be `/frameworks.json`?
src/tests/master_tests.cpp
<https://reviews.apache.org/r/30612/#comment116479>
Isn't it more stable to check that `frameworks` key is present and the associated array is empty?
src/tests/master_tests.cpp
<https://reviews.apache.org/r/30612/#comment116462>
What "black magic" do you mean?
src/tests/master_tests.cpp
<https://reviews.apache.org/r/30612/#comment116463>
Where is the second slave mentioned above? Is it started implicitly somehow?
src/tests/master_tests.cpp
<https://reviews.apache.org/r/30612/#comment116464>
Though this is what you see in other tests, there is a nicer way to do it:
`EXPECT_FALSE(offers.get().empty());`
src/tests/master_tests.cpp
<https://reviews.apache.org/r/30612/#comment116465>
You can cache the offer references before and reuse it here and below.
`Offer offer = offers.get()[0];`
src/tests/master_tests.cpp
<https://reviews.apache.org/r/30612/#comment116475>
Rephrase, please. E.g. "Specific order is not required".
src/tests/master_tests.cpp
<https://reviews.apache.org/r/30612/#comment116483>
Please use `DEFAULT_EXECUTOR_ID` instead of hard constant.
src/tests/master_tests.cpp
<https://reviews.apache.org/r/30612/#comment116476>
Let's add a message here and below via `<<` to add some verbosity.
src/tests/master_tests.cpp
<https://reviews.apache.org/r/30612/#comment116473>
Shouldn't we check the array is empty?
src/tests/master_tests.cpp
<https://reviews.apache.org/r/30612/#comment116477>
See comment above.
src/tests/master_tests.cpp
<https://reviews.apache.org/r/30612/#comment116481>
s/frameworks registered/registered frameworks/ ?
src/tests/master_tests.cpp
<https://reviews.apache.org/r/30612/#comment116482>
Ditto, misleading comment?
src/tests/master_tests.cpp
<https://reviews.apache.org/r/30612/#comment116484>
Isn't it covered in a previous test?
src/tests/master_tests.cpp
<https://reviews.apache.org/r/30612/#comment116485>
See above.
src/tests/master_tests.cpp
<https://reviews.apache.org/r/30612/#comment116486>
See my comment to the previous test.
src/tests/master_tests.cpp
<https://reviews.apache.org/r/30612/#comment116491>
Ditto.
- Alexander Rukletsov
On Feb. 4, 2015, 1:34 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30612/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 1:34 p.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
>
>
> Bugs: MESOS-2157
> https://issues.apache.org/jira/browse/MESOS-2157
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
>
> Works with [29883](https://reviews.apache.org/r/29883).
>
> Builds on the abandoned patch 14286.
>
>
> Diffs
> -----
>
> src/master/http.cpp 3981b18
> src/master/master.hpp cd37ee9
> src/master/master.cpp d04b2c4
> src/tests/master_tests.cpp 678d27f
>
> Diff: https://reviews.apache.org/r/30612/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 30612: Added
/master/frameworks/{framework}/tasks/{task} endpoint.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/#review70965
-----------------------------------------------------------
Patch looks great!
Reviews applied: [30612]
All tests passed.
- Mesos ReviewBot
On Feb. 4, 2015, 1:34 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30612/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 1:34 p.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
>
>
> Bugs: MESOS-2157
> https://issues.apache.org/jira/browse/MESOS-2157
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
>
> Works with [29883](https://reviews.apache.org/r/29883).
>
> Builds on the abandoned patch 14286.
>
>
> Diffs
> -----
>
> src/master/http.cpp 3981b18
> src/master/master.hpp cd37ee9
> src/master/master.cpp d04b2c4
> src/tests/master_tests.cpp 678d27f
>
> Diff: https://reviews.apache.org/r/30612/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 30612: Added
/master/frameworks/{framework}/tasks/{task} endpoint.
Posted by Till Toenshoff <to...@me.com>.
> On Feb. 13, 2015, 3:53 p.m., Till Toenshoff wrote:
> > Ship It!
needs rebase
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/#review72376
-----------------------------------------------------------
On Feb. 9, 2015, 4:38 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30612/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2015, 4:38 p.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
>
>
> Bugs: MESOS-2157
> https://issues.apache.org/jira/browse/MESOS-2157
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
>
> Works with [29883](https://reviews.apache.org/r/29883).
>
> Builds on the abandoned patch 14286.
>
>
> Diffs
> -----
>
> src/master/http.cpp 6d7b9f6
> src/master/master.hpp 6beeb1b
> src/master/master.cpp 7c3aa22
> src/tests/master_tests.cpp b52d2ca
>
> Diff: https://reviews.apache.org/r/30612/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 30612: Added
/master/frameworks/{framework}/tasks/{task} endpoint.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/#review72376
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Feb. 9, 2015, 4:38 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30612/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2015, 4:38 p.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
>
>
> Bugs: MESOS-2157
> https://issues.apache.org/jira/browse/MESOS-2157
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
>
> Works with [29883](https://reviews.apache.org/r/29883).
>
> Builds on the abandoned patch 14286.
>
>
> Diffs
> -----
>
> src/master/http.cpp 6d7b9f6
> src/master/master.hpp 6beeb1b
> src/master/master.cpp 7c3aa22
> src/tests/master_tests.cpp b52d2ca
>
> Diff: https://reviews.apache.org/r/30612/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 30612: Added
/master/frameworks/{framework}/tasks/{task} endpoint.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/#review71642
-----------------------------------------------------------
Patch looks great!
Reviews applied: [30612]
All tests passed.
- Mesos ReviewBot
On Feb. 9, 2015, 4:38 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30612/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2015, 4:38 p.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
>
>
> Bugs: MESOS-2157
> https://issues.apache.org/jira/browse/MESOS-2157
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
>
> Works with [29883](https://reviews.apache.org/r/29883).
>
> Builds on the abandoned patch 14286.
>
>
> Diffs
> -----
>
> src/master/http.cpp 6d7b9f6
> src/master/master.hpp 6beeb1b
> src/master/master.cpp 7c3aa22
> src/tests/master_tests.cpp b52d2ca
>
> Diff: https://reviews.apache.org/r/30612/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 30612: Added
/master/frameworks/{framework}/tasks/{task} endpoint.
Posted by Alexander Rojas <al...@mesosphere.io>.
> On Feb. 14, 2015, 12:47 a.m., Ben Mahler wrote:
> > I only took a quick glance, so apologies in advance if I'm missing something. Is it possible to consolidate the tests (perhaps you can make several requests inside the same test?). 1000 lines of test code seems like a big maintenance burden. :)
So, at the end I implemented a test fixture in order to reduce the size of the tests. At the end, half of the code was initialization and destruction of the environment.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/#review72453
-----------------------------------------------------------
On Feb. 16, 2015, 3:49 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30612/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2015, 3:49 p.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
>
>
> Bugs: MESOS-2157
> https://issues.apache.org/jira/browse/MESOS-2157
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
>
> Works with [29883](https://reviews.apache.org/r/29883).
>
> Builds on the abandoned patch 14286.
>
>
> Diffs
> -----
>
> src/master/http.cpp 5e3afdf
> src/master/master.hpp 6a39df0
> src/master/master.cpp f10a3cf
> src/tests/master_tests.cpp e69a7fb
>
> Diff: https://reviews.apache.org/r/30612/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 30612: Added
/master/frameworks/{framework}/tasks/{task} endpoint.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/#review72453
-----------------------------------------------------------
I only took a quick glance, so apologies in advance if I'm missing something. Is it possible to consolidate the tests (perhaps you can make several requests inside the same test?). 1000 lines of test code seems like a big maintenance burden. :)
- Ben Mahler
On Feb. 13, 2015, 4:42 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30612/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2015, 4:42 p.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
>
>
> Bugs: MESOS-2157
> https://issues.apache.org/jira/browse/MESOS-2157
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
>
> Works with [29883](https://reviews.apache.org/r/29883).
>
> Builds on the abandoned patch 14286.
>
>
> Diffs
> -----
>
> src/master/http.cpp 5e3afdf
> src/master/master.hpp 6a39df0
> src/master/master.cpp f10a3cf
> src/tests/master_tests.cpp e69a7fb
>
> Diff: https://reviews.apache.org/r/30612/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 30612: Added
/master/frameworks/{framework}/tasks/{task} endpoint.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/#review76906
-----------------------------------------------------------
Patch looks great!
Reviews applied: [32198, 32163, 30612]
All tests passed.
- Mesos ReviewBot
On March 18, 2015, 4:37 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30612/
> -----------------------------------------------------------
>
> (Updated March 18, 2015, 4:37 p.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
>
>
> Bugs: MESOS-2157
> https://issues.apache.org/jira/browse/MESOS-2157
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
>
> Works with [29883](https://reviews.apache.org/r/29883).
>
> Builds on the abandoned patch 14286.
>
>
> Diffs
> -----
>
> src/master/http.cpp e1a87d646e9690e39a9e84ae383622018ce80401
> src/master/master.hpp 3c957abcb54a0c23b8549c1d21d2d9277791938d
> src/master/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1
> src/tests/master_tests.cpp e69348be676a80017062e3abbd15b8008a6009d7
>
> Diff: https://reviews.apache.org/r/30612/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 30612: Added
/master/frameworks/{framework}/tasks/{task} endpoint.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/#review77404
-----------------------------------------------------------
Patch looks great!
Reviews applied: [32198, 32163, 30612]
All tests passed.
- Mesos ReviewBot
On March 23, 2015, 2:21 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30612/
> -----------------------------------------------------------
>
> (Updated March 23, 2015, 2:21 p.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
>
>
> Bugs: MESOS-2157
> https://issues.apache.org/jira/browse/MESOS-2157
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
>
> Works with [29883](https://reviews.apache.org/r/29883).
>
> Builds on the abandoned patch 14286.
>
>
> Diffs
> -----
>
> src/master/http.cpp e1a87d646e9690e39a9e84ae383622018ce80401
> src/master/master.hpp 3c957abcb54a0c23b8549c1d21d2d9277791938d
> src/master/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1
> src/tests/master_tests.cpp e69348be676a80017062e3abbd15b8008a6009d7
>
> Diff: https://reviews.apache.org/r/30612/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 30612: Added
/master/frameworks/{framework}/tasks/{task} endpoint.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/
-----------------------------------------------------------
(Updated March 25, 2015, 2:06 p.m.)
Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
Bugs: MESOS-2157
https://issues.apache.org/jira/browse/MESOS-2157
Repository: mesos
Description (updated)
-------
Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
Adds tests for the endpoints.
Works with [29883](https://reviews.apache.org/r/29883).
Builds on the abandoned patch 14286.
Diffs
-----
src/master/http.cpp e1a87d646e9690e39a9e84ae383622018ce80401
src/master/master.hpp 3c957abcb54a0c23b8549c1d21d2d9277791938d
src/master/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1
src/tests/master_tests.cpp e69348be676a80017062e3abbd15b8008a6009d7
Diff: https://reviews.apache.org/r/30612/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 30612: Added
/master/frameworks/{framework}/tasks/{task} endpoint.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/
-----------------------------------------------------------
(Updated March 23, 2015, 3:21 p.m.)
Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
Changes
-------
Updates tests to reflex changes on the parent patch.
Bugs: MESOS-2157
https://issues.apache.org/jira/browse/MESOS-2157
Repository: mesos
Description
-------
Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
Works with [29883](https://reviews.apache.org/r/29883).
Builds on the abandoned patch 14286.
Diffs (updated)
-----
src/master/http.cpp e1a87d646e9690e39a9e84ae383622018ce80401
src/master/master.hpp 3c957abcb54a0c23b8549c1d21d2d9277791938d
src/master/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1
src/tests/master_tests.cpp e69348be676a80017062e3abbd15b8008a6009d7
Diff: https://reviews.apache.org/r/30612/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 30612: Added
/master/frameworks/{framework}/tasks/{task} endpoint.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/
-----------------------------------------------------------
(Updated March 18, 2015, 5:37 p.m.)
Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
Changes
-------
Updates tests using the json::contains function which improves readability.
Bugs: MESOS-2157
https://issues.apache.org/jira/browse/MESOS-2157
Repository: mesos
Description
-------
Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
Works with [29883](https://reviews.apache.org/r/29883).
Builds on the abandoned patch 14286.
Diffs (updated)
-----
src/master/http.cpp e1a87d646e9690e39a9e84ae383622018ce80401
src/master/master.hpp 3c957abcb54a0c23b8549c1d21d2d9277791938d
src/master/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1
src/tests/master_tests.cpp e69348be676a80017062e3abbd15b8008a6009d7
Diff: https://reviews.apache.org/r/30612/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 30612: Added
/master/frameworks/{framework}/tasks/{task} endpoint.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/#review76246
-----------------------------------------------------------
src/master/http.cpp
<https://reviews.apache.org/r/30612/#comment123757>
Breakline.
- Alexander Rojas
On March 4, 2015, 2:39 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30612/
> -----------------------------------------------------------
>
> (Updated March 4, 2015, 2:39 p.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
>
>
> Bugs: MESOS-2157
> https://issues.apache.org/jira/browse/MESOS-2157
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
>
> Works with [29883](https://reviews.apache.org/r/29883).
>
> Builds on the abandoned patch 14286.
>
>
> Diffs
> -----
>
> src/master/http.cpp b8eef69505b147d4c8a0e005dff545b9fc12a220
> src/master/master.hpp 3c957abcb54a0c23b8549c1d21d2d9277791938d
> src/master/master.cpp 68ca19a9ae680e3ae5bd433a9842baf69f2360ec
> src/tests/master_tests.cpp 580e1f818201f951c11e4e652a7941fcd888356d
>
> Diff: https://reviews.apache.org/r/30612/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 30612: Added
/master/frameworks/{framework}/tasks/{task} endpoint.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/#review75233
-----------------------------------------------------------
Patch looks great!
Reviews applied: [30612]
All tests passed.
- Mesos ReviewBot
On March 4, 2015, 1:39 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30612/
> -----------------------------------------------------------
>
> (Updated March 4, 2015, 1:39 p.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
>
>
> Bugs: MESOS-2157
> https://issues.apache.org/jira/browse/MESOS-2157
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
>
> Works with [29883](https://reviews.apache.org/r/29883).
>
> Builds on the abandoned patch 14286.
>
>
> Diffs
> -----
>
> src/master/http.cpp b8eef69505b147d4c8a0e005dff545b9fc12a220
> src/master/master.hpp 3c957abcb54a0c23b8549c1d21d2d9277791938d
> src/master/master.cpp 68ca19a9ae680e3ae5bd433a9842baf69f2360ec
> src/tests/master_tests.cpp 580e1f818201f951c11e4e652a7941fcd888356d
>
> Diff: https://reviews.apache.org/r/30612/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 30612: Added
/master/frameworks/{framework}/tasks/{task} endpoint.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/
-----------------------------------------------------------
(Updated March 4, 2015, 2:39 p.m.)
Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
Changes
-------
Fixes style issues.
Bugs: MESOS-2157
https://issues.apache.org/jira/browse/MESOS-2157
Repository: mesos
Description
-------
Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
Works with [29883](https://reviews.apache.org/r/29883).
Builds on the abandoned patch 14286.
Diffs (updated)
-----
src/master/http.cpp b8eef69505b147d4c8a0e005dff545b9fc12a220
src/master/master.hpp 3c957abcb54a0c23b8549c1d21d2d9277791938d
src/master/master.cpp 68ca19a9ae680e3ae5bd433a9842baf69f2360ec
src/tests/master_tests.cpp 580e1f818201f951c11e4e652a7941fcd888356d
Diff: https://reviews.apache.org/r/30612/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 30612: Added
/master/frameworks/{framework}/tasks/{task} endpoint.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/
-----------------------------------------------------------
(Updated March 4, 2015, 2:31 p.m.)
Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
Changes
-------
Fixed style issues.
Adds comments to the code.
Rewrites documentation for the `frameworks` endpoint.
Bugs: MESOS-2157
https://issues.apache.org/jira/browse/MESOS-2157
Repository: mesos
Description
-------
Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
Works with [29883](https://reviews.apache.org/r/29883).
Builds on the abandoned patch 14286.
Diffs (updated)
-----
src/master/http.cpp b8eef69505b147d4c8a0e005dff545b9fc12a220
src/master/master.hpp 3c957abcb54a0c23b8549c1d21d2d9277791938d
src/master/master.cpp 68ca19a9ae680e3ae5bd433a9842baf69f2360ec
src/tests/master_tests.cpp 580e1f818201f951c11e4e652a7941fcd888356d
Diff: https://reviews.apache.org/r/30612/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 30612: Added
/master/frameworks/{framework}/tasks/{task} endpoint.
Posted by Alexander Rojas <al...@mesosphere.io>.
> On March 3, 2015, 8:06 p.m., Niklas Nielsen wrote:
> > src/master/http.cpp, line 269
> > <https://reviews.apache.org/r/30612/diff/7/?file=864944#file864944line269>
> >
> > 'only de destription' s/de/the/?
Dropping because I changed the string completely, so it is no longer relevant.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/#review72835
-----------------------------------------------------------
On March 4, 2015, 2:31 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30612/
> -----------------------------------------------------------
>
> (Updated March 4, 2015, 2:31 p.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
>
>
> Bugs: MESOS-2157
> https://issues.apache.org/jira/browse/MESOS-2157
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
>
> Works with [29883](https://reviews.apache.org/r/29883).
>
> Builds on the abandoned patch 14286.
>
>
> Diffs
> -----
>
> src/master/http.cpp b8eef69505b147d4c8a0e005dff545b9fc12a220
> src/master/master.hpp 3c957abcb54a0c23b8549c1d21d2d9277791938d
> src/master/master.cpp 68ca19a9ae680e3ae5bd433a9842baf69f2360ec
> src/tests/master_tests.cpp 580e1f818201f951c11e4e652a7941fcd888356d
>
> Diff: https://reviews.apache.org/r/30612/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 30612: Added
/master/frameworks/{framework}/tasks/{task} endpoint.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/#review72835
-----------------------------------------------------------
src/master/http.cpp
<https://reviews.apache.org/r/30612/#comment118943>
This fits on one line and you need to bring the '{' down on it's own line. Here and below.
src/master/http.cpp
<https://reviews.apache.org/r/30612/#comment121934>
This fits on a single line
src/master/http.cpp
<https://reviews.apache.org/r/30612/#comment120953>
'{' on newline.
src/master/http.cpp
<https://reviews.apache.org/r/30612/#comment120957>
Think we can be a bit more concise. How about using a table?
Request Result
/master/frameworks List of all active frameworks
/master/frameworks/{id}List of all tasks
And so on.
src/master/http.cpp
<https://reviews.apache.org/r/30612/#comment120954>
'..related to the registered frameworks the assigned tasks...' Not completely sure I understand that sentence. Can you rework it a little bit? :)
src/master/http.cpp
<https://reviews.apache.org/r/30612/#comment120955>
Which endpoints?
src/master/http.cpp
<https://reviews.apache.org/r/30612/#comment120956>
'only de destription' s/de/the/?
src/master/http.cpp
<https://reviews.apache.org/r/30612/#comment120958>
s/words/tokens/
src/master/http.cpp
<https://reviews.apache.org/r/30612/#comment120962>
Mind throwing in a comment on the three different scenarios and how it translates to your code?
src/tests/master_tests.cpp
<https://reviews.apache.org/r/30612/#comment118948>
Needs to be 4 indent for argument wrapping
- Niklas Nielsen
On Feb. 16, 2015, 6:49 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30612/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2015, 6:49 a.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
>
>
> Bugs: MESOS-2157
> https://issues.apache.org/jira/browse/MESOS-2157
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
>
> Works with [29883](https://reviews.apache.org/r/29883).
>
> Builds on the abandoned patch 14286.
>
>
> Diffs
> -----
>
> src/master/http.cpp 5e3afdf
> src/master/master.hpp 6a39df0
> src/master/master.cpp f10a3cf
> src/tests/master_tests.cpp e69a7fb
>
> Diff: https://reviews.apache.org/r/30612/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 30612: Added
/master/frameworks/{framework}/tasks/{task} endpoint.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/#review72652
-----------------------------------------------------------
Patch looks great!
Reviews applied: [30612]
All tests passed.
- Mesos ReviewBot
On Feb. 16, 2015, 2:49 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30612/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2015, 2:49 p.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
>
>
> Bugs: MESOS-2157
> https://issues.apache.org/jira/browse/MESOS-2157
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
>
> Works with [29883](https://reviews.apache.org/r/29883).
>
> Builds on the abandoned patch 14286.
>
>
> Diffs
> -----
>
> src/master/http.cpp 5e3afdf
> src/master/master.hpp 6a39df0
> src/master/master.cpp f10a3cf
> src/tests/master_tests.cpp e69a7fb
>
> Diff: https://reviews.apache.org/r/30612/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 30612: Added
/master/frameworks/{framework}/tasks/{task} endpoint.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/
-----------------------------------------------------------
(Updated Feb. 16, 2015, 3:49 p.m.)
Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
Changes
-------
Uses a test fixture for the set up and tear down of the cluster on the tests; halving the size of the tests code.
Bugs: MESOS-2157
https://issues.apache.org/jira/browse/MESOS-2157
Repository: mesos
Description
-------
Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
Works with [29883](https://reviews.apache.org/r/29883).
Builds on the abandoned patch 14286.
Diffs (updated)
-----
src/master/http.cpp 5e3afdf
src/master/master.hpp 6a39df0
src/master/master.cpp f10a3cf
src/tests/master_tests.cpp e69a7fb
Diff: https://reviews.apache.org/r/30612/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 30612: Added
/master/frameworks/{framework}/tasks/{task} endpoint.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/#review72501
-----------------------------------------------------------
Patch looks great!
Reviews applied: [30612]
All tests passed.
- Mesos ReviewBot
On Feb. 13, 2015, 4:42 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30612/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2015, 4:42 p.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
>
>
> Bugs: MESOS-2157
> https://issues.apache.org/jira/browse/MESOS-2157
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
>
> Works with [29883](https://reviews.apache.org/r/29883).
>
> Builds on the abandoned patch 14286.
>
>
> Diffs
> -----
>
> src/master/http.cpp 5e3afdf
> src/master/master.hpp 6a39df0
> src/master/master.cpp f10a3cf
> src/tests/master_tests.cpp e69a7fb
>
> Diff: https://reviews.apache.org/r/30612/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 30612: Added
/master/frameworks/{framework}/tasks/{task} endpoint.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/
-----------------------------------------------------------
(Updated Feb. 13, 2015, 5:42 p.m.)
Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
Changes
-------
Rebased to current head.
Bugs: MESOS-2157
https://issues.apache.org/jira/browse/MESOS-2157
Repository: mesos
Description
-------
Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
Works with [29883](https://reviews.apache.org/r/29883).
Builds on the abandoned patch 14286.
Diffs (updated)
-----
src/master/http.cpp 5e3afdf
src/master/master.hpp 6a39df0
src/master/master.cpp f10a3cf
src/tests/master_tests.cpp e69a7fb
Diff: https://reviews.apache.org/r/30612/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 30612: Added
/master/frameworks/{framework}/tasks/{task} endpoint.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/
-----------------------------------------------------------
(Updated Feb. 9, 2015, 5:38 p.m.)
Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
Changes
-------
Till's comments.
Bugs: MESOS-2157
https://issues.apache.org/jira/browse/MESOS-2157
Repository: mesos
Description
-------
Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
Works with [29883](https://reviews.apache.org/r/29883).
Builds on the abandoned patch 14286.
Diffs (updated)
-----
src/master/http.cpp 6d7b9f6
src/master/master.hpp 6beeb1b
src/master/master.cpp 7c3aa22
src/tests/master_tests.cpp b52d2ca
Diff: https://reviews.apache.org/r/30612/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 30612: Added
/master/frameworks/{framework}/tasks/{task} endpoint.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/#review71636
-----------------------------------------------------------
Ship it!
src/master/http.cpp
<https://reviews.apache.org/r/30612/#comment117497>
Maybe we should slightly reword this one to point out that the '/' is the separator. It was not clear to me when I read it first.
// Creates a map where the keys are the slash separated pattern entries and the values...
src/master/http.cpp
<https://reviews.apache.org/r/30612/#comment117499>
Add blank line to make it consistent with the above case.
src/tests/master_tests.cpp
<https://reviews.apache.org/r/30612/#comment117500>
I think that '/' can be killed, not?
src/tests/master_tests.cpp
<https://reviews.apache.org/r/30612/#comment117501>
We are adding two tasks, why not saying that in the comment?
src/tests/master_tests.cpp
<https://reviews.apache.org/r/30612/#comment117502>
// Add two tasks to framework1.
?
src/tests/master_tests.cpp
<https://reviews.apache.org/r/30612/#comment117503>
// ... "two tasks" ...
src/tests/master_tests.cpp
<https://reviews.apache.org/r/30612/#comment117504>
s/asigned/assigned/g
src/tests/master_tests.cpp
<https://reviews.apache.org/r/30612/#comment117505>
// ... "two tasks" ... ?
src/tests/master_tests.cpp
<https://reviews.apache.org/r/30612/#comment117506>
Kill this line.
- Till Toenshoff
On Feb. 5, 2015, 12:54 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30612/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2015, 12:54 a.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
>
>
> Bugs: MESOS-2157
> https://issues.apache.org/jira/browse/MESOS-2157
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
>
> Works with [29883](https://reviews.apache.org/r/29883).
>
> Builds on the abandoned patch 14286.
>
>
> Diffs
> -----
>
> src/master/http.cpp 3981b18
> src/master/master.hpp cd37ee9
> src/master/master.cpp d04b2c4
> src/tests/master_tests.cpp 678d27f
>
> Diff: https://reviews.apache.org/r/30612/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 30612: Added
/master/frameworks/{framework}/tasks/{task} endpoint.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/#review71139
-----------------------------------------------------------
Patch looks great!
Reviews applied: [30612]
All tests passed.
- Mesos ReviewBot
On Feb. 5, 2015, 12:54 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30612/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2015, 12:54 a.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
>
>
> Bugs: MESOS-2157
> https://issues.apache.org/jira/browse/MESOS-2157
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
>
> Works with [29883](https://reviews.apache.org/r/29883).
>
> Builds on the abandoned patch 14286.
>
>
> Diffs
> -----
>
> src/master/http.cpp 3981b18
> src/master/master.hpp cd37ee9
> src/master/master.cpp d04b2c4
> src/tests/master_tests.cpp 678d27f
>
> Diff: https://reviews.apache.org/r/30612/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 30612: Added
/master/frameworks/{framework}/tasks/{task} endpoint.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/
-----------------------------------------------------------
(Updated Feb. 5, 2015, 1:54 a.m.)
Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
Changes
-------
Fixes comparison when checking for executor id, whic caused a compilation error.
Bugs: MESOS-2157
https://issues.apache.org/jira/browse/MESOS-2157
Repository: mesos
Description
-------
Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
Works with [29883](https://reviews.apache.org/r/29883).
Builds on the abandoned patch 14286.
Diffs (updated)
-----
src/master/http.cpp 3981b18
src/master/master.hpp cd37ee9
src/master/master.cpp d04b2c4
src/tests/master_tests.cpp 678d27f
Diff: https://reviews.apache.org/r/30612/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 30612: Added
/master/frameworks/{framework}/tasks/{task} endpoint.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/
-----------------------------------------------------------
(Updated Feb. 5, 2015, 12:52 a.m.)
Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
Changes
-------
Update based on Alex's comment.s
Bugs: MESOS-2157
https://issues.apache.org/jira/browse/MESOS-2157
Repository: mesos
Description
-------
Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
Works with [29883](https://reviews.apache.org/r/29883).
Builds on the abandoned patch 14286.
Diffs (updated)
-----
src/master/http.cpp 3981b18
src/master/master.hpp cd37ee9
src/master/master.cpp d04b2c4
src/tests/master_tests.cpp 678d27f
Diff: https://reviews.apache.org/r/30612/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 30612: Added
/master/frameworks/{framework}/tasks/{task} endpoint.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/
-----------------------------------------------------------
(Updated Feb. 4, 2015, 2:34 p.m.)
Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
Changes
-------
Original diff contained tests for slaves endpoint which are not part of this patch.
Bugs: MESOS-2157
https://issues.apache.org/jira/browse/MESOS-2157
Repository: mesos
Description
-------
Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
Works with [29883](https://reviews.apache.org/r/29883).
Builds on the abandoned patch 14286.
Diffs (updated)
-----
src/master/http.cpp 3981b18
src/master/master.hpp cd37ee9
src/master/master.cpp d04b2c4
src/tests/master_tests.cpp 678d27f
Diff: https://reviews.apache.org/r/30612/diff/
Testing
-------
make check
Thanks,
Alexander Rojas