You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Binglin Chang (JIRA)" <ji...@apache.org> on 2012/10/26 07:55:12 UTC
[jira] [Created] (HADOOP-8985) Add namespace declarations in .proto
files for other languages
Binglin Chang created HADOOP-8985:
-------------------------------------
Summary: Add namespace declarations in .proto files for other languages
Key: HADOOP-8985
URL: https://issues.apache.org/jira/browse/HADOOP-8985
Project: Hadoop Common
Issue Type: Improvement
Reporter: Binglin Chang
Priority: Minor
Currently .proto files use java_package to specify java packages in proto files, but namespace are not specified for other languages such as C++, this causes name collision in C++. we can add namespace declarations to avoid this.
In Java, the package specifier is used as the Java package, unless you explicitly provide a option java_package in your .proto file. So the original java package will not be affected.
About namespace name, how about "hadoop.common"(hadoop::common in C++) for all common sub-project proto files, and "hadoop.hdfs"(hadoop::hdfs in C++) for all hdfs sub-project proto files?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8985) Add namespace declarations in
.proto files for languages other than java
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485474#comment-13485474 ]
Hadoop QA commented on HADOOP-8985:
-----------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12551082/HADOOP-8985-add-namespace.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1680//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1680//console
This message is automatically generated.
> Add namespace declarations in .proto files for languages other than java
> ------------------------------------------------------------------------
>
> Key: HADOOP-8985
> URL: https://issues.apache.org/jira/browse/HADOOP-8985
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Binglin Chang
> Assignee: Binglin Chang
> Priority: Minor
> Attachments: HADOOP-8985-add-namespace.patch
>
>
> Currently .proto files use java_package to specify java packages in proto files, but namespace are not specified for other languages such as cpp, this causes name collision in cpp. we can add namespace declarations to avoid this.
> In Java, the package specifier is used as the Java package, unless you explicitly provide a option java_package in your .proto file. So the original java package will not be affected.
> About namespace name, how about "hadoop.common"(hadoop::common in cpp) for all common sub-project proto files, and "hadoop.hdfs"(hadoop::hdfs in cpp) for all hdfs sub-project proto files?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8985) Add namespace declarations in .proto
files for languages other than java
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-8985:
------------------------------------
Component/s: ipc
ha
Affects Version/s: 2.0.2-alpha
> Add namespace declarations in .proto files for languages other than java
> ------------------------------------------------------------------------
>
> Key: HADOOP-8985
> URL: https://issues.apache.org/jira/browse/HADOOP-8985
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ha, ipc
> Affects Versions: 2.0.2-alpha
> Reporter: Binglin Chang
> Assignee: Binglin Chang
> Priority: Minor
> Fix For: 3.0.0, 2.0.3-alpha
>
> Attachments: HADOOP-8985-add-namespace.patch
>
>
> Currently .proto files use java_package to specify java packages in proto files, but namespace are not specified for other languages such as cpp, this causes name collision in cpp. we can add namespace declarations to avoid this.
> In Java, the package specifier is used as the Java package, unless you explicitly provide a option java_package in your .proto file. So the original java package will not be affected.
> About namespace name, how about "hadoop.common"(hadoop::common in cpp) for all common sub-project proto files, and "hadoop.hdfs"(hadoop::hdfs in cpp) for all hdfs sub-project proto files?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8985) Add namespace declarations in
.proto files for languages other than java
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485484#comment-13485484 ]
Hudson commented on HADOOP-8985:
--------------------------------
Integrated in Hadoop-trunk-Commit #2934 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/2934/])
HADOOP-8985. Add namespace declarations in .proto files for languages other than java. Thank you Binglin Chan. (Revision 1402845)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1402845
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/HAServiceProtocol.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/IpcConnectionContext.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/ProtocolInfo.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/RpcPayloadHeader.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/ZKFCProtocol.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto
> Add namespace declarations in .proto files for languages other than java
> ------------------------------------------------------------------------
>
> Key: HADOOP-8985
> URL: https://issues.apache.org/jira/browse/HADOOP-8985
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ha, ipc
> Affects Versions: 2.0.2-alpha
> Reporter: Binglin Chang
> Assignee: Binglin Chang
> Priority: Minor
> Fix For: 3.0.0, 2.0.3-alpha
>
> Attachments: HADOOP-8985-add-namespace.patch
>
>
> Currently .proto files use java_package to specify java packages in proto files, but namespace are not specified for other languages such as cpp, this causes name collision in cpp. we can add namespace declarations to avoid this.
> In Java, the package specifier is used as the Java package, unless you explicitly provide a option java_package in your .proto file. So the original java package will not be affected.
> About namespace name, how about "hadoop.common"(hadoop::common in cpp) for all common sub-project proto files, and "hadoop.hdfs"(hadoop::hdfs in cpp) for all hdfs sub-project proto files?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8985) Add namespace declarations in .proto
files for languages other than java
Posted by "Binglin Chang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Binglin Chang updated HADOOP-8985:
----------------------------------
Assignee: Binglin Chang
Status: Patch Available (was: Open)
> Add namespace declarations in .proto files for languages other than java
> ------------------------------------------------------------------------
>
> Key: HADOOP-8985
> URL: https://issues.apache.org/jira/browse/HADOOP-8985
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Binglin Chang
> Assignee: Binglin Chang
> Priority: Minor
>
> Currently .proto files use java_package to specify java packages in proto files, but namespace are not specified for other languages such as cpp, this causes name collision in cpp. we can add namespace declarations to avoid this.
> In Java, the package specifier is used as the Java package, unless you explicitly provide a option java_package in your .proto file. So the original java package will not be affected.
> About namespace name, how about "hadoop.common"(hadoop::common in cpp) for all common sub-project proto files, and "hadoop.hdfs"(hadoop::hdfs in cpp) for all hdfs sub-project proto files?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8985) Add namespace declarations in
.proto files for languages other than java
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485599#comment-13485599 ]
Hudson commented on HADOOP-8985:
--------------------------------
Integrated in Hadoop-Yarn-trunk #19 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/19/])
HADOOP-8985. Add namespace declarations in .proto files for languages other than java. Thank you Binglin Chan. (Revision 1402845)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1402845
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/HAServiceProtocol.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/IpcConnectionContext.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/ProtocolInfo.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/RpcPayloadHeader.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/ZKFCProtocol.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto
> Add namespace declarations in .proto files for languages other than java
> ------------------------------------------------------------------------
>
> Key: HADOOP-8985
> URL: https://issues.apache.org/jira/browse/HADOOP-8985
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ha, ipc
> Affects Versions: 2.0.2-alpha
> Reporter: Binglin Chang
> Assignee: Binglin Chang
> Priority: Minor
> Fix For: 3.0.0, 2.0.3-alpha
>
> Attachments: HADOOP-8985-add-namespace.patch
>
>
> Currently .proto files use java_package to specify java packages in proto files, but namespace are not specified for other languages such as cpp, this causes name collision in cpp. we can add namespace declarations to avoid this.
> In Java, the package specifier is used as the Java package, unless you explicitly provide a option java_package in your .proto file. So the original java package will not be affected.
> About namespace name, how about "hadoop.common"(hadoop::common in cpp) for all common sub-project proto files, and "hadoop.hdfs"(hadoop::hdfs in cpp) for all hdfs sub-project proto files?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8985) Add namespace declarations in
.proto files for languages other than java
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485625#comment-13485625 ]
Hudson commented on HADOOP-8985:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #1239 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1239/])
HADOOP-8985. Add namespace declarations in .proto files for languages other than java. Thank you Binglin Chan. (Revision 1402845)
Result = FAILURE
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1402845
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/HAServiceProtocol.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/IpcConnectionContext.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/ProtocolInfo.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/RpcPayloadHeader.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/ZKFCProtocol.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto
> Add namespace declarations in .proto files for languages other than java
> ------------------------------------------------------------------------
>
> Key: HADOOP-8985
> URL: https://issues.apache.org/jira/browse/HADOOP-8985
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ha, ipc
> Affects Versions: 2.0.2-alpha
> Reporter: Binglin Chang
> Assignee: Binglin Chang
> Priority: Minor
> Fix For: 3.0.0, 2.0.3-alpha
>
> Attachments: HADOOP-8985-add-namespace.patch
>
>
> Currently .proto files use java_package to specify java packages in proto files, but namespace are not specified for other languages such as cpp, this causes name collision in cpp. we can add namespace declarations to avoid this.
> In Java, the package specifier is used as the Java package, unless you explicitly provide a option java_package in your .proto file. So the original java package will not be affected.
> About namespace name, how about "hadoop.common"(hadoop::common in cpp) for all common sub-project proto files, and "hadoop.hdfs"(hadoop::hdfs in cpp) for all hdfs sub-project proto files?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8985) Add namespace declarations in .proto
files for languages other than java
Posted by "Binglin Chang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Binglin Chang updated HADOOP-8985:
----------------------------------
Attachment: HADOOP-8985-add-namespace.patch
> Add namespace declarations in .proto files for languages other than java
> ------------------------------------------------------------------------
>
> Key: HADOOP-8985
> URL: https://issues.apache.org/jira/browse/HADOOP-8985
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Binglin Chang
> Assignee: Binglin Chang
> Priority: Minor
> Attachments: HADOOP-8985-add-namespace.patch
>
>
> Currently .proto files use java_package to specify java packages in proto files, but namespace are not specified for other languages such as cpp, this causes name collision in cpp. we can add namespace declarations to avoid this.
> In Java, the package specifier is used as the Java package, unless you explicitly provide a option java_package in your .proto file. So the original java package will not be affected.
> About namespace name, how about "hadoop.common"(hadoop::common in cpp) for all common sub-project proto files, and "hadoop.hdfs"(hadoop::hdfs in cpp) for all hdfs sub-project proto files?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8985) Add namespace declarations in .proto
files for languages other than java
Posted by "Binglin Chang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Binglin Chang updated HADOOP-8985:
----------------------------------
Description:
Currently .proto files use java_package to specify java packages in proto files, but namespace are not specified for other languages such as cpp, this causes name collision in cpp. we can add namespace declarations to avoid this.
In Java, the package specifier is used as the Java package, unless you explicitly provide a option java_package in your .proto file. So the original java package will not be affected.
About namespace name, how about "hadoop.common"(hadoop::common in cpp) for all common sub-project proto files, and "hadoop.hdfs"(hadoop::hdfs in cpp) for all hdfs sub-project proto files?
was:
Currently .proto files use java_package to specify java packages in proto files, but namespace are not specified for other languages such as C++, this causes name collision in C++. we can add namespace declarations to avoid this.
In Java, the package specifier is used as the Java package, unless you explicitly provide a option java_package in your .proto file. So the original java package will not be affected.
About namespace name, how about "hadoop.common"(hadoop::common in C++) for all common sub-project proto files, and "hadoop.hdfs"(hadoop::hdfs in C++) for all hdfs sub-project proto files?
Summary: Add namespace declarations in .proto files for languages other than java (was: Add namespace declarations in .proto files for other languages)
> Add namespace declarations in .proto files for languages other than java
> ------------------------------------------------------------------------
>
> Key: HADOOP-8985
> URL: https://issues.apache.org/jira/browse/HADOOP-8985
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Binglin Chang
> Priority: Minor
>
> Currently .proto files use java_package to specify java packages in proto files, but namespace are not specified for other languages such as cpp, this causes name collision in cpp. we can add namespace declarations to avoid this.
> In Java, the package specifier is used as the Java package, unless you explicitly provide a option java_package in your .proto file. So the original java package will not be affected.
> About namespace name, how about "hadoop.common"(hadoop::common in cpp) for all common sub-project proto files, and "hadoop.hdfs"(hadoop::hdfs in cpp) for all hdfs sub-project proto files?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8985) Add namespace declarations in
.proto files for languages other than java
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485312#comment-13485312 ]
Suresh Srinivas commented on HADOOP-8985:
-----------------------------------------
Please create a separate jira for HDFS. Lets do the hadoop-common-project ones in this.
> Add namespace declarations in .proto files for languages other than java
> ------------------------------------------------------------------------
>
> Key: HADOOP-8985
> URL: https://issues.apache.org/jira/browse/HADOOP-8985
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Binglin Chang
> Priority: Minor
>
> Currently .proto files use java_package to specify java packages in proto files, but namespace are not specified for other languages such as cpp, this causes name collision in cpp. we can add namespace declarations to avoid this.
> In Java, the package specifier is used as the Java package, unless you explicitly provide a option java_package in your .proto file. So the original java package will not be affected.
> About namespace name, how about "hadoop.common"(hadoop::common in cpp) for all common sub-project proto files, and "hadoop.hdfs"(hadoop::hdfs in cpp) for all hdfs sub-project proto files?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8985) Add namespace declarations in .proto
files for languages other than java
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-8985:
------------------------------------
Resolution: Fixed
Fix Version/s: 2.0.3-alpha
3.0.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
+1 for the patch. I committed it to trunk and branch-2.
Thank you Binglin.
> Add namespace declarations in .proto files for languages other than java
> ------------------------------------------------------------------------
>
> Key: HADOOP-8985
> URL: https://issues.apache.org/jira/browse/HADOOP-8985
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Binglin Chang
> Assignee: Binglin Chang
> Priority: Minor
> Fix For: 3.0.0, 2.0.3-alpha
>
> Attachments: HADOOP-8985-add-namespace.patch
>
>
> Currently .proto files use java_package to specify java packages in proto files, but namespace are not specified for other languages such as cpp, this causes name collision in cpp. we can add namespace declarations to avoid this.
> In Java, the package specifier is used as the Java package, unless you explicitly provide a option java_package in your .proto file. So the original java package will not be affected.
> About namespace name, how about "hadoop.common"(hadoop::common in cpp) for all common sub-project proto files, and "hadoop.hdfs"(hadoop::hdfs in cpp) for all hdfs sub-project proto files?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8985) Add namespace declarations in
.proto files for languages other than java
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485621#comment-13485621 ]
Hudson commented on HADOOP-8985:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #1209 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1209/])
HADOOP-8985. Add namespace declarations in .proto files for languages other than java. Thank you Binglin Chan. (Revision 1402845)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1402845
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/HAServiceProtocol.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/IpcConnectionContext.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/ProtocolInfo.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/RpcPayloadHeader.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/ZKFCProtocol.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto
> Add namespace declarations in .proto files for languages other than java
> ------------------------------------------------------------------------
>
> Key: HADOOP-8985
> URL: https://issues.apache.org/jira/browse/HADOOP-8985
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ha, ipc
> Affects Versions: 2.0.2-alpha
> Reporter: Binglin Chang
> Assignee: Binglin Chang
> Priority: Minor
> Fix For: 3.0.0, 2.0.3-alpha
>
> Attachments: HADOOP-8985-add-namespace.patch
>
>
> Currently .proto files use java_package to specify java packages in proto files, but namespace are not specified for other languages such as cpp, this causes name collision in cpp. we can add namespace declarations to avoid this.
> In Java, the package specifier is used as the Java package, unless you explicitly provide a option java_package in your .proto file. So the original java package will not be affected.
> About namespace name, how about "hadoop.common"(hadoop::common in cpp) for all common sub-project proto files, and "hadoop.hdfs"(hadoop::hdfs in cpp) for all hdfs sub-project proto files?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira