You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2022/05/29 19:19:33 UTC

[GitHub] [calcite] dssysolyatin commented on a diff in pull request #2819: [CALCITE-5159] Postgres dialect should support implicit cast from string literal to array literal

dssysolyatin commented on code in PR #2819:
URL: https://github.com/apache/calcite/pull/2819#discussion_r884313553


##########
core/src/main/codegen/templates/Parser.jj:
##########
@@ -238,6 +238,39 @@ public class ${parser.class} extends SqlAbstractParserImpl
         return SqlStmtList();
     }
 
+    // Q: Is it the best way ???

Review Comment:
   Then I will need to pass ParserFactory to SqlValidatorImpl. If it is OK that validator will know about Parser then let's do like this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org