You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/11/09 15:24:08 UTC

[GitHub] [nifi-minifi-cpp] szaszm opened a new pull request, #1450: MINIFICPP-1981 Decrease default C2 heartbeat frequency

szaszm opened a new pull request, #1450:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1450

   The default 250 milliseconds heartbeat interval was unnecessarily frequent, and places a large burden on the server. This changes it to 30 sec, which is frequent enough in most use cases
   
   -------
   
   Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced
        in the commit message?
   
   - [x] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically main)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [x] If applicable, have you updated the LICENSE file?
   - [x] If applicable, have you updated the NOTICE file?
   
   ### For documentation related changes:
   - [x] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #1450: MINIFICPP-1981 Decrease default C2 heartbeat frequency

Posted by GitBox <gi...@apache.org>.
lordgamez commented on PR #1450:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1450#issuecomment-1308936572

   Not all of these are relevant to C2 usage, but I think we should update occurrences in these files as well:
   C2.md
   encrypt-config/tests/resources/minifi.properties
   encrypt-config/tests/resources/with-additional-sensitive-props.minifi.properties
   libminifi/test/resources/encrypted.minifi.properties


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] fgerlits closed pull request #1450: MINIFICPP-1981 Decrease default C2 heartbeat frequency

Posted by GitBox <gi...@apache.org>.
fgerlits closed pull request #1450: MINIFICPP-1981 Decrease default C2 heartbeat frequency
URL: https://github.com/apache/nifi-minifi-cpp/pull/1450


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org