[jira] [Commented] (FLINK-7441) Double quote string literals is not supported in Table API and SQL

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125403#comment-16125403 ] 

ASF GitHub Bot commented on FLINK-7441:
---------------------------------------

GitHub user wuchong opened a pull request:

    https://github.com/apache/flink/pull/4538

    [FLINK-7441] [table] Double quote string literals is not supported in Table API and SQL

    ## What is the purpose of the change
    
    Code generation doesn't handle double quote string literals and some control characters which leads to compile error.
    
    ## Brief change log
    
    - add string escape to `CodeGenerator#visitLiteral`
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
    
    - Added test `UserDefinedScalarFunctionTest#testDoubleQuoteParameters ` that validate double quotes can be handled correctly.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no
      - If yes, how is the feature documented? na
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wuchong/flink double-quote

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4538.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4538
    
----
commit fdec04d4fe9257b952bf2a150ab1cae9481e5f32
Author: Jark Wu <ja...@apache.org>
Date:   2017-08-14T08:44:16Z

    [FLINK-7441] [table] Double quote string literals is not supported in Table API and SQL

----


> Double quote string literals is not supported in Table API and SQL
> ------------------------------------------------------------------
>
>                 Key: FLINK-7441
>                 URL: https://issues.apache.org/jira/browse/FLINK-7441
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>            Reporter: Jark Wu
>            Assignee: Jark Wu
>
> Code generation doesn't handle double quote string literals and some control characters which leads to compile error.
> {code}
> Caused by: org.codehaus.commons.compiler.CompileException: Line 50, Column 48: Expression "hello" is not an rvalue
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)