You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@arrow.apache.org by "jorisvandenbossche (via GitHub)" <gi...@apache.org> on 2023/04/06 12:33:30 UTC

[GitHub] [arrow] jorisvandenbossche opened a new issue, #34929: [C++] Better support optional start/stop in "utf8_slice_codeunits" kernel

jorisvandenbossche opened a new issue, #34929:
URL: https://github.com/apache/arrow/issues/34929

   ### Describe the bug, including details regarding any error messages, version, and platform.
   
   There have been various (slightly different) bugs reported about using "utf8_slice_codeunits" with optional `start` or `step`. The `step` argument is already optional and translated into the largest int to indicate to always slice until the end, but that internal "workaround" also produces some bugs in the current implementation due to integer overflows. 
   
   Potentially, we could use a different mechanism to signal a default start/stop, such as using `std::optional<int64_t>` instead of `std::numeric_limits<int64_t>::max()`
   
   Listing the related issues:
   
   * https://github.com/apache/arrow/issues/14991
   * https://github.com/apache/arrow/issues/34917
   * https://github.com/apache/arrow/issues/34928
   
   ### Component(s)
   
   C++


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou commented on issue #34929: [C++] Better support optional start/stop in "utf8_slice_codeunits" kernel

Posted by "pitrou (via GitHub)" <gi...@apache.org>.

pitrou commented on issue #34929:
URL: https://github.com/apache/arrow/issues/34929#issuecomment-1630224829

   cc @benibus . This would slightly break the C++ API so we have to make sure this would make things better.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou commented on issue #34929: [C++] Better support optional start/stop in "utf8_slice_codeunits" kernel

Posted by "pitrou (via GitHub)" <gi...@apache.org>.

pitrou commented on issue #34929:
URL: https://github.com/apache/arrow/issues/34929#issuecomment-1637082272

   > If we were to modify `SliceOptions` directly then that would also affect the ascii kernel as well. Not opposed to doing that, just wanted to give a heads-up.
   
   I think it's fine to affect both kernels, and actually it's quite logical as well.
   
   If `std::optional` had been available to us before, we would probably have used it from the start here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] benibus commented on issue #34929: [C++] Better support optional start/stop in "utf8_slice_codeunits" kernel

Posted by "benibus (via GitHub)" <gi...@apache.org>.

benibus commented on issue #34929:
URL: https://github.com/apache/arrow/issues/34929#issuecomment-1634711809

   If we were to modify `SliceOptions` directly then that would also affect the ascii kernel as well. Not opposed to doing that, just wanted to give a heads-up.
   
   In any case, I'll probably try this with a distinct options class first to see how it goes with one of the kernels. Then we can determine if the breaking change is justified.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org