You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by bu...@apache.org on 2007/05/07 18:41:35 UTC

DO NOT REPLY [Bug 42346] New: - Objects that doesn�t save changes

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42346>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42346

           Summary: Objects that doesn�t save changes
           Product: JMeter
           Version: Nightly (Please specify date)
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Main
        AssignedTo: jmeter-dev@jakarta.apache.org
        ReportedBy: sdeuvarow@gmail.com


Sometimes, i made modifications on the sampler values
(change the file path in a CSV Config, or change the SQL in the JDBC Sampler),
and then i save the test plan.. but the sampler don�t save the changes. 
If i click another element in the tree and then click back the changes did not
appear.

1- New Test Plan
2- add thread group
3- add a csv data set config
4- change the file name, variable names and delimiter
5- save test plan in some directory
6- change the filename
7- click on thread group element
8- click back on the csv data set config
 -> see change didn�t was taken.

this is an example, but is more generic. the problem affect much more objects.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 42346] - Objects that doesn�t save changes

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42346>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42346





------- Additional Comments From sdeuvarow@gmail.com  2007-05-07 11:54 -------
(In reply to comment #1)
> What version of JMeter are you using?
> 
> Works OK for me in current nightly and 2.2.
> 
> What method are you using to save the test plan?
> 
> 

I download the last nightly and i have still the same problem.
I am using the jdk1.5.0_03.

In 2.2 i don�t have the problem.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 42346] - Objects that doesn�t save changes

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42346>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42346


sebb@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From sebb@apache.org  2007-05-08 16:30 -------
Thanks - applied in r536372

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 42346] - Objects that doesn�t save changes

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42346>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42346





------- Additional Comments From alf@i100.no  2007-05-08 03:00 -------
(In reply to comment #3)
> Which nightly exactly?
> 
> Which Save method did you use? 
> 
> Via right-click, via menu or via Control-S?

I'm trying with the latest source from SVN, and I am able to reproduce the problem.
Updates made after the test plan has been saved, I use the menu option
"File->Save all as...", on the node that are selected when you save the test
plan, are lost when you select another node. This only happens right after you
have saved the test plan, and only on the node that are selected when save is
invoked. I do not see the same problem in version 2.2.
I will do some more investigation,

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 42346] - Objects that doesn�t save changes

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42346>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42346





------- Additional Comments From sebb@apache.org  2007-05-07 12:24 -------
Which nightly exactly?

Which Save method did you use? 

Via right-click, via menu or via Control-S?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 42346] - Objects that doesn�t save changes

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42346>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42346


sebb@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO




------- Additional Comments From sebb@apache.org  2007-05-07 09:53 -------
What version of JMeter are you using?

Works OK for me in current nightly and 2.2.

What method are you using to save the test plan?



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 42346] - Objects that doesn�t save changes

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42346>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42346





------- Additional Comments From alf@i100.no  2007-05-08 03:25 -------
Created an attachment (id=20143)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=20143&action=view)
Suggested patch

This solves the problem I was able to reproduce, i.e. when changing the
selected node right after the test plan was saved.

It was related to the change in the GUIPackage, in SVN-535134, for bug 30120.
If I put back in
"
if (currentNode != treeListener.getCurrentNode()) {
   currentNodeUpdated = true;
}
", then this bug did not happen.
But I think it is better to change the Save action to call
GuiPackage.getInstance().updateCurrentGui() to set the currentNodeUpdated flag
to false.

If people find other scenarios where test plan changes are not stored, then we
might need to consider reverting the change.
But for now, I do not know of any issues after this suggested patch has been
applied.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org