You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/28 09:29:29 UTC

[GitHub] [incubator-superset] derari opened a new issue #9032: Add support for cockroach db

derari opened a new issue #9032: Add support for cockroach db
URL: https://github.com/apache/incubator-superset/issues/9032
 
 
   I use superset on a cockroach DB. After installing [the SQLAlchemy module](https://www.cockroachlabs.com/blog/building-application-cockroachdb-sqlalchemy-2/), setup of the database was no problem.
   
   However, I cannot pick time granularity for charts as they are "defined  per database engine in the superset source code".
   
   Since cockroach is a Postgres database, implementing this should be as simple as just making the existing Postgres time grain configuration available for cockroach.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] villebro commented on issue #9032: Add support for cockroach db

Posted by GitBox <gi...@apache.org>.
villebro commented on issue #9032: Add support for cockroach db
URL: https://github.com/apache/incubator-superset/issues/9032#issuecomment-579376194
 
 
   @derari , you need to create a new file `superset/db_engine_specs/cockroachdb.py`, where you specify any quirks that the cockroach dialect may have. I would start by extending `PostgresEngineSpec` from `superset/db_engine_specs/postgres.py` and making any necessary modifications. If you open up a PR I will be happy to help work out any problems you may encounter.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] villebro closed issue #9032: Add support for cockroach db

Posted by GitBox <gi...@apache.org>.
villebro closed issue #9032: Add support for cockroach db
URL: https://github.com/apache/incubator-superset/issues/9032
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org