[jira] [Commented] (CXF-6423) PrettyLoggingFilter tests and improvements

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CXF-6423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14561350#comment-14561350 ] 

ASF GitHub Bot commented on CXF-6423:
-------------------------------------

GitHub user skjolber opened a pull request:

    https://github.com/apache/cxf/pull/75

    [CXF-6423] PrettyLoggingFilter tests and improvements

    See task at 
    
    https://issues.apache.org/jira/browse/CXF-6423

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/skjolber/cxf master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cxf/pull/75.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #75
    
----
commit 14f456d60d55cdaf413ef0669ff6897660b5cab4
Author: Thomas Skjølberg <th...@gmail.com>
Date:   2015-05-27T16:46:53Z

    Logging Feature pretty-printing

----


> PrettyLoggingFilter tests and improvements
> ------------------------------------------
>
>                 Key: CXF-6423
>                 URL: https://issues.apache.org/jira/browse/CXF-6423
>             Project: CXF
>          Issue Type: Improvement
>            Reporter: Thomas Skjølberg
>            Priority: Minor
>
> Improvements for PrettyLoggingFilter in the cxf-rt-features-logging module: 
> 1. use a StringReader instead of getting bytes from a String and using an InputStream (capture encoding issues at an eariler stage)
> 2. add parser exception handling based on whether the payload is truncated or not; return original XML if deemed invalid
> 3. do not call XMLStreamWriter.close() before getting contents for truncated or invalid XML because some writers misbehave. 
> 4.construct output StringWriter with a size based on the raw XML string size
> 5.additional test cases 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)