You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/04/28 02:53:01 UTC

[GitHub] [trafficcontrol] ocket8888 opened a new pull request #4669: Removed 'sudo' from CiaB Makefile

ocket8888 opened a new pull request #4669:
URL: https://github.com/apache/trafficcontrol/pull/4669


   ## What does this PR (Pull Request) do?
   - [x] This PR is not related to any Issue
   
   This just removes `sudo` from the CDN-in-a-Box's Makefile, which was only used to accommodate my specific weird setup on my laptop where a user in the `docker` group for some reason didn't have permissions to use Docker. If that specific use-case still exists, people can just do `sudo make` to accomplish the same thing.
   
   ## Which Traffic Control components are affected by this PR?
   - CDN in a Box
   
   ## What is the best way to verify this PR?
   Run `make very-clean && make`, then make sure all CDN-in-a-Box images can build. Shouldn't be necessary to actually run them. No tests because CDN-in-a-Box isn't tested.
   
   ## The following criteria are ALL met by this PR
   - [x] This PR includes tests OR I have explained why tests are unnecessary
   - [x] This PR includes documentation OR I have explained why documentation is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org