You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2015/07/24 21:45:47 UTC
Re: Review Request 34129: Add 2 optional args public_ip and
public_port for libprocess to advertise.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34129/#review92977
-----------------------------------------------------------
Ship it!
docs/operational-guide.md (line 50)
<https://reviews.apache.org/r/34129/#comment147255>
why would zookeeper try to reach master?
s/zookeeper/framework scheduler/
- Vinod Kone
On May 18, 2015, 10:08 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34129/
> -----------------------------------------------------------
>
> (Updated May 18, 2015, 10:08 p.m.)
>
>
> Review request for mesos and Cosmin Lehene.
>
>
> Bugs: MESOS-809
> https://issues.apache.org/jira/browse/MESOS-809
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If set, these IP/Port shall be advertised by libprocess (although bind is
> not done on this IP/Port). If not set, libprocess advertises the IP/Port
> on which bind was done.
>
> Command line arguments added:
> public_ip: Public IP address to reach mesos. Defaults to the command line argument `ip`.
> public_port: Public port to reach mesos. Defaults to the command line argument `port`.
>
>
> Diffs
> -----
>
> docs/configuration.md 54c4e31ed6dfed3c23d492c19a301ce119a0519b
> docs/operational-guide.md 23b76ff129ca396a4b14a6826b4d842fc8527a8a
> src/master/http.cpp 01dbdad9720a9cd30505683ae1117970cda918a0
> src/master/main.cpp d5666bc8ee8d7a0f0b8685f76d65dd1f9ac2a280
>
> Diff: https://reviews.apache.org/r/34129/diff/
>
>
> Testing
> -------
>
> Testing:
> make test
>
>
> Thanks,
>
> Anindya Sinha
>
>