You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by kgiusti <gi...@git.apache.org> on 2018/12/03 19:13:29 UTC

[GitHub] qpid-dispatch pull request #422: DISPATCH-1205: accept valid integer sign co...

GitHub user kgiusti opened a pull request:

    https://github.com/apache/qpid-dispatch/pull/422

    DISPATCH-1205: accept valid integer sign coversions when parsing

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kgiusti/dispatch DISPATCH-1205

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-dispatch/pull/422.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #422
    
----
commit ac157282881fade8f3491227d7de3d71625deac4
Author: Kenneth Giusti <kg...@...>
Date:   2018-12-03T18:57:00Z

    DISPATCH-1205: accept valid integer sign coversions when parsing

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[GitHub] qpid-dispatch issue #422: DISPATCH-1205: accept valid integer sign coversion...

Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:

    https://github.com/apache/qpid-dispatch/pull/422
  
    # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/422?src=pr&el=h1) Report
    > :exclamation: No coverage uploaded for pull request base (`master@663a997`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
    > The diff coverage is `100%`.
    
    [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-dispatch/pull/422/graphs/tree.svg?width=650&token=rk2Cgd27pP&height=150&src=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/422?src=pr&el=tree)
    
    ```diff
    @@            Coverage Diff            @@
    ##             master     #422   +/-   ##
    =========================================
      Coverage          ?   87.88%           
    =========================================
      Files             ?       82           
      Lines             ?    17933           
      Branches          ?        0           
    =========================================
      Hits              ?    15760           
      Misses            ?     2173           
      Partials          ?        0
    ```
    
    
    | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/422?src=pr&el=tree) | Coverage Δ | |
    |---|---|---|
    | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/422/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=) | `88.01% <100%> (ø)` | |
    | [tests/parse\_test.c](https://codecov.io/gh/apache/qpid-dispatch/pull/422/diff?src=pr&el=tree#diff-dGVzdHMvcGFyc2VfdGVzdC5j) | `70.04% <100%> (ø)` | |
    
    ------
    
    [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/422?src=pr&el=continue).
    > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
    > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
    > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/422?src=pr&el=footer). Last update [663a997...d789bb2](https://codecov.io/gh/apache/qpid-dispatch/pull/422?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[GitHub] qpid-dispatch pull request #422: DISPATCH-1205: accept valid integer sign co...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/qpid-dispatch/pull/422


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org