You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "kumarUjjawal (via GitHub)" <gi...@apache.org> on 2026/05/12 12:52:47 UTC
[I] `array_replace` benchmark does not exercise the `array_replace` kernel [datafusion]
kumarUjjawal opened a new issue, #22121:
URL: https://github.com/apache/datafusion/issues/22121
### Describe the bug
The `array_replace` benchmark calls `expr_fn::array_replace_all`, which only constructs an `Expr::ScalarFunction` node, it does not execute the underlying `array_replace_all_inner` kernel.
As a result, the benchmark measures `Expr` construction and cloning, not kernel performance. It cannot detect regressions in the function it was originally introduced to protect (added in #8337 — "Avoid concat for array_replace").
### To Reproduce
`expr_fn::array_replace_all` is generated by `make_udf_expr_and_func!` and returns:
```rust
Expr::ScalarFunction { fun: array_replace_all_udf, args: [...] }
```
It never invokes array_replace_all_inner.
### Expected behavior
The benchmark should invoke the kernel on ArrayRef inputs, for example via the ScalarUDFImpl::invoke_* path or by calling array_replace_all_inner directly so that it measures actual replacement performance and guards against kernel regressions.
### Additional context
Discovered while investigating #18447.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] `array_replace` benchmark does not exercise the `array_replace` kernel [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #22121: `array_replace` benchmark does not exercise the `array_replace` kernel
URL: https://github.com/apache/datafusion/issues/22121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org