You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by mc...@apache.org on 2012/10/22 20:36:01 UTC

svn commit: r1400992 - /myfaces/trinidad/trunk/trinidad-impl/src/test/java/org/apache/myfaces/trinidadinternal/renderkit/RenderKitTestCase.java

Author: mcooper
Date: Mon Oct 22 18:36:00 2012
New Revision: 1400992

URL: http://svn.apache.org/viewvc?rev=1400992&view=rev
Log:
Minor tweak to how tests get added.

Modified:
    myfaces/trinidad/trunk/trinidad-impl/src/test/java/org/apache/myfaces/trinidadinternal/renderkit/RenderKitTestCase.java

Modified: myfaces/trinidad/trunk/trinidad-impl/src/test/java/org/apache/myfaces/trinidadinternal/renderkit/RenderKitTestCase.java
URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad-impl/src/test/java/org/apache/myfaces/trinidadinternal/renderkit/RenderKitTestCase.java?rev=1400992&r1=1400991&r2=1400992&view=diff
==============================================================================
--- myfaces/trinidad/trunk/trinidad-impl/src/test/java/org/apache/myfaces/trinidadinternal/renderkit/RenderKitTestCase.java (original)
+++ myfaces/trinidad/trunk/trinidad-impl/src/test/java/org/apache/myfaces/trinidadinternal/renderkit/RenderKitTestCase.java Mon Oct 22 18:36:00 2012
@@ -312,22 +312,6 @@ abstract public class RenderKitTestCase 
     }
 
     @Override
-    public void run(TestResult result)
-    {
-      if (!_script.isSupportedAgentType(getAgent().getType()))
-      {
-        /*
-        System.out.println("SKIPPING UNSUPPORTED SCRIPT: " + _scriptName);
-        System.out.println("AGENT IS " + getAgent());
-        System.out.println("AGENT TYPE IS " + getAgent().getType());
-        */
-        return;
-      }
-
-      super.run(result);
-    }
-
-    @Override
     protected void tearDown() throws IOException  
     {
       super.tearDown();
@@ -561,7 +545,11 @@ abstract public class RenderKitTestCase 
     SuiteDefinition definition, 
     boolean lenient) throws IOException, SAXException
   {
-    addTest(new RendererTest(name, definition, lenient));
+    RendererTest test = new RendererTest(name, definition, lenient);
+    if (test._script.isSupportedAgentType(test.getAgent().getType()))
+    {
+      addTest(test);
+    }
   }  
 
   protected abstract UIComponent populateDefaultComponentTree(