You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by gr...@apache.org on 2019/06/03 23:57:32 UTC
[incubator-superset] branch master updated: [dashboard] click tab
anchor link (#7640)
This is an automated email from the ASF dual-hosted git repository.
graceguo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new f99ae1a [dashboard] click tab anchor link (#7640)
f99ae1a is described below
commit f99ae1ad247298c8b8df3721768f69b13152aef0
Author: Grace Guo <gr...@airbnb.com>
AuthorDate: Mon Jun 3 16:57:21 2019 -0700
[dashboard] click tab anchor link (#7640)
---
superset/assets/src/components/AnchorLink.jsx | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/superset/assets/src/components/AnchorLink.jsx b/superset/assets/src/components/AnchorLink.jsx
index b33ee60..dac5e25 100644
--- a/superset/assets/src/components/AnchorLink.jsx
+++ b/superset/assets/src/components/AnchorLink.jsx
@@ -66,8 +66,7 @@ class AnchorLink extends React.PureComponent {
}
handleClickAnchorLink(ev) {
- ev.preventDefault();
- history.pushState(null, null, `#${this.props.anchorLinkId}`);
+ ev.stopPropagation();
}
render() {
@@ -76,6 +75,7 @@ class AnchorLink extends React.PureComponent {
<span
className="anchor-link-container"
id={anchorLinkId}
+ onClick={this.handleClickAnchorLink}
>
{showShortLinkButton &&
<URLShortLinkButton