You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/08/17 13:45:16 UTC
[GitHub] [lucene] mikemccand opened a new pull request #245: LUCENE-10052: first cut at LTC.newBytesRef methods, and switching a few test cases over
mikemccand opened a new pull request #245:
URL: https://github.com/apache/lucene/pull/245
# Description
Add a few overloaded `LuceneTestCase.newBytesRef` methods to make it easy to create `BytesRef` with non-zero offsets and with some extra padded bytes at the end of the underlying `byte[]`.
# Tests
I cutover a few test cases to use `newBytesRef` instead of `new BytesRef`.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/lucene/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Lucene maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [x] I have added tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mikemccand commented on pull request #245: LUCENE-10052: first cut at LTC.newBytesRef methods, and switching a few test cases over
Posted by GitBox <gi...@apache.org>.
mikemccand commented on pull request #245:
URL: https://github.com/apache/lucene/pull/245#issuecomment-900601218
> I like how easy it is to use from tests, just migrate from `new BytesRef(...` to `newBytesRef(...`.
Yeah! Just remove the one space character!
> As followup issues, we can look into migrating some more tests (especially more BaseXYZTestCase for other portions of the index format, so we at least know IW behaves). A few of them are already done here in this PR.
+1
I just picked a few "interesting" tests to switch over, and they seem to be passing at least after a few top-level `gradlew test` iterations. Progress not perfection!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mikemccand commented on pull request #245: LUCENE-10052: first cut at LTC.newBytesRef methods, and switching a few test cases over
Posted by GitBox <gi...@apache.org>.
mikemccand commented on pull request #245:
URL: https://github.com/apache/lucene/pull/245#issuecomment-900601218
> I like how easy it is to use from tests, just migrate from `new BytesRef(...` to `newBytesRef(...`.
Yeah! Just remove the one space character!
> As followup issues, we can look into migrating some more tests (especially more BaseXYZTestCase for other portions of the index format, so we at least know IW behaves). A few of them are already done here in this PR.
+1
I just picked a few "interesting" tests to switch over, and they seem to be passing at least after a few top-level `gradlew test` iterations. Progress not perfection!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mikemccand merged pull request #245: LUCENE-10052: first cut at LTC.newBytesRef methods, and switching a few test cases over
Posted by GitBox <gi...@apache.org>.
mikemccand merged pull request #245:
URL: https://github.com/apache/lucene/pull/245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mikemccand merged pull request #245: LUCENE-10052: first cut at LTC.newBytesRef methods, and switching a few test cases over
Posted by GitBox <gi...@apache.org>.
mikemccand merged pull request #245:
URL: https://github.com/apache/lucene/pull/245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org