[GitHub] [superset] etr2460 commented on a change in pull request #17766: fix: Remove positions from json_metadata

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #17766:
URL: https://github.com/apache/superset/pull/17766#discussion_r769818522



##########
File path: superset-frontend/src/dashboard/components/PropertiesModal/index.tsx
##########
@@ -161,10 +161,15 @@ const PropertiesModal = ({
 
       form.setFieldsValue(dashboardInfo);
       setDashboardInfo(dashboardInfo);
-      setJsonMetadata(metadata ? jsonStringify(metadata) : '');
       setOwners(owners);
       setRoles(roles);
       setColorScheme(metadata.color_scheme);
+
+      // temporary fix to remove positions from dashboards' metadata
+      if (metadata?.positions) {
+        delete metadata.positions;

Review comment:
       sorry, why would we be able to remove this in the future? or actually, why do we need this at all if we're removing the attribute in the backend below?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org