[jira] [Commented] (SYNCOPE-409) Allow notifications with empty about field

["Guido Wimmel (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SYNCOPE-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13733571#comment-13733571 ] 

Guido Wimmel commented on SYNCOPE-409:
--------------------------------------

I tried to provide an implementation for the suggested change, see the attached patch. The build and tests run successfully - but I am not an experienced Syncope developer, so this should be given a closer look.

In particular, I've changed the console such that the about search condition is "not required" and added the possibility to select empty values for the search condition attributes.

As an alternative, one could implement the GUI change similar to the "Recipients" tab (i.e. add a checkbox to the about tab and grey out the search condition if the check box is not selected). If this is preferred, I could change my implementation. In this case, I'd suggest a label for the checkbox ("restrict notifications to matching users"?) but cannot provide the translations.
                
> Allow notifications with empty about field
> ------------------------------------------
>
>                 Key: SYNCOPE-409
>                 URL: https://issues.apache.org/jira/browse/SYNCOPE-409
>             Project: Syncope
>          Issue Type: Improvement
>          Components: console, core
>    Affects Versions: 1.1.3
>            Reporter: Guido Wimmel
>            Priority: Minor
>         Attachments: syncopeNotificationsEmptyAbout.patch
>
>
> Currently, when one creates a new notification in Syncope, one is forced to enter a user search condition in the "About" tab that allows to restrict the notifications to specific users. IMO this is not always necessary - it should also be possible to leave the field empty such that the notification is sent for all users.
> Allowing the Notification.about field to be empty would also improve performance in this case, as an unnecessary search query to the database can be avoided. This is especially relevant for MySQL, as we observed full table scan behaviour for queries executed by AttributableSearchDAOImpl.matches() (called by NotificationManager) for even very simple search conditions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira