You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/05/22 03:21:04 UTC

[GitHub] [incubator-superset] mistercrunch opened a new pull request #9881: chore: don't create examples db on 'superset init'

mistercrunch opened a new pull request #9881:
URL: https://github.com/apache/incubator-superset/pull/9881


   ### SUMMARY
   `superset init` should not create the examples database as it does now
   
   closes https://github.com/apache/incubator-superset/issues/9879


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9881: fix: don't create examples db on 'superset init'

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9881:
URL: https://github.com/apache/incubator-superset/pull/9881#issuecomment-632457872


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=h1) Report
   > Merging [#9881](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3e8e441bfcb5b188840d3d08265073db1f67d1a6&el=desc) will **decrease** coverage by `4.96%`.
   > The diff coverage is `83.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9881/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9881      +/-   ##
   ==========================================
   - Coverage   71.24%   66.27%   -4.97%     
   ==========================================
     Files         584      584              
     Lines       30790    30606     -184     
     Branches     3238     3142      -96     
   ==========================================
   - Hits        21936    20285    -1651     
   - Misses       8744    10136    +1392     
   - Partials      110      185      +75     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.44% <ø> (ø)` | |
   | #python | `71.13% <83.33%> (-0.25%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `36.72% <ø> (-3.00%)` | :arrow_down: |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.20% <100.00%> (ø)` | |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.29% <100.00%> (-0.01%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.21% <100.00%> (-0.24%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.85% <100.00%> (-0.12%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [179 more](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=footer). Last update [3e8e441...217178f](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9881: fix: don't create examples db on 'superset init'

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9881:
URL: https://github.com/apache/incubator-superset/pull/9881#issuecomment-632457872






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9881: fix: don't create examples db on 'superset init'

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9881:
URL: https://github.com/apache/incubator-superset/pull/9881#issuecomment-632457872


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=h1) Report
   > Merging [#9881](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3e8e441bfcb5b188840d3d08265073db1f67d1a6&el=desc) will **decrease** coverage by `0.14%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9881/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9881      +/-   ##
   ==========================================
   - Coverage   71.24%   71.10%   -0.15%     
   ==========================================
     Files         584      584              
     Lines       30790    30606     -184     
     Branches     3238     3234       -4     
   ==========================================
   - Hits        21936    21761     -175     
   + Misses       8744     8736       -8     
   + Partials      110      109       -1     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.83% <ø> (ø)` | |
   | #javascript | `59.44% <ø> (ø)` | |
   | #python | `71.14% <ø> (-0.25%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `36.72% <ø> (-3.00%)` | :arrow_down: |
   | [superset/views/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `35.13% <0.00%> (-4.11%)` | :arrow_down: |
   | [superset/models/sql\_types/presto\_sql\_types.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9wcmVzdG9fc3FsX3R5cGVzLnB5) | `72.41% <0.00%> (-4.06%)` | :arrow_down: |
   | [superset/models/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3RhZ3MucHk=) | `58.58% <0.00%> (-3.80%)` | :arrow_down: |
   | [superset/views/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `59.06% <0.00%> (-3.29%)` | :arrow_down: |
   | [superset/views/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYXBpLnB5) | `63.63% <0.00%> (-2.08%)` | :arrow_down: |
   | [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `67.74% <0.00%> (-1.96%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.16% <0.00%> (-0.90%)` | :arrow_down: |
   | [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.95% <0.00%> (-0.72%)` | :arrow_down: |
   | ... and [26 more](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=footer). Last update [3e8e441...07d32ac](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9881: fix: don't create examples db on 'superset init'

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9881:
URL: https://github.com/apache/incubator-superset/pull/9881#issuecomment-632457872


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=h1) Report
   > Merging [#9881](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3e8e441bfcb5b188840d3d08265073db1f67d1a6&el=desc) will **decrease** coverage by `0.14%`.
   > The diff coverage is `83.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9881/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9881      +/-   ##
   ==========================================
   - Coverage   71.24%   71.10%   -0.15%     
   ==========================================
     Files         584      584              
     Lines       30790    30606     -184     
     Branches     3238     3142      -96     
   ==========================================
   - Hits        21936    21761     -175     
   + Misses       8744     8736       -8     
   + Partials      110      109       -1     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.83% <ø> (ø)` | |
   | #javascript | `59.44% <ø> (ø)` | |
   | #python | `71.14% <83.33%> (-0.25%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `36.72% <ø> (-3.00%)` | :arrow_down: |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.20% <100.00%> (ø)` | |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.29% <100.00%> (-0.01%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.21% <100.00%> (-0.24%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.85% <100.00%> (-0.12%)` | :arrow_down: |
   | [superset/views/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `35.13% <0.00%> (-4.11%)` | :arrow_down: |
   | [superset/models/sql\_types/presto\_sql\_types.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9wcmVzdG9fc3FsX3R5cGVzLnB5) | `72.41% <0.00%> (-4.06%)` | :arrow_down: |
   | [superset/models/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3RhZ3MucHk=) | `58.58% <0.00%> (-3.80%)` | :arrow_down: |
   | ... and [31 more](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=footer). Last update [3e8e441...217178f](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-commenter commented on pull request #9881: fix: don't create examples db on 'superset init'

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #9881:
URL: https://github.com/apache/incubator-superset/pull/9881#issuecomment-632457872


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=h1) Report
   > Merging [#9881](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3e8e441bfcb5b188840d3d08265073db1f67d1a6&el=desc) will **decrease** coverage by `11.80%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9881/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #9881       +/-   ##
   ===========================================
   - Coverage   71.24%   59.44%   -11.81%     
   ===========================================
     Files         584      400      -184     
     Lines       30790    12717    -18073     
     Branches     3238     3234        -4     
   ===========================================
   - Hits        21936     7559    -14377     
   + Misses       8744     4973     -3771     
   - Partials      110      185       +75     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.44% <ø> (ø)` | |
   | #python | `?` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [321 more](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=footer). Last update [3e8e441...07d32ac](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] mistercrunch commented on pull request #9881: fix: don't create examples db on 'superset init'

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #9881:
URL: https://github.com/apache/incubator-superset/pull/9881#issuecomment-632465337


   Looks like isort is having some confusion around py3.6 and py3.7 (?)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9881: fix: don't create examples db on 'superset init'

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9881:
URL: https://github.com/apache/incubator-superset/pull/9881#issuecomment-632457872






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9881: fix: don't create examples db on 'superset init'

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9881:
URL: https://github.com/apache/incubator-superset/pull/9881#issuecomment-632457872


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=h1) Report
   > Merging [#9881](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3e8e441bfcb5b188840d3d08265073db1f67d1a6&el=desc) will **decrease** coverage by `5.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9881/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9881      +/-   ##
   ==========================================
   - Coverage   71.24%   66.24%   -5.01%     
   ==========================================
     Files         584      584              
     Lines       30790    30606     -184     
     Branches     3238     3234       -4     
   ==========================================
   - Hits        21936    20274    -1662     
   - Misses       8744    10147    +1403     
   - Partials      110      185      +75     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.44% <ø> (ø)` | |
   | #python | `71.07% <ø> (-0.32%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `36.72% <ø> (-3.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [174 more](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=footer). Last update [3e8e441...07d32ac](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] mistercrunch edited a comment on pull request #9881: fix: don't create examples db on 'superset init'

Posted by GitBox <gi...@apache.org>.
mistercrunch edited a comment on pull request #9881:
URL: https://github.com/apache/incubator-superset/pull/9881#issuecomment-632465337


   Looks like isort is having some confusion around py3.6 and py3.7 (?)
   
   I'm 3.7 locally somehow, but CI is 3.6 and passes...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9881: fix: don't create examples db on 'superset init'

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9881:
URL: https://github.com/apache/incubator-superset/pull/9881#issuecomment-632457872


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=h1) Report
   > Merging [#9881](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3e8e441bfcb5b188840d3d08265073db1f67d1a6&el=desc) will **decrease** coverage by `5.11%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9881/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9881      +/-   ##
   ==========================================
   - Coverage   71.24%   66.13%   -5.12%     
   ==========================================
     Files         584      584              
     Lines       30790    30606     -184     
     Branches     3238     3234       -4     
   ==========================================
   - Hits        21936    20240    -1696     
   - Misses       8744    10181    +1437     
   - Partials      110      185      +75     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.44% <ø> (ø)` | |
   | #python | `70.88% <ø> (-0.51%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `36.72% <ø> (-3.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [183 more](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=footer). Last update [3e8e441...07d32ac](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9881: fix: don't create examples db on 'superset init'

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9881:
URL: https://github.com/apache/incubator-superset/pull/9881#issuecomment-632457872


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=h1) Report
   > Merging [#9881](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3e8e441bfcb5b188840d3d08265073db1f67d1a6&el=desc) will **decrease** coverage by `5.11%`.
   > The diff coverage is `83.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9881/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9881      +/-   ##
   ==========================================
   - Coverage   71.24%   66.13%   -5.12%     
   ==========================================
     Files         584      584              
     Lines       30790    30606     -184     
     Branches     3238     3142      -96     
   ==========================================
   - Hits        21936    20240    -1696     
   - Misses       8744    10181    +1437     
   - Partials      110      185      +75     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.44% <ø> (ø)` | |
   | #python | `70.88% <83.33%> (-0.51%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `36.72% <ø> (-3.00%)` | :arrow_down: |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.91% <100.00%> (-0.30%)` | :arrow_down: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.29% <100.00%> (-0.01%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.21% <100.00%> (-0.24%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.85% <100.00%> (-0.12%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [189 more](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=footer). Last update [3e8e441...217178f](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9881: fix: don't create examples db on 'superset init'

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9881:
URL: https://github.com/apache/incubator-superset/pull/9881#issuecomment-632457872


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=h1) Report
   > Merging [#9881](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3e8e441bfcb5b188840d3d08265073db1f67d1a6&el=desc) will **increase** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9881/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #9881   +/-   ##
   =======================================
     Coverage   71.24%   71.24%           
   =======================================
     Files         584      584           
     Lines       30790    30789    -1     
     Branches     3238     3234    -4     
   =======================================
     Hits        21936    21936           
     Misses       8744     8744           
   + Partials      110      109    -1     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.83% <ø> (ø)` | |
   | #javascript | `59.44% <ø> (ø)` | |
   | #python | `71.39% <ø> (+<0.01%)` | :arrow_up: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `39.86% <ø> (+0.13%)` | :arrow_up: |
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `66.81% <0.00%> (ø)` | |
   | [...rontend/src/explore/components/PropertiesModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Qcm9wZXJ0aWVzTW9kYWwudHN4) | `16.66% <0.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=footer). Last update [3e8e441...07d32ac](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9881: fix: don't create examples db on 'superset init'

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9881:
URL: https://github.com/apache/incubator-superset/pull/9881#issuecomment-632457872


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=h1) Report
   > Merging [#9881](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3e8e441bfcb5b188840d3d08265073db1f67d1a6&el=desc) will **decrease** coverage by `0.35%`.
   > The diff coverage is `83.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9881/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9881      +/-   ##
   ==========================================
   - Coverage   71.24%   70.88%   -0.36%     
   ==========================================
     Files         584      184     -400     
     Lines       30790    17889   -12901     
     Branches     3238        0    -3238     
   ==========================================
   - Hits        21936    12681    -9255     
   + Misses       8744     5208    -3536     
   + Partials      110        0     -110     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `70.88% <83.33%> (-0.51%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `36.72% <ø> (-3.00%)` | :arrow_down: |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.91% <100.00%> (-0.30%)` | :arrow_down: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
   | [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.29% <100.00%> (-0.01%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.21% <100.00%> (-0.24%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.85% <100.00%> (-0.12%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
   | [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | ... and [441 more](https://codecov.io/gh/apache/incubator-superset/pull/9881/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=footer). Last update [3e8e441...217178f](https://codecov.io/gh/apache/incubator-superset/pull/9881?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] mistercrunch merged pull request #9881: fix: don't create examples db on 'superset init'

Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #9881:
URL: https://github.com/apache/incubator-superset/pull/9881


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org