help from autoconf savvy folks -- mod_deflate zlib detection?

[Eric Covener <co...@gmail.com>]

I'm setting up a new system to test httpd releases, with a crufty OS
that doesn't have good packaged prereqs and doesn't have years of my
own kludges giving me anything for free.

I've built and installed zlib into a random directory.  I can't see
how recent work in the area broke this, but doesn't the assignment on
line 48 discard the explicit directory passed in
--with-z=/usr/otherlocal ?

http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/filters/config.m4?annotate=1146227

I wasn't sure if the assignment should just be moved up before the
break (i guess ap_cv_zlib can also come in via native env, so this
seems wrong), or if with the $withval should just set also $ac_cv_zlib
(seems redundant) or if the block just needs rework (too scary for me)

-- 
Eric Covener
covener@gmail.com

Re: help from autoconf savvy folks -- mod_deflate zlib detection?

[Rainer Jung <ra...@kippdata.de>]

On 02.08.2011 13:00, Eric Covener wrote:
>> Line 48 is surrounded by
>>
>> if test "x$ap_zlib_base" = "x"; then
>>
>> and ap_zlib_base ist set when using --with-z. So in this case the
>> automatic detection part should be skipped.
>>
>> What problem do you actually observe?
> 
> Can't get it to misbehave at all this morning, even in a new scratch
> directory, with the old config.nice!  I recall the message being the
> auto-detection failure to find a zlib, and went away when I copied
> ap_zlib_base to ap_cv_zlib in the $with processing.
> 
> Still no idea what was happening, but I guess I was fooled by the
> apparent behavior and the whitespace in the generated configure.

Yeah, that's a major pita, configure isn't readable due to missing
indentation.

Regards,

Rainer

Re: help from autoconf savvy folks -- mod_deflate zlib detection?

[Eric Covener <co...@gmail.com>]

> Line 48 is surrounded by
>
> if test "x$ap_zlib_base" = "x"; then
>
> and ap_zlib_base ist set when using --with-z. So in this case the
> automatic detection part should be skipped.
>
> What problem do you actually observe?

Can't get it to misbehave at all this morning, even in a new scratch
directory, with the old config.nice!  I recall the message being the
auto-detection failure to find a zlib, and went away when I copied
ap_zlib_base to ap_cv_zlib in the $with processing.

Still no idea what was happening, but I guess I was fooled by the
apparent behavior and the whitespace in the generated configure.

Re: help from autoconf savvy folks -- mod_deflate zlib detection?

[Rainer Jung <ra...@kippdata.de>]

Hi Eric,

On 02.08.2011 04:40, Eric Covener wrote:
> I'm setting up a new system to test httpd releases, with a crufty OS
> that doesn't have good packaged prereqs and doesn't have years of my
> own kludges giving me anything for free.
> 
> I've built and installed zlib into a random directory.  I can't see
> how recent work in the area broke this, but doesn't the assignment on
> line 48 discard the explicit directory passed in
> --with-z=/usr/otherlocal ?
> 
> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/filters/config.m4?annotate=1146227
> 
> I wasn't sure if the assignment should just be moved up before the
> break (i guess ap_cv_zlib can also come in via native env, so this
> seems wrong), or if with the $withval should just set also $ac_cv_zlib
> (seems redundant) or if the block just needs rework (too scary for me)

Line 48 is surrounded by

if test "x$ap_zlib_base" = "x"; then

and ap_zlib_base ist set when using --with-z. So in this case the
automatic detection part should be skipped.

What problem do you actually observe?

Regards,

Rainer