[jira] [Updated] (HADOOP-8154) DNS#getIPs shouldn't silently return the local host IP for bogus interface names

["Eli Collins (Updated) (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HADOOP-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Collins updated HADOOP-8154:
--------------------------------

    Attachment: hadoop-8154.txt

Patch attached

- Updated javadocs to reflect the actual behavior
- Add a warning when we use the cached hostname because we can't determine the hostname
- Add testGetIPWithDefault to ensure the behavior for "default" is preserved
- Update testIPsOfUnknownInterface
- Updated testNullInterface to cover getDefaultIP
- Convert TestDNS to junit4

                
> DNS#getIPs shouldn't silently return the local host IP for bogus interface names
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-8154
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8154
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: conf
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: hadoop-8154.txt
>
>
> DNS#getIPs silently returns the local host IP for bogus interface names. In this case let's throw an UnknownHostException. This is technically an incompatbile change. I suspect the current behavior was origininally introduced so the interface name "default" works w/o explicitly checking for it. It may also be used in cases where someone is using a shared config file and an option like "dfs.datanode.dns.interface" or "hbase.master.dns.interface" and eg interface "eth3" that some hosts don't have, though I think silently ignorning this is the wrong behavior (those hosts should be configured to use a different interface).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira