You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/09/30 12:24:20 UTC
[GitHub] [cloudstack] div8cn opened a new pull request #5540: kvm available memory calculation optimization
div8cn opened a new pull request #5540:
URL: https://github.com/apache/cloudstack/pull/5540
### Description
Add buffer memory to Available memory for kvm
https://github.com/apache/cloudstack/issues/5523
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5540: kvm available memory calculation optimization
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5540:
URL: https://github.com/apache/cloudstack/pull/5540#issuecomment-933273838
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5540: kvm available memory calculation optimization
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5540:
URL: https://github.com/apache/cloudstack/pull/5540#issuecomment-933274051
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5540: kvm available memory calculation optimization
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5540:
URL: https://github.com/apache/cloudstack/pull/5540#issuecomment-931324968
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #5540: kvm available memory calculation optimization
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #5540:
URL: https://github.com/apache/cloudstack/pull/5540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5540: kvm available memory calculation optimization
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5540:
URL: https://github.com/apache/cloudstack/pull/5540#issuecomment-934192687
@nvazquez should we consider this for 4.16?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5540: kvm available memory calculation optimization
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5540:
URL: https://github.com/apache/cloudstack/pull/5540#issuecomment-933133716
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5540: kvm available memory calculation optimization
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5540:
URL: https://github.com/apache/cloudstack/pull/5540#issuecomment-931281622
@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5540: kvm available memory calculation optimization
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5540:
URL: https://github.com/apache/cloudstack/pull/5540#issuecomment-931928483
@div8cn Can you check/fix the unit test failure.
```
[INFO] Running org.apache.cloudstack.utils.linux.MemStatTest
[ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.602 s <<< FAILURE! - in org.apache.cloudstack.utils.linux.MemStatTest
[ERROR] getMemInfoParseTest(org.apache.cloudstack.utils.linux.MemStatTest) Time elapsed: 0.011 s <<< FAILURE!
java.lang.AssertionError: expected:<3164520448> but was:<2829840384>
at org.apache.cloudstack.utils.linux.MemStatTest.getMemInfoParseTest(MemStatTest.java:51)
[ERROR] Failures:
[ERROR] MemStatTest.getMemInfoParseTest:51 expected:<3164520448> but was:<2829840384>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5540: kvm available memory calculation optimization
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5540:
URL: https://github.com/apache/cloudstack/pull/5540#issuecomment-931280346
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5540: kvm available memory calculation optimization
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5540:
URL: https://github.com/apache/cloudstack/pull/5540#issuecomment-931357034
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 1460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5540: kvm available memory calculation optimization
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5540:
URL: https://github.com/apache/cloudstack/pull/5540#issuecomment-934298465
> @nvazquez should we consider this for 4.16?
I think, this is good to go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5540: kvm available memory calculation optimization
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5540:
URL: https://github.com/apache/cloudstack/pull/5540#issuecomment-933133424
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #5540: kvm available memory calculation optimization
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #5540:
URL: https://github.com/apache/cloudstack/pull/5540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5540: kvm available memory calculation optimization
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5540:
URL: https://github.com/apache/cloudstack/pull/5540#issuecomment-933143350
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5540: kvm available memory calculation optimization
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5540:
URL: https://github.com/apache/cloudstack/pull/5540#issuecomment-931292754
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 1459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5540: kvm available memory calculation optimization
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5540:
URL: https://github.com/apache/cloudstack/pull/5540#issuecomment-931313179
@div8cn please fix the checkstyle error
```
[ERROR] /data/git/cloudstack/plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/linux/MemStat.java:69: Line has trailing spaces. [RegexpSingleline]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5540: kvm available memory calculation optimization
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5540:
URL: https://github.com/apache/cloudstack/pull/5540#issuecomment-933784323
<b>Trillian test result (tid-2312)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36962 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5540-t2312-kvm-centos7.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5540: kvm available memory calculation optimization
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5540:
URL: https://github.com/apache/cloudstack/pull/5540#issuecomment-931325463
@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org