[jira] [Commented] (HDFS-16787) Remove redundant lock in DataSetLockManager#removeLock in datanode.

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-16787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17610784#comment-17610784 ] 

ASF GitHub Bot commented on HDFS-16787:
---------------------------------------

ZanderXu opened a new pull request, #4948:
URL: https://github.com/apache/hadoop/pull/4948

   ### Description of PR
   During patching the datanode fine-grained locking, found there is a redundant lock in DataSetLockManager#removeLock, and the code as bellow:
   ```
   @Override
   public void removeLock(LockLevel level, String... resources) {
     String lockName = generateLockName(level, resources);
     try (AutoCloseDataSetLock lock = writeLock(level, resources)) {
       // Here, this lock is redundant.
       lock.lock();
       lockMap.removeLock(lockName);
     }
   } 
   ```
   
   




> Remove redundant lock in DataSetLockManager#removeLock in datanode.
> -------------------------------------------------------------------
>
>                 Key: HDFS-16787
>                 URL: https://issues.apache.org/jira/browse/HDFS-16787
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: ZanderXu
>            Assignee: ZanderXu
>            Priority: Major
>
> During patching the datanode fine-grained locking, found there is a redundant lock in DataSetLockManager#removeLock, and the code as bellow:
> {code:java}
> @Override
> public void removeLock(LockLevel level, String... resources) {
>   String lockName = generateLockName(level, resources);
>   try (AutoCloseDataSetLock lock = writeLock(level, resources)) {
>     // Here, this lock is redundant.
>     lock.lock();
>     lockMap.removeLock(lockName);
>   }
> } {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org