You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by ar...@apache.org on 2017/09/04 14:29:56 UTC
mesos git commit: Fixed unnecessary non-constness.
Repository: mesos
Updated Branches:
refs/heads/master 40aa0d9f7 -> dfe4fc84e
Fixed unnecessary non-constness.
Const `Owned` doesn't make the underlying pointer const.
Review: https://reviews.apache.org/r/62016/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/dfe4fc84
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/dfe4fc84
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/dfe4fc84
Branch: refs/heads/master
Commit: dfe4fc84e510dd228994e4e45068b89d5501feca
Parents: 40aa0d9
Author: Ilya Pronin <ip...@twopensource.com>
Authored: Mon Sep 4 16:15:30 2017 +0200
Committer: Alexander Rojas <al...@mesosphere.io>
Committed: Mon Sep 4 16:29:47 2017 +0200
----------------------------------------------------------------------
3rdparty/libprocess/src/process.cpp | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/dfe4fc84/3rdparty/libprocess/src/process.cpp
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/src/process.cpp b/3rdparty/libprocess/src/process.cpp
index afa5353..0bfc6d6 100644
--- a/3rdparty/libprocess/src/process.cpp
+++ b/3rdparty/libprocess/src/process.cpp
@@ -3101,9 +3101,7 @@ void ProcessManager::handle(
}
synchronized (firewall_mutex) {
- // Don't use a const reference, since it cannot be guaranteed
- // that the rules don't keep an internal state.
- foreach (Owned<firewall::FirewallRule>& rule, firewallRules) {
+ foreach (const Owned<firewall::FirewallRule>& rule, firewallRules) {
Option<Response> rejection = rule->apply(socket, *request);
if (rejection.isSome()) {
VLOG(1) << "Returning '"<< rejection.get().status << "' for '"