[GitHub] [druid] jihoonson edited a comment on pull request #10093: Add groupBy limitSpec to queryCache key

[GitBox <gi...@apache.org>]

jihoonson edited a comment on pull request #10093:
URL: https://github.com/apache/druid/pull/10093#issuecomment-654502620


   > @jihoonson : Yes, its an issue when limitSpec if pushed down, other thing to note, if you push down the limit once and then try to execute a query without pushing down the limit or remove the limit itself, then also it will be problematic as the cache will have the results with limit and the results will be served from cache.
   
   Thanks for the confirm. The symptom sounds reasonable since we currently don't include the limitSpec in the cache key at all. However, should the limitSpec be included only when `GroupByQuery.isApplyLimitPushDown() = true` then? When the limitSpec is processed in the post process step, the cache should be reusable for other queries if they are same except limitSpec similar to `HavingSpec`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org