[GitHub] [superset] zhaoyongjie commented on a change in pull request #13020: fix: Let superset configure the correct time display according to locale

[GitBox <gi...@apache.org>]

zhaoyongjie commented on a change in pull request #13020:
URL: https://github.com/apache/superset/pull/13020#discussion_r572652460



##########
File path: superset/views/base.py
##########
@@ -327,6 +329,17 @@ def common_bootstrap_payload() -> Dict[str, Any]:
     }
 
 
+def get_moment_locale(locale):

Review comment:
       We need a config that accurately sets the time zone instead of relying on the `flask_babel` language setting. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org